Re: [tim-janik/beast] Most Bus properties ported to C++ (#78)

Closed #78. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/tim-janik/beast/pull/78#event-2356239447___ beast mailing list beast@gnome.org

Re: [tim-janik/beast] Most Bus properties ported to C++ (#78)

> So, to summarize our last meeting: > > * The bus properties should be ported as straight forward as possible, > without adding new functionality / UI. > * The APPLY_IDL_PROPERTY() macro should be used. > > Once you've done this, please re-assign the new code to me. I'm doing this in an new

Re: [tim-janik/beast] Most Bus properties ported to C++ (#78)

Ok, so let me comment on anything that doesn't have to do with the new volume_db/pan properties first. > Thanks Stefan, great to see steady progress here. > > But note that travis-ci shows, that your changes broke the syndrum audio test > in all build variants, please take a look at that.

Re: [tim-janik/beast] Most Bus properties ported to C++ (#78)

@swesterfeld pushed 1 commit. 5f86778 BSE: bsebus: add a few extra checks to volume/pan conversions -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [tim-janik/beast] Most Bus properties ported to C++ (#78)

@swesterfeld pushed 1 commit. 1fab351 BSE: Song: port remaining Bus::master-output set calls -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [tim-janik/beast] Most Bus properties ported to C++ (#78)

@swesterfeld pushed 4 commits. 752ee2a BSE: implement Bus::volume_db and Bus::pan properties ea333df BSE: remove Bus::sync property, no longer required due to panning support 39a9064 BEAST-GTK: bstbuseditor: edit volume_db/pan instead of left/right volume 94028c4 RES: add space for editing

Re: [tim-janik/beast] Most Bus properties ported to C++ (#78)

> > On 09.09.2018 15:21, Stefan Westerfeld via beast wrote: > Instead of two volume sliders we only need one. The two meters could be put > next to each other. So this would mean left-to-right volume slider (only one > slider), scale numbers (-96..+12), left meter, right meter. Do you intend to

Re: [tim-janik/beast] Most Bus properties ported to C++ (#78)

@swesterfeld pushed 1 commit. 36e9df0 BSE: bsebus: avoid chained assignment -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [tim-janik/beast] Most Bus properties ported to C++ (#78)

@swesterfeld pushed 1 commit. 4084bb6 BSE: fix C++ property loading (float64) -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [tim-janik/beast] Most Bus properties ported to C++ (#78)

Thanks Stefan, great to see steady progress here. But note that travis-ci shows, that your changes broke the syndrum audio test in all build variants, please take a look at that. About volume clamping, taking a look at other DAWs suggests that this should be done at the UI and doesn't need to