Re: [tim-janik/beast] Jack driver new api (#128)

2019-09-20 Thread Tim Janik via beast
tim-janik requested changes on this pull request. Great work Stefan, thanks for the updates. I've pointed out a few places that still need work. > +fast_copy (uintn_values, + Data *ovalues, + const Data *ivalues) +{ + copy (ivalues, ivalues + n_values, ovalues);

Re: [tim-janik/beast] BSE: driver-alsa.cc: fix crash in retrigger code (#127)

2019-09-20 Thread Tim Janik via beast
tim-janik requested changes on this pull request. > @@ -427,7 +427,8 @@ class AlsaPcmDriver : public PcmDriver { if (write_handle_) { int n, buffer_length = n_periods_ * period_size_; // buffer size chosen by ALSA based on latency request -const float *zeros =

[tim-janik/beast] Jack driver new api (#128)

2019-09-20 Thread Stefan Westerfeld via beast
Ok, here is a port of the Jack driver (https://github.com/tim-janik/beast/pull/31) to the new driver API. I tested playback and also stereo-through. This doesnt yet have midi support. You can view, comment on, or merge this pull request online at: https://github.com/tim-janik/beast/pull/128

Re: [tim-janik/beast] BSE: driver-alsa.cc: fix buffer for pcm writes during retrigger, fixes #127 (644460e)

2019-09-20 Thread Stefan Westerfeld via beast
This could break if n_channels_ is large (24 or something). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [tim-janik/beast] BSE: driver-alsa.cc: fix crash in retrigger code (#127)

2019-09-20 Thread Tim Janik via beast
Closed #127 via 644460eb0ec5aea103eec2d85b919624fdb2cedf. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tim-janik/beast/pull/127#event-2650279047___ beast