Great! Thanks a lot for the detailed analysis.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tim-janik/beast/pull/140#issuecomment-658463809___
beast mailing
As additional information, g++-8 also generates different code if you use -mfma.
```
$ out/tests/suite1 --resampler accuracy --fpu --precision=24 --subsample
--freq-scan=90,9000,983 --freq-scan-verbose --verbose
## g++ 8.3.0 without fma
# accuracy test for factor 2 subsampling using
> Did you find out _why_ this is needed?
> I.e. peeked at the generated assembly to figure if -ffast-math related
> options possibly allow transformations that could become problematic for us
> in the long term?
**Short answer:**
I spent some time debugging it, -mfma is causing this - removing
> Relax expected accuracy for 24-bit subsampling from 126 to 124.5 dB, to fix
> testresampler for clang9.
>
> This should fix #139.
Did you find out *why* this is needed?
I.e. peeked at the generated assembly to figure if -ffast-math related options
possibly allow transformations that could
Relax expected accuracy for 24-bit subsampling from 126 to 124.5 dB, to fix
testresampler for clang9.
This should fix #139.
You can view, comment on, or merge this pull request online at:
https://github.com/tim-janik/beast/pull/140
-- Commit Summary --
* TESTS: testresampler: fix resampler
