Re: [Beignet] patch to get beignet to compile on gcc 3.5.0

2016-03-28 Thread Pan, Xiuli
Hi Sean, I do find that in cmath the isnan and isinf is in std namespace even in gcc 5.2 , but strangely we haven’t facing this problem. I am using Ubuntu and I could not find any Arch Linux to have a test. You patch can definitely solved the problem on arch linux, and could you send a patch

Re: [Beignet] [PATCH] Backend: Clang now support static, fix now

2016-03-28 Thread Pan, Xiuli
Hi Ruiling, I will do some test. But I think I should try to find which clang version start to support static and may be use some macro to handle this. Thanks Xiuli -Original Message- From: Song, Ruiling Sent: Tuesday, March 29, 2016 11:52 AM To: Pan, Xiuli ;

Re: [Beignet] [PATCH] Backend: Clang now support static, fix now

2016-03-28 Thread Song, Ruiling
Hi Xiuli, The patch is OK for me. I would like this to be merged into OCL20 branch first. Have you done some test against master branch? I just want to make sure it does not break anything in OpenCL 1.2. Thanks! Ruiling > -Original Message- > From: Beignet

Re: [Beignet] [PATCH] Libocl: change prototype of math built-in for OCL2.0 spec

2016-03-28 Thread Song, Ruiling
LGTM Thanks! Ruiling > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Xiuli Pan > Sent: Tuesday, March 22, 2016 12:38 PM > To: beignet@lists.freedesktop.org > Cc: Pan, Xiuli > Subject: [Beignet] [PATCH] Libocl:

Re: [Beignet] patch to get beignet to compile on gcc 3.5.0

2016-03-28 Thread Sean Lynch
Sorry, I meant 5.3.0, and I'm probably mistaken about the compiler version being the cause. I was assuming it was the cause because the beignet AUR package used to compile just fine, and suddenly people started to complain about "isnan not declared in this scope" errors. See the comments on

Re: [Beignet] patch to get beignet to compile on gcc 3.5.0

2016-03-28 Thread Pan, Xiuli
Hi Sean, I was quite confused with the gcc 3.5.0, I searched on gcc.gnu.org and found there is no version named 3.5.0. If you mean the newest version 5.3.0, I have built one release version and try to build beignet and there is no error. Could you post the change log or anything related to the

Re: [Beignet] [PATCH] Add condition checking of residuals because it may be NULL.

2016-03-28 Thread Weng, Chuanbo
LGTM, thanks. -Original Message- From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of yan.w...@linux.intel.com Sent: Monday, March 28, 2016 3:35 PM To: beignet@lists.freedesktop.org Cc: Yan Wang Subject: [Beignet] [PATCH] Add condition

[Beignet] [PATCH] Add condition checking of residuals because it may be NULL.

2016-03-28 Thread yan . wang
From: Yan Wang --- src/kernels/cl_internal_block_motion_estimate_intel.cl | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/kernels/cl_internal_block_motion_estimate_intel.cl b/src/kernels/cl_internal_block_motion_estimate_intel.cl index