Re: [Beignet] [PATCH 0/5] Add support for kernel debugging

2016-07-13 Thread Mircea Gherzan
On 13-Jul-16 10:47 AM, He Junyan wrote: Hi Mircea, Thanks a lot for you contribution. I have several questions here. According to my understanding, your debug feature strongly depends on the libigfxdbgxchg64.so lib, which I think is a binary and I can not find it in your patchset. I notice you ge

Re: [Beignet] [PATCH] intel: Export pooled EU and min no. of eus in a pool.

2016-07-13 Thread Chris Wilson
On Wed, Jul 13, 2016 at 11:44:09AM +0100, Arun Siluvery wrote: > On 06/07/2016 05:51, Yang Rong wrote: > >Update kernel interface with new I915_GETPARAM ioctl entries for > >pooled EU and min no. of eus in a pool. Add a wrapping function > >for each parameter. Userspace drivers need these values wh

Re: [Beignet] [PATCH] intel: Export pooled EU and min no. of eus in a pool.

2016-07-13 Thread Arun Siluvery
On 06/07/2016 05:51, Yang Rong wrote: Update kernel interface with new I915_GETPARAM ioctl entries for pooled EU and min no. of eus in a pool. Add a wrapping function for each parameter. Userspace drivers need these values when decide the thread count. This kernel enabled pooled eu by default for

Re: [Beignet] [PATCH 0/5] Add support for kernel debugging

2016-07-13 Thread He Junyan
Hi Mircea, Thanks a lot for you contribution. I have several questions here. According to my understanding, your debug feature strongly depends on the libigfxdbgxchg64.so lib, which I think is a binary and I can not find it in your patchset. I notice you get a SIP of some system routine and allocat

Re: [Beignet] [PATCH] Report build failures in backend to the build log

2016-07-13 Thread Yang, Rong R
Sorry I missed this patch. GBE has two type assert, one is internal debug assert, another one is caused by user's kernel. I think the second assert is unreasonable and need to report the failures instead of assert. Your patch is one of unreasonable assert, this patch is LGTM. And maybe we coul

[Beignet] [PATCH] CMAKE: Make utests and benchmark not build for default

2016-07-13 Thread Xiuli Pan
From: Pan Xiuli Now make will only make beignet library, if you want beignet utest or benchmark you can use make utest and make benchmark to build them. This will make build time for beignet shorter when utests are not needed. Signed-off-by: Pan Xiuli --- CMakeLists.txt | 4 ++-- ben