Re: [Beignet] [PATCH RFC] Add AppStream metadata

2017-02-28 Thread Rebecca N. Palmer
On 28/02/17 08:40, Yang, Rong R wrote: metadata_license is just the license for this XML, right? Yes. If so, MIT is ok for me, what your opinion? I have no problem with id section. Fine by me. open(os.path.join(source_directory,"src/cl_device_data.h"),"r",encoding= 'utf-8') has an error in

Re: [Beignet] [PATCH RFC] Add AppStream metadata

2017-02-28 Thread Yang, Rong R
metadata_license is just the license for this XML, right? If so, MIT is ok for me, what your opinion? I have no problem with id section. open(os.path.join(source_directory,"src/cl_device_data.h"),"r",encoding= 'utf-8') has an error in python2.x: TypeError: 'encoding' is an invalid keyword argume