Re: [Beignet] [PATCH 3/5] Remove intel_gpgpu_check_binded_buf_address()

2014-10-31 Thread Zhenyu Wang
On 2014.10.27 17:53:51 +0800, Zhenyu Wang wrote: On 2014.10.27 12:57:59 +0800, Zhenyu Wang wrote: On 2014.10.24 18:10:36 +0800, Zhigang Gong wrote: This assertion is just to make sure we will not get a NULL pointer for a normal buffer. The OpenCL spec doesn't give a very specific

Re: [Beignet] [PATCH 3/5] Remove intel_gpgpu_check_binded_buf_address()

2014-10-31 Thread Zhigang Gong
On Fri, Oct 31, 2014 at 02:19:54PM +0800, Zhenyu Wang wrote: On 2014.10.27 17:53:51 +0800, Zhenyu Wang wrote: On 2014.10.27 12:57:59 +0800, Zhenyu Wang wrote: On 2014.10.24 18:10:36 +0800, Zhigang Gong wrote: This assertion is just to make sure we will not get a NULL pointer for a

Re: [Beignet] [PATCH 3/5] Remove intel_gpgpu_check_binded_buf_address()

2014-10-27 Thread Zhenyu Wang
On 2014.10.27 12:57:59 +0800, Zhenyu Wang wrote: On 2014.10.24 18:10:36 +0800, Zhigang Gong wrote: This assertion is just to make sure we will not get a NULL pointer for a normal buffer. The OpenCL spec doesn't give a very specific statement about a NULL buffer object. But it does allow to

Re: [Beignet] [PATCH 3/5] Remove intel_gpgpu_check_binded_buf_address()

2014-10-26 Thread Zhenyu Wang
On 2014.10.24 18:10:36 +0800, Zhigang Gong wrote: This assertion is just to make sure we will not get a NULL pointer for a normal buffer. The OpenCL spec doesn't give a very specific statement about a NULL buffer object. But it does allow to pass a NULL to a buffer object. Thus some one may

Re: [Beignet] [PATCH 3/5] Remove intel_gpgpu_check_binded_buf_address()

2014-10-24 Thread Zhigang Gong
This assertion is just to make sure we will not get a NULL pointer for a normal buffer. The OpenCL spec doesn't give a very specific statement about a NULL buffer object. But it does allow to pass a NULL to a buffer object. Thus some one may implement the following kernel: __kernel foo( global