Re: [Beignet] [PATCH 2/2] Refine the method to find pch and pcm files.

2014-01-13 Thread Sun, Yi
It seems another regression issue occurred before this one: commit 03e53efebb24387a48ce10c0d21f58dbb7b5c82e Author: Zhigang Gong zhigang.g...@intel.com Date: Wed Jan 8 18:57:31 2014 +0800 CL: prepare to support ICD if the system has ocl-icd.. v2: Only install the intel-beignet.icd

Re: [Beignet] [PATCH 2/2] Refine the method to find pch and pcm files.

2014-01-13 Thread Gong, Zhigang
Could you give more details of the bug? How to reproduce it? -Original Message- From: Sun, Yi Sent: Monday, January 13, 2014 5:34 PM To: Sun, Yi; Gong, Zhigang; beignet@lists.freedesktop.org Cc: junyan...@linux.intel.com; simon.rich...@hogyros.de; Gong, Zhigang Subject: RE: [Beignet]

[Beignet] [PATCH] CL: add missed intel-beignet.icd.in file

2014-01-13 Thread Igor Gnatenko
From 25014f569135dbd02de6465e5e96f07648133693 Mon Sep 17 00:00:00 2001 From: Igor Gnatenko i.gnatenko.br...@gmail.com Date: Mon, 13 Jan 2014 20:31:45 +0400 Subject: [PATCH] CL: add missed intel-beignet.icd.in file Since 03e53efebb24387a48ce10c0d21f58dbb7b5c82e cmake can't configure files, because

Re: [Beignet] [PATCH 2/2] Refine the method to find pch and pcm files.

2014-01-13 Thread Igor Gnatenko
On Mon, 2014-01-13 at 16:38 +0800, Zhigang Gong wrote: oops, you are right. Thanks for reporting this. The new version patch is attached. Can you revert previous patch in master-branch and commit new patch? On Mon, Jan 13, 2014 at 09:07:15AM +, Sun, Yi wrote: Hi Zhigang, It seems

Re: [Beignet] [PATCH] CL: add missed intel-beignet.icd.in file

2014-01-13 Thread Zhigang Gong
Thanks for the patch. I just found that I pushed those patches by accident. As those patchset is still under review now. I will revert all of them. The missing file you added here is in my local repo which I forgot to add it in the patch when I submitted it. I will send out a version 2 of the

Re: [Beignet] [PATCH 2/2] Refine the method to find pch and pcm files.

2014-01-13 Thread Zhigang Gong
The same problem as previous. I will fix that. Thanks. On Mon, Jan 13, 2014 at 09:41:13AM +, Gong, Zhigang wrote: Could you give more details of the bug? How to reproduce it? -Original Message- From: Sun, Yi Sent: Monday, January 13, 2014 5:34 PM To: Sun, Yi; Gong, Zhigang;

[Beignet] [Patch v2 3/4] GBE: enable relocatable pch files.

2014-01-13 Thread Zhigang Gong
As by default, when include a pch file, clang need to make sure the original header file is untouched. This is impossible when we want to distribute a pch file to a new system. We need to use the relocatable pch feature provided by clang here. We now create two pch files. One is relocatable pch

[Beignet] [Patch v2 4/4] Refine the method to find pch and pcm files.

2014-01-13 Thread Zhigang Gong
When compile user kernels, we need to find the precompiled header file and the precompiled module file. The previous implementation will find the build directory then find the system directory. This is not elegant when it is packaged to a distro. It doesn't need to search the build directory. So

[Beignet] [Patch v2 1/4] CL: back port ICD support to 1.1 branch.

2014-01-13 Thread Zhigang Gong
Signed-off-by: Zhigang Gong zhigang.g...@intel.com --- src/cl_khr_icd.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/cl_khr_icd.c b/src/cl_khr_icd.c index d601134..cb5f5cd 100644 --- a/src/cl_khr_icd.c +++ b/src/cl_khr_icd.c @@ -14,7 +14,14 @@ * You should

[Beignet] [Patch v2 2/4] CL: prepare to support ICD if the system has ocl-icd..

2014-01-13 Thread Zhigang Gong
v2: Only install the intel-beignet.icd if the system has ocl-icd support. Signed-off-by: Zhigang Gong zhigang.g...@intel.com --- CMake/FindGBE.cmake | 37 - CMakeLists.txt| 15 ++- backend/src/CMakeLists.txt| 15

[Beignet] [PATCH] utests: Put all the generated kernel files to .gitignore at runtime.

2014-01-13 Thread Zhigang Gong
As there are so many generated kernel files, it's annoying when I use git status to check the modified files and new added files. This patch to put all of them to the gitignore file which could make things easier. Signed-off-by: Zhigang Gong zhigang.g...@intel.com --- utests/.gitignore |

Re: [Beignet] [Patch v2 2/4] CL: prepare to support ICD if the system has ocl-icd..

2014-01-13 Thread Igor Gnatenko
On Tue, 2014-01-14 at 09:45 +0800, Zhigang Gong wrote: v2: Only install the intel-beignet.icd if the system has ocl-icd support. Signed-off-by: Zhigang Gong zhigang.g...@intel.com Signed-off-by: Igor Gnatenko i.gnatenko.br...@gmail.com --- CMake/FindGBE.cmake | 37