Re: [Beignet] [PATCH v2] cmake: Fix linking with LLVM/Terminfo

2014-02-16 Thread Igor Gnatenko
On Sat, 2014-02-15 at 14:40 +0800, Boqun Feng wrote: About this fix, in some distros, there is only libncurses.so as a single terminfo library. In such a distro, `-ltinfo' may introduce a linkage error. It's better to use the find_library function to decide which one to be used, as follow:

Re: [Beignet] [PATCH] CL: make the scratch size as a device resource attribute.

2014-02-16 Thread Song, Ruiling
Yes, you are right, put it into device attribute is a good idea. The patch lgtm -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Friday, February 14, 2014 4:29 PM To:

[Beignet] [PATCH] GBE: fix terminfo library linkage

2014-02-16 Thread Boqun Feng
In some distros, the terminal libraries are divided into two libraries, one is tinfo and the other is ncurses, however, for other distros, there is only one single ncurses library with all functions. In order to link proper terminal library for LLVM, find_library macro in cmake can be used. In

Re: [Beignet] [PATCH V2] GBE: add param to switch the behavior of math func

2014-02-16 Thread Zhigang Gong
-Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Guo, Yejun Sent: Friday, February 14, 2014 7:09 PM To: Zhigang Gong Cc: beignet@lists.freedesktop.org Subject: Re: [Beignet] [PATCH V2] GBE: add param to switch

[Beignet] [PATCH] utests: Remove test cases for function 'tgamma' 'erf' and 'erfc'

2014-02-16 Thread Yi Sun
Since OpenCL conformance doesn't cover these function at the moment, we remove them temporarily. Signed-off-by: Yi Sun yi@intel.com --- utests/utest_math_gen.py | 28 +++- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git a/utests/utest_math_gen.py

Re: [Beignet] [PATCH] GBE: fix terminfo library linkage

2014-02-16 Thread Igor Gnatenko
On Mon, 2014-02-17 at 10:12 +0800, Zhigang Gong wrote: This patch LGTM. CC to Igor, could you help to test this patch in your environment? Sure! I've tested. It works. Thanks. On Mon, Feb 17, 2014 at 09:49:26AM +0800, Boqun Feng wrote: In some distros, the terminal libraries are

[Beignet] [PATCH] utests: Add a case generator for relational builtin functions.

2014-02-16 Thread Yi Sun
utests/utest_relational_gen.py can generate test cases automatically for 13 out of 18 relational builtin functions. Now all these test cases are passed. Signed-off-by: Yi Sun yi@intel.com Signed-off-by: YangweiX Shui yangweix.s...@intel.com --- utests/CMakeLists.txt | 17 ++-