[Beignet] Weird clinfo ouput @ FreeBSD-11.0/Intel GPU

2016-10-10 Thread Igor Pavlov
Dear Beignet community, Could someone kindly clarify, what do all of this mean? # uname -opr FreeBSD 11.0-RELEASE-p1 amd64 # sysctl hw.model hw.model: Intel(R) Xeon(R) CPU E3-1265L v3 @ 2.50GHz # pkg info | grep beignet beignet-1.2.0 OpenCL library for Intel GPUs # clinfo -v

Re: [Beignet] [PATCH] Add clGetKernelSubGroupInfoKHR to _cl_icd_dispatch table

2016-10-10 Thread Pan, Xiuli
Hi, The api clGetKernelSubGroupInfoKHR for OpenCL 1.2 is added for the extension cl_intel_subgroups. https://www.khronos.org/registry/cl/extensions/intel/cl_intel_subgroups.txt And I add it in https://cgit.freedesktop.org/beignet/commit/?id=aa3ee67c825fbef5f68b31345c060c981bf35ad3 Now I see

Re: [Beignet] [PATCH] Add clGetKernelSubGroupInfoKHR to _cl_icd_dispatch table

2016-10-10 Thread Rebecca N. Palmer
This patch causes a warning: /home/yr /beignet/src/cl_khr_icd.c:187:3: warning: initialization from incompatible pointer type clGetKernelSubGroupInfoKHR, /home/yr/maintain/beignet/src/cl_khr_icd.c:187:3: warning: (near initialization for ‘cl_khr_icd_dispatch.clUnknown136’) I see that as

Re: [Beignet] [PATCH] Add clGetKernelSubGroupInfoKHR to _cl_icd_dispatch table

2016-10-10 Thread Yang, Rong R
This patch causes a warning: /home/yr /beignet/src/cl_khr_icd.c:187:3: warning: initialization from incompatible pointer type clGetKernelSubGroupInfoKHR, /home/yr/maintain/beignet/src/cl_khr_icd.c:187:3: warning: (near initialization for ‘cl_khr_icd_dispatch.clUnknown136’) I checked the

Re: [Beignet] [PATCH] Utests: respect existing C/CXXFLAGS

2016-10-10 Thread Yang, Rong R
LGTM, pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Rebecca N. Palmer > Sent: Saturday, October 8, 2016 21:28 > To: beignet@lists.freedesktop.org > Subject: [Beignet] [PATCH] Utests: respect existing C/CXXFLAGS > > This

Re: [Beignet] [PATCH] Utests: Don't end an all-tests run when one test fails

2016-10-10 Thread Yang, Rong R
LGTM, pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Rebecca N. Palmer > Sent: Saturday, October 8, 2016 21:27 > To: beignet@lists.freedesktop.org > Subject: [Beignet] [PATCH] Utests: Don't end an all-tests run when one

Re: [Beignet] [PATCH] Docs: Spelling and grammar fixes

2016-10-10 Thread Yang, Rong R
LGTM, thanks for your carefulness, pushed. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Rebecca N. Palmer > Sent: Saturday, October 8, 2016 21:11 > To: beignet@lists.freedesktop.org > Subject: [Beignet] [PATCH] Docs: Spelling and

Re: [Beignet] [PATCH] Utests: use clGetExtensionFunctionAddressForPlatform

2016-10-10 Thread Yang, Rong R
Because clGetExtensionFunctionAddressForPlatform is available from OpenCL 1.2, I think it is better to add the opencl version check, just as clCreateImageFromLibvaIntel in the utest runtime_climage_from_boname.cpp. Anyway, it is a refinement so I have merged it. > -Original Message- >

Re: [Beignet] [PATCH] Delete useless event list in command queue struct.

2016-10-10 Thread Yang, Rong R
LGTM, pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > junyan...@inbox.com > Sent: Friday, September 30, 2016 15:20 > To: beignet@lists.freedesktop.org > Subject: [Beignet] [PATCH] Delete useless event list in command queue

Re: [Beignet] [PATCH] Delete useless event list in command queue struct.

2016-10-10 Thread Yang, Rong R
ccc > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > junyan...@inbox.com > Sent: Friday, September 30, 2016 15:20 > To: beignet@lists.freedesktop.org > Subject: [Beignet] [PATCH] Delete useless event list in command queue > struct. > >

Re: [Beignet] [PATCH] Docs: Spelling and grammar fixes

2016-10-10 Thread Yang, Rong R
LGTM, pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Rebecca N. Palmer > Sent: Saturday, October 8, 2016 21:11 > To: beignet@lists.freedesktop.org > Subject: [Beignet] [PATCH] Docs: Spelling and grammar fixes > >

Re: [Beignet] [PATCH] add bxt with pciid 0x1A84

2016-10-10 Thread Yang, Rong R
LGTM, pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Guo Yejun > Sent: Thursday, September 29, 2016 9:58 > To: beignet@lists.freedesktop.org > Cc: Guo, Yejun > Subject: [Beignet] [PATCH] add bxt with

Re: [Beignet] [PATCH] Fix a bug for double free of enqueueNativeKernel.

2016-10-10 Thread Yang, Rong R
LGTM, pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > junyan...@inbox.com > Sent: Thursday, September 29, 2016 18:05 > To: beignet@lists.freedesktop.org > Subject: [Beignet] [PATCH] Fix a bug for double free of >

Re: [Beignet] [PATCH V2] Fix a bug for event error status.

2016-10-10 Thread Yang, Rong R
LGTM, pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > junyan...@inbox.com > Sent: Thursday, September 29, 2016 18:05 > To: beignet@lists.freedesktop.org > Subject: [Beignet] [PATCH V2] Fix a bug for event error status. >

Re: [Beignet] [PATCH] correct the kernel name

2016-10-10 Thread Yang, Rong R
LGTM, pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Guo Yejun > Sent: Thursday, September 29, 2016 10:14 > To: beignet@lists.freedesktop.org > Cc: Guo, Yejun > Subject: [Beignet] [PATCH] correct the

Re: [Beignet] [PATCH] Delete useless cl_thread files.

2016-10-10 Thread Yang, Rong R
LGTM, pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > junyan...@inbox.com > Sent: Wednesday, September 28, 2016 16:38 > To: beignet@lists.freedesktop.org > Subject: [Beignet] [PATCH] Delete useless cl_thread files. > >

Re: [Beignet] [PATCH] buildsys: Use CMRT_LIBDIR instead of CMRT_LIBRARY_DIRS

2016-10-10 Thread Yang, Rong R
Pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Guo, Yejun > Sent: Monday, October 10, 2016 8:42 > To: Armin K. ; beignet@lists.freedesktop.org > Subject: Re: [Beignet] [PATCH] buildsys: Use CMRT_LIBDIR

Re: [Beignet] [PATCH v2] Fix build with latest libdrm

2016-10-10 Thread Yang, Rong R
Hi, Igor, Armin, Your patches both LGTM, because Igor's patch don't has commit log, so I mix Armin's commit log and Igor's changes. Thanks for your contribution. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Armin K. > Sent:

[Beignet] OpenCL compilation bug/assert

2016-10-10 Thread Hugh Perkins
Following code: struct Eigen__TensorEvaluator_0 { global float* f0; }; struct Eigen__internal__scalar_constant_op { float f0; }; struct Eigen__TensorEvaluator_1 { struct Eigen__internal__scalar_constant_op f0; }; struct Eigen__TensorEvaluator { struct Eigen__TensorEvaluator_0

[Beignet] [PATCH] Add multi devices support in context.

2016-10-10 Thread junyan . he
From: Junyan He In future there may be more than one device on the platform, we need to consider multi devices within one context. Signed-off-by: Junyan He --- src/cl_api.c| 15 --- src/cl_api_command_queue.c | 2 +-

[Beignet] [PATCH 3/4] Modify clGetImageInfo using cl_get_info_helper.

2016-10-10 Thread junyan . he
From: Junyan He Signed-off-by: Junyan He --- src/cl_api.c | 14 src/cl_api_mem.c | 84 + src/cl_mem.c | 101 --- src/cl_mem.h | 18

[Beignet] [PATCH 4/4] Refine clCreateContext and clCreateContextFromType function.

2016-10-10 Thread junyan . he
From: Junyan He 1. Make the code logic more clear, fix some error check problems. 2. Add devices list check, we may have more than 1 device later. Signed-off-by: Junyan He --- src/cl_api.c | 106 ++-

[Beignet] [PATCH 2/4] Modify clGetMemObjectInfo using cl_get_info_helper.

2016-10-10 Thread junyan . he
From: Junyan He Signed-off-by: Junyan He --- src/cl_api.c | 19 - src/cl_api_mem.c | 83 src/cl_mem.c | 72 +--- src/cl_mem.h |

[Beignet] [PATCH 1/4] Refine retain/release context api.

2016-10-10 Thread junyan . he
From: Junyan He Signed-off-by: Junyan He --- src/cl_api.c | 20 src/cl_api_context.c | 22 ++ 2 files changed, 22 insertions(+), 20 deletions(-) diff --git a/src/cl_api.c b/src/cl_api.c index

Re: [Beignet] [PATCH] Utests: Allow testing cl_intel_accelerator via ICD

2016-10-10 Thread Rebecca N. Palmer
> [ Chuanbo ] This utest test intel extension cl_intel_accelerator and > cl_intel_motion_estimation, so it's not beignet specific, > but it's intel specific. You can add code such as: > if (!cl_check_accelerator() && !cl_check_motion_estimation()) > The implementation of

Re: [Beignet] [PATCH v2] Fix build with latest libdrm

2016-10-10 Thread Armin K.
Hm, I didn't see it. I'm fine with whatever one gets merged, as long as it's fixed. On 10.10.2016 8:05, Igor Gnatenko wrote: I think I had more clear patch in bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98090 On Sun, Oct 9, 2016 at 6:54 PM Armin K

Re: [Beignet] [PATCH] Utests: Allow testing cl_intel_accelerator via ICD

2016-10-10 Thread Weng, Chuanbo
Hi Rebecca, Please see my comments below. -Original Message- From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Rebecca N. Palmer Sent: Saturday, October 8, 2016 9:27 PM To: beignet@lists.freedesktop.org Subject: [Beignet] [PATCH] Utests: Allow testing

Re: [Beignet] [PATCH v2] Fix build with latest libdrm

2016-10-10 Thread Igor Gnatenko
I think I had more clear patch in bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98090 On Sun, Oct 9, 2016 at 6:54 PM Armin K wrote: > libdrm-2.4.71 contains drm_intel_get_pooled_eu and > drm_intel_get_min_eu_in_pool with different > signatures. > > v2: > > - Fix