Re: [Beignet] [PATCH 4/6] Add the API of clCreateProgramFromBinaryIntel to deserializate the program.

2013-08-23 Thread Yang, Rong R
Hi, From OpenCL spec, the binary of clCreateProgramWithBinary consist of either or both: 1. Device-specific executable(s), and/or, 2. Implementation-specific intermediate representation (IR) which will be converted to the device-specific executable. So I think can use this API directly,

Re: [Beignet] [PATCH V2 1/2] Add clEnqueueMapBuffer and clEnqueueMapImage non-blocking map support.

2013-08-28 Thread Yang, Rong R
This is a typo about event type, and no relative with enqueue's data type. I will send a new patch to fix them. -Original Message- From: He Junyan [mailto:junyan...@inbox.com] Sent: Thursday, August 29, 2013 11:20 AM To: Yang, Rong R Cc: beignet@lists.freedesktop.org Subject: Re

Re: [Beignet] [V2 PATCH 2/4] Add one tool program to build and serial the program.

2013-09-10 Thread Yang, Rong R
Test pass. There are two unused variable warning: ker_num and inst. -Original Message- From: beignet-bounces+rong.r.yang=intel@lists.freedesktop.org [mailto:beignet-bounces+rong.r.yang=intel@lists.freedesktop.org] On Behalf Of junyan...@inbox.com Sent: Thursday, September 05,

Re: [Beignet] [V2 PATCH 4/4] Add a test case for binary load

2013-09-10 Thread Yang, Rong R
If I run the test not in the dir build/utest, for example in build dir and run ./utest/utest_run, it fail. -Original Message- From: beignet-bounces+rong.r.yang=intel@lists.freedesktop.org [mailto:beignet-bounces+rong.r.yang=intel@lists.freedesktop.org] On Behalf Of

Re: [Beignet] [PATCH] support converting 64-bit integer to shorter integer

2013-09-11 Thread Yang, Rong R
LGTM, test ok, thanks. -Original Message- From: beignet-bounces+rong.r.yang=intel@lists.freedesktop.org [mailto:beignet-bounces+rong.r.yang=intel@lists.freedesktop.org] On Behalf Of Homer Hsing Sent: Monday, September 02, 2013 9:25 AM To: beignet@lists.freedesktop.org Subject:

Re: [Beignet] [PATCH] support converting 64-bit integer to 32-bit float

2013-09-11 Thread Yang, Rong R
Hi, If I change the line: src[i] = (int64_t)0x2000 * i; to: src[i] = (int64_t)(-i); in the test case, it will fail. I think the algorithm you change the long to float don't cover all case. For example change singed long -1L to float. -Original Message- From:

Re: [Beignet] [V3 PATCH 3/4] Implement the clCreateProgramWithBinary to deseralize the binary.

2013-09-12 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: beignet-bounces+rong.r.yang=intel@lists.freedesktop.org [mailto:beignet-bounces+rong.r.yang=intel@lists.freedesktop.org] On Behalf Of junyan...@inbox.com Sent: Wednesday, September 11, 2013 6:08 PM To: beignet@lists.freedesktop.org Cc:

Re: [Beignet] [PATCH v2] support converting 64-bit integer to 32-bit float

2013-09-12 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: beignet-bounces+rong.r.yang=intel@lists.freedesktop.org [mailto:beignet-bounces+rong.r.yang=intel@lists.freedesktop.org] On Behalf Of Homer Hsing Sent: Friday, September 13, 2013 9:41 AM To: beignet@lists.freedesktop.org Subject: [Beignet]

Re: [Beignet] [PATCH v2] add built-in function atan2pi

2013-09-12 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: beignet-bounces+rong.r.yang=intel@lists.freedesktop.org [mailto:beignet-bounces+rong.r.yang=intel@lists.freedesktop.org] On Behalf Of Homer Hsing Sent: Friday, September 13, 2013 10:23 AM To: beignet@lists.freedesktop.org Subject: [Beignet]

Re: [Beignet] [PATCH 1/2] Runtime: fix a null reference bug.

2013-09-18 Thread Yang, Rong R
LGTM, test pass, thanks. -Original Message- From: beignet-bounces+rong.r.yang=intel@lists.freedesktop.org [mailto:beignet-bounces+rong.r.yang=intel@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Tuesday, September 17, 2013 5:56 PM To: beignet@lists.freedesktop.org

Re: [Beignet] [PATCH 2/2] Runtime: Implement CL_MEM_USE_HOST_PTR flag for image.

2013-09-18 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: beignet-bounces+rong.r.yang=intel@lists.freedesktop.org [mailto:beignet-bounces+rong.r.yang=intel@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Friday, September 13, 2013 4:55 PM To: beignet@lists.freedesktop.org Cc: Zhigang Gong

Re: [Beignet] [PATCH version 2] 64-bit-int: allocate flag register by RA

2013-09-22 Thread Yang, Rong R
LGTM, test pass. -Original Message- From: beignet-bounces+rong.r.yang=intel@lists.freedesktop.org [mailto:beignet-bounces+rong.r.yang=intel@lists.freedesktop.org] On Behalf Of Homer Hsing Sent: Sunday, September 22, 2013 1:58 PM To: beignet@lists.freedesktop.org Subject:

Re: [Beignet] [PATCH 1/5] clCopyImage: fix up all the surface type to int type.

2013-09-26 Thread Yang, Rong R
Test pass, the patchset looks good to me, thanks. -Original Message- From: beignet-bounces+rong.r.yang=intel@lists.freedesktop.org [mailto:beignet-bounces+rong.r.yang=intel@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Wednesday, September 25, 2013 7:13 PM To:

Re: [Beignet] [PATCH 2/4] Add the internal used kernels for buffer copy.

2013-10-09 Thread Yang, Rong R
There are compiler errors in my env such as: /bin/sh: 1: ../../src/../backend/src/gbe_bin_generater: not found -Original Message- From: beignet-bounces+rong.r.yang=intel@lists.freedesktop.org [mailto:beignet-bounces+rong.r.yang=intel@lists.freedesktop.org] On Behalf Of

Re: [Beignet] [PATCH 3/4] Implement the clEnqueueCopyBuffer API using internal binary kernel

2013-10-09 Thread Yang, Rong R
In function cl_mem_copy, the local size is only 1, maybe set it to large or equal to 16 can improve performance. -Original Message- From: beignet-bounces+rong.r.yang=intel@lists.freedesktop.org [mailto:beignet-bounces+rong.r.yang=intel@lists.freedesktop.org] On Behalf Of

Re: [Beignet] [PATCH] GBE: sampler_t should always be a const int.

2013-10-09 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: beignet-bounces+rong.r.yang=intel@lists.freedesktop.org [mailto:beignet-bounces+rong.r.yang=intel@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Wednesday, October 09, 2013 2:37 PM To: beignet@lists.freedesktop.org Cc: Zhigang Gong

Re: [Beignet] [PATCH] saturated conversion of native GPU data type, larger to narrower

2013-10-09 Thread Yang, Rong R
LGTM, test pass, but there are warnings: /home/champson/source/beignet/utests/builtin_convert_sat.cpp:51:1: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] -Original Message- From: beignet-bounces+rong.r.yang=intel@lists.freedesktop.org

Re: [Beignet] [PATCH 1/3] Implement api clCreateKernelsInProgram.

2013-10-09 Thread Yang, Rong R
Yes, I have send the version2. -Original Message- From: Zhigang Gong [mailto:zhigang.g...@linux.intel.com] Sent: Wednesday, October 09, 2013 5:34 PM To: Yang, Rong R Cc: beignet@lists.freedesktop.org Subject: Re: [Beignet] [PATCH 1/3] Implement api clCreateKernelsInProgram. On Wed, Oct

Re: [Beignet] [PATCH v2] saturated conversion of native GPU data type, larger to narrower

2013-10-09 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: beignet-bounces+rong.r.yang=intel@lists.freedesktop.org [mailto:beignet-bounces+rong.r.yang=intel@lists.freedesktop.org] On Behalf Of Homer Hsing Sent: Thursday, October 10, 2013 10:14 AM To: beignet@lists.freedesktop.org Subject: [Beignet]

Re: [Beignet] [PATCH 1/2] GBE: Support local variable inside kernel function.

2013-10-13 Thread Yang, Rong R
This patchset LGTM, thanks. -Original Message- From: beignet-bounces+rong.r.yang=intel@lists.freedesktop.org [mailto:beignet-bounces+rong.r.yang=intel@lists.freedesktop.org] On Behalf Of Ruiling Song Sent: Thursday, October 10, 2013 3:14 PM To: beignet@lists.freedesktop.org Cc:

Re: [Beignet] [PATCH] Delete the redundant intel_batchbuffer_t init in intel_gpgpu_new

2013-10-13 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: beignet-bounces+rong.r.yang=intel@lists.freedesktop.org [mailto:beignet-bounces+rong.r.yang=intel@lists.freedesktop.org] On Behalf Of junyan...@inbox.com Sent: Friday, October 11, 2013 10:44 AM To: beignet@lists.freedesktop.org Cc: Junyan

Re: [Beignet] [PATCH] support saturated converting from narrower type to wider type

2013-10-17 Thread Yang, Rong R
According openCL spec: Conversions to floating-point type shall conform to IEEE-754 rounding rules. The _sat modifier may not be used for conversions to floating-point formats. So we need not support convert_float_sat. -Original Message- From:

Re: [Beignet] [PATCH 1/3] GBE: Inline all function calls.

2013-10-17 Thread Yang, Rong R
This patchset LTM, thanks. -Original Message- From: beignet-bounces+rong.r.yang=intel@lists.freedesktop.org [mailto:beignet-bounces+rong.r.yang=intel@lists.freedesktop.org] On Behalf Of Ruiling Song Sent: Wednesday, October 16, 2013 3:38 PM To: beignet@lists.freedesktop.org Cc:

Re: [Beignet] [PATCH] Runtime: correct some image related maximum values for IVB.

2013-10-18 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: beignet-bounces+rong.r.yang=intel@lists.freedesktop.org [mailto:beignet-bounces+rong.r.yang=intel@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Friday, October 18, 2013 1:32 PM To: beignet@lists.freedesktop.org Cc: Zhigang Gong

Re: [Beignet] [PATCH] GBE: Handle all-zero constant.

2013-10-20 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: beignet-bounces+rong.r.yang=intel@lists.freedesktop.org [mailto:beignet-bounces+rong.r.yang=intel@lists.freedesktop.org] On Behalf Of Ruiling Song Sent: Friday, October 18, 2013 3:11 PM To: beignet@lists.freedesktop.org Cc: Song, Ruiling

Re: [Beignet] [PATCH] Add type long/ulong/double's async copy.

2013-10-21 Thread Yang, Rong R
Just send out a new patch to enable these types in async copy test case. -Original Message- From: Zhigang Gong [mailto:zhigang.g...@linux.intel.com] Sent: Thursday, October 17, 2013 5:21 PM To: Yang, Rong R Cc: beignet@lists.freedesktop.org Subject: Re: [Beignet] [PATCH] Add type long

Re: [Beignet] [PATCH] use int64_t to express long in a test case

2013-10-21 Thread Yang, Rong R
Test pass. LGTM, thanks. -Original Message- From: beignet-bounces+rong.r.yang=intel@lists.freedesktop.org [mailto:beignet-bounces+rong.r.yang=intel@lists.freedesktop.org] On Behalf Of Homer Hsing Sent: Monday, October 21, 2013 3:26 PM To: beignet@lists.freedesktop.org Subject:

Re: [Beignet] [PATCH] runtime: Simply return success in clUnloadCompiler.

2013-10-21 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: beignet-bounces+rong.r.yang=intel@lists.freedesktop.org [mailto:beignet-bounces+rong.r.yang=intel@lists.freedesktop.org] On Behalf Of Ruiling Song Sent: Monday, October 21, 2013 3:48 PM To: beignet@lists.freedesktop.org Cc: Song, Ruiling

Re: [Beignet] [PATCH] GBE: enable bitselect vector builtin functions.

2013-10-29 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Tuesday, October 29, 2013 1:34 PM To: beignet@lists.freedesktop.org Cc: Zhigang Gong Subject: [Beignet] [PATCH] GBE: enable

Re: [Beignet] [PATCH] GBE: fixed one bug for vector relational builtin functions.

2013-10-29 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Tuesday, October 29, 2013 3:07 PM To: beignet@lists.freedesktop.org Cc: Zhigang Gong Subject: [Beignet] [PATCH] GBE: fixed one bug

Re: [Beignet] [PATCH] GBE: fixed one bug for vector relational builtin functions.

2013-10-29 Thread Yang, Rong R
Sent: Tuesday, October 29, 2013 4:35 PM To: Yang, Rong R; Zhigang Gong; beignet@lists.freedesktop.org Cc: Jin, Gordon Subject: RE: [Beignet] [PATCH] GBE: fixed one bug for vector relational builtin functions. It seems this patch introduced a regression issue: ./piglit-run.py -t float-isnan-1.0

Re: [Beignet] [PATCH] improve multithread calling of llvm

2013-11-06 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Homer Hsing Sent: Tuesday, November 05, 2013 1:28 PM To: beignet@lists.freedesktop.org Subject: [Beignet] [PATCH] improve multithread calling of llvm

Re: [Beignet] [PATCH] release previous program in cl_kernel_init

2013-11-06 Thread Yang, Rong R
LGTM. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Homer Hsing Sent: Tuesday, November 05, 2013 1:08 PM To: beignet@lists.freedesktop.org Subject: [Beignet] [PATCH] release previous program in cl_kernel_init

Re: [Beignet] [PATCH] fix builtin function ilogb

2013-11-06 Thread Yang, Rong R
Hi: Why not using __gen_ocl_rndd(native_log2(x)) for common case? -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Homer Hsing Sent: Tuesday, November 05, 2013 3:48 PM To: beignet@lists.freedesktop.org Subject:

Re: [Beignet] [PATCH] fix builtin function fract

2013-11-06 Thread Yang, Rong R
Hi, In openCL spec: fract ( +inf, iptr ) returns +0 and +inf in iptr. fract ( -inf, iptr ) returns -0 and -inf in iptr. So should distinguish +inf and -inf. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Homer

Re: [Beignet] [PATCH] fix builtin function 'frexp'

2013-11-06 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: beignet-bounces+rong.r.yang=intel@lists.freedesktop.org [mailto:beignet-bounces+rong.r.yang=intel@lists.freedesktop.org] On Behalf Of Homer Hsing Sent: Wednesday, November 06, 2013 9:05 AM To: beignet@lists.freedesktop.org Subject:

Re: [Beignet] [PATCH 2/2] Runtime: fix some max values.

2013-11-06 Thread Yang, Rong R
This patchset looks good to me. BTW: is the max_samlers a problem when enable GEN7_SAMPLER_CLAMP_BORDER_WORKAROUND? -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of zhigang.g...@linux.intel.com Sent: Wednesday,

Re: [Beignet] [PATCH] GBE: fix a 64bit scalar register issue.

2013-11-06 Thread Yang, Rong R
LGTM. BTW: Does the function GenRegister::h2 also have this issue? -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Ruiling Song Sent: Wednesday, November 06, 2013 1:40 PM To: beignet@lists.freedesktop.org Cc:

Re: [Beignet] [PATCH v2] GBE: Add support for kernel attribute reqd_work_group_size.

2013-11-12 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Wednesday, November 13, 2013 10:55 AM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet] [PATCH v2] GBE: Add

Re: [Beignet] [PATCH] fix builtin function fdim

2013-11-12 Thread Yang, Rong R
LGTM. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Homer Hsing Sent: Tuesday, November 12, 2013 1:13 PM To: beignet@lists.freedesktop.org Subject: [Beignet] [PATCH] fix builtin function fdim check whether

Re: [Beignet] [PATCH] fix builtin function ldexp

2013-11-12 Thread Yang, Rong R
LGTM. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Homer Hsing Sent: Tuesday, November 12, 2013 4:38 PM To: beignet@lists.freedesktop.org Subject: [Beignet] [PATCH] fix builtin function ldexp fixed corner

Re: [Beignet] [PATCH] fix ASR operator for 64bit integer

2013-11-14 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Homer Hsing Sent: Monday, November 04, 2013 10:14 AM To: beignet@lists.freedesktop.org Subject: [Beignet] [PATCH] fix ASR operator for 64bit integer

Re: [Beignet] [PATCH] put a mutex around gbe_program_new_from_llvm

2013-11-14 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Homer Hsing Sent: Tuesday, November 05, 2013 1:28 PM To: beignet@lists.freedesktop.org Subject: [Beignet] [PATCH] put a mutex around

Re: [Beignet] [PATCH] fix builtin function isnormal

2013-11-14 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: beignet-bounces+rong.r.yang=intel@lists.freedesktop.org [mailto:beignet-bounces+rong.r.yang=intel@lists.freedesktop.org] On Behalf Of Homer Hsing Sent: Friday, November 08, 2013 1:28 PM To: beignet@lists.freedesktop.org Subject: [Beignet]

Re: [Beignet] [PATCH] improve builtin function rint

2013-11-14 Thread Yang, Rong R
LGTM. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Homer Hsing Sent: Wednesday, November 13, 2013 4:49 PM To: beignet@lists.freedesktop.org Subject: [Beignet] [PATCH] improve builtin function rint directly use

Re: [Beignet] [PATCH] fix builtin function round

2013-11-14 Thread Yang, Rong R
LGTM. -Original Message- From: beignet-bounces+rong.r.yang=intel@lists.freedesktop.org [mailto:beignet-bounces+rong.r.yang=intel@lists.freedesktop.org] On Behalf Of Homer Hsing Sent: Wednesday, November 13, 2013 4:49 PM To: beignet@lists.freedesktop.org Subject: [Beignet]

Re: [Beignet] [PATCH 2/2] Add vload_half and vstore_half build in.

2013-11-26 Thread Yang, Rong R
35 line, also not a good idea. Do you have other good ideas? -Original Message- From: Zhigang Gong [mailto:zhigang.g...@linux.intel.com] Sent: Wednesday, November 27, 2013 12:27 PM To: Yang, Rong R Cc: beignet@lists.freedesktop.org Subject: Re: [Beignet] [PATCH 2/2] Add vload_half

Re: [Beignet] [PATCH 1/4] Runtime: fixed parameter error checking in cl create buffer.

2013-11-26 Thread Yang, Rong R
This patchset LGTM, thanks. -Original Message- From: beignet-bounces+rong.r.yang=intel@lists.freedesktop.org [mailto:beignet-bounces+rong.r.yang=intel@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Monday, November 25, 2013 1:11 PM To: beignet@lists.freedesktop.org Cc:

Re: [Beignet] [PATCH 1/2] Fix a build problem when the llvm version has the fix version digit.

2013-11-27 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Wednesday, November 27, 2013 10:47 AM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet] [PATCH 1/2] Fix a build

Re: [Beignet] [PATCH] GBE: filter the unsupported cl compile arguments out.

2013-11-29 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Thursday, November 28, 2013 10:55 AM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet] [PATCH] GBE: filter the

Re: [Beignet] [PATCH] GBE: fix clang's incorrect optimization for barrier call.

2013-12-17 Thread Yang, Rong R
One comment. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Friday, December 13, 2013 2:47 PM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet] [PATCH] GBE: fix clang's

Re: [Beignet] [PATCH] GBE: adjust instruction order for load/function call for vector.

2013-12-17 Thread Yang, Rong R
It also clear when check llvm IR. LGTM, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Wednesday, December 18, 2013 2:37 PM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject:

Re: [Beignet] [PATCH] [PATCH]GBE: improve precision of cosh

2013-12-22 Thread Yang, Rong R
Test pass with multi-thread disabled. Thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Lv Meng Sent: Friday, December 20, 2013 11:52 AM To: beignet@lists.freedesktop.org Cc: Lv, Meng Subject: [Beignet]

Re: [Beignet] [PATCH] [PATCH]GBE: improve precision of sinh

2013-12-22 Thread Yang, Rong R
Test pass with multi-thread disabled. Thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Lv Meng Sent: Friday, December 20, 2013 9:23 AM To: beignet@lists.freedesktop.org Cc: Lv, Meng Subject: [Beignet]

Re: [Beignet] [PATCH V2] [PATCH]GBE: improve precision of exp

2013-12-22 Thread Yang, Rong R
Test pass with multi-thread disabled. Thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Lv Meng Sent: Wednesday, December 18, 2013 2:29 PM To: beignet@lists.freedesktop.org Cc: Lv, Meng Subject: [Beignet]

Re: [Beignet] [PATCH V3] [PATCH]GBE: improve precision of fmod

2013-12-22 Thread Yang, Rong R
Test pass with multi-thread disabled. Thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Lv Meng Sent: Wednesday, December 18, 2013 3:17 PM To: beignet@lists.freedesktop.org Cc: Lv, Meng Subject: [Beignet]

Re: [Beignet] [PATCH] GBE: we should allocate register for ExtractElement insn.

2013-12-22 Thread Yang, Rong R
This patch is ok to me. But the comment confuse me. It only fix register allocate for ExtractElement insn, but you example is branch + add case. -Original Message- From: beignet-bounces+rong.r.yang=intel@lists.freedesktop.org

Re: [Beignet] [PATCH] [PATCH]GBE: improve precision of acosh

2013-12-23 Thread Yang, Rong R
Test pass with multi-thread disabled. Thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Lv Meng Sent: Wednesday, December 18, 2013 4:14 PM To: beignet@lists.freedesktop.org Cc: Lv, Meng Subject: [Beignet]

Re: [Beignet] [PATCH] GBE: rewrite the liveness analysis routine.

2013-12-23 Thread Yang, Rong R
One question. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Friday, December 20, 2013 3:27 PM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet] [PATCH] GBE: rewrite the

Re: [Beignet] [PATCH 1/2] Fix convert long/ulong to float.

2013-12-25 Thread Yang, Rong R
It is caused by wrong jumpDistance when patchJMPI. I have sent a new patch, thanks. -Original Message- From: Zhigang Gong [mailto:zhigang.g...@linux.intel.com] Sent: Wednesday, December 25, 2013 11:54 AM To: Yang, Rong R Cc: beignet@lists.freedesktop.org Subject: Re: [Beignet] [PATCH 1

Re: [Beignet] [PATCH 1/2] Move the llvm optimize pass from clang to backend.

2013-12-30 Thread Yang, Rong R
There is bugs in FunctionArgumentLowerer::buildConstantPush, and this patch will trigger it. I have sent a new patch to fix. Thanks. -Original Message- From: Zhigang Gong [mailto:zhigang.g...@linux.intel.com] Sent: Tuesday, December 31, 2013 11:20 AM To: Yang, Rong R Cc: beignet

Re: [Beignet] [Patch v2] GBE: use soft mask to handle the barrier call.

2014-01-01 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Tuesday, December 31, 2013 3:56 PM To: Gong, Zhigang Cc: beignet@lists.freedesktop.org Subject: Re: [Beignet] [Patch v2] GBE: use

Re: [Beignet] [QA 2014/01/02 ] Status of Piglit test cases

2014-01-01 Thread Yang, Rong R
Hi, Yi, As discussed with you, you said you will try to submit a patch to Piglit, if Piglit don't accept it, I will fix it. Isn't it? From: Gong, Zhigang Sent: Thursday, January 02, 2014 1:43 PM To: Song, Ruiling; Sun, Yi; 'beignet@lists.freedesktop.org'; Yang, Rong R Cc: Zou, Nanhai; Shui

Re: [Beignet] [QA 2014/01/02 ] Status of Piglit test cases

2014-01-01 Thread Yang, Rong R
OK, I will fix it. From: Sun, Yi Sent: Thursday, January 02, 2014 2:44 PM To: Yang, Rong R; Gong, Zhigang; Song, Ruiling; 'beignet@lists.freedesktop.org' Cc: Zou, Nanhai; Shui, YangweiX; Jin, Gordon Subject: RE: [Beignet] [QA 2014/01/02 ] Status of Piglit test cases When I was patching piglit, I

Re: [Beignet] [Patch v2] GBE: validate active bool value in the branching instruction.

2014-01-03 Thread Yang, Rong R
This patch looks good to me, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Friday, January 03, 2014 3:39 PM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet]

Re: [Beignet] [PATCH] GBE: optimize JMP instruction.

2014-01-06 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Friday, January 03, 2014 5:18 PM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet] [PATCH] GBE: optimize JMP

Re: [Beignet] [PATCH] GBE: optimize the CMP instruction.

2014-01-06 Thread Yang, Rong R
A nice patch, LGTM, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Friday, January 03, 2014 5:20 PM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet] [PATCH] GBE:

Re: [Beignet] [PATCH] Fix the multi-thread crash problem of batch buffer release.

2014-01-06 Thread Yang, Rong R
Test pass, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of junyan...@inbox.com Sent: Monday, January 06, 2014 5:07 PM To: beignet@lists.freedesktop.org Cc: Junyan He Subject: [Beignet] [PATCH] Fix the

Re: [Beignet] [PATCH] GBE: Fix a bug at constant GEP processing.

2014-01-06 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Tuesday, January 07, 2014 10:41 AM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet] [PATCH] GBE: Fix a bug at

Re: [Beignet] [PATCH] GBE: handle the first index of GEP correctly.

2014-01-06 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Tuesday, January 07, 2014 12:18 PM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet] [PATCH] GBE: handle the

Re: [Beignet] opencl-1.2 branch head compile error and warnings

2014-01-09 Thread Yang, Rong R
I have tried the ubutun 13.10's released llvm clang 3.3 package, don't have this error. The llvm-as --version is: LLVM (http://llvm.org/): LLVM version 3.3 Optimized build. Built Aug 29 2013 (08:00:45). Default target: i386-pc-linux-gnu Host CPU: core-avx-i -Original

Re: [Beignet] Beignet compiling

2014-01-12 Thread Yang, Rong R
This error is output from CMake/FindLLVM.cmake, when finding some clang library. Beignet requires libclang, please make sure that you have installed libclang package. -Original Message- From: beignet-bounces+rong.r.yang=intel@lists.freedesktop.org

Re: [Beignet] [PATCH] GBE: fixed a long related bug.

2014-01-12 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Friday, January 10, 2014 5:58 PM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet] [PATCH] GBE: fixed a long

Re: [Beignet] [PATCH] Remove builtin function fma from utest_math_gen.py.

2014-01-12 Thread Yang, Rong R
After remove fma test, some tests that affect by it in my env pass, thanks. -Original Message- From: beignet-bounces+rong.r.yang=intel@lists.freedesktop.org [mailto:beignet-bounces+rong.r.yang=intel@lists.freedesktop.org] On Behalf Of Yi Sun Sent: Thursday, January 09, 2014 3:56

Re: [Beignet] [PATCH] utests: Put all the generated kernel files to .gitignore at runtime.

2014-01-15 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Thursday, January 16, 2014 11:01 AM To: Gong, Zhigang Cc: beignet@lists.freedesktop.org Subject: Re: [Beignet] [PATCH] utests: Put

Re: [Beignet] [PATCH 1/4] GBE: fixed a register liveness bug for getsamplerinfo instrution.

2014-01-16 Thread Yang, Rong R
This patchset test ok, and LGTM, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Thursday, January 16, 2014 2:01 PM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet]

Re: [Beignet] [PATCH 1/2] GBE: fix the hack code of sampler offset handling.

2014-01-16 Thread Yang, Rong R
The patchset LGTM. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Friday, January 17, 2014 1:12 PM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet] [PATCH 1/2] GBE: fix

Re: [Beignet] [PATCH] GBE: fixed a bug in sample instruction.

2014-01-20 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Tuesday, January 21, 2014 1:19 PM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet] [PATCH] GBE: fixed a bug in

Re: [Beignet] [PATCH] GBE: increase the disassembly output's readability.

2014-01-22 Thread Yang, Rong R
This patchset LGTM, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Wednesday, January 22, 2014 10:42 AM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet] [PATCH]

Re: [Beignet] [PATCH] Fix the bug in removeLOADIs function.

2014-01-22 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of junyan...@inbox.com Sent: Wednesday, January 22, 2014 2:03 PM To: beignet@lists.freedesktop.org Cc: Junyan He Subject: [Beignet] [PATCH] Fix the bug in

Re: [Beignet] [PATCH] GBE: don't allocate grf for those bools which map to flag.

2014-01-26 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Wednesday, January 22, 2014 10:42 AM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet] [PATCH] GBE: don't

Re: [Beignet] [PATCH 1/2] Multiple register's hstride in suboffset.

2014-01-26 Thread Yang, Rong R
. The fail is cause by function MOV_DF, the register r's hstride is 1, but I also divide it by 2 by mistake. I have send a now patch. -Original Message- From: Zhigang Gong [mailto:zhigang.g...@linux.intel.com] Sent: Sunday, January 26, 2014 5:03 PM To: Yang, Rong R Cc: beignet

Re: [Beignet] [PATCH] GBE: fixed the out-of-range JMPI.

2014-01-27 Thread Yang, Rong R
One comment. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Monday, January 27, 2014 5:22 PM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet] [PATCH] GBE: fixed the

Re: [Beignet] [PATCH 1/2] Silent compilation warning in sampler functions.

2014-02-11 Thread Yang, Rong R
This patchset LGTM, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Saturday, February 08, 2014 2:12 PM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet] [PATCH 1/2]

Re: [Beignet] [PATCH 2/2] Bump to version 0.8.0.

2014-02-11 Thread Yang, Rong R
This patchset LGTM, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Monday, February 10, 2014 4:29 PM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet] [PATCH 2/2]

Re: [Beignet] [PATCH v2] GBE: fixed a potential bug in 64 bit instruction.

2014-02-23 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Wednesday, February 19, 2014 10:48 AM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet] [PATCH v2] GBE: fixed a

Re: [Beignet] [PATCH] merge some state buffers into one buffer

2014-03-06 Thread Yang, Rong R
2 comments. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Guo Yejun Sent: Friday, March 07, 2014 1:00 AM To: beignet@lists.freedesktop.org Cc: Guo, Yejun Subject: [Beignet] [PATCH] merge some state buffers into

Re: [Beignet] [PATCH 3/3] GBE: Optimize byte/short load/store using untyped read/write

2014-03-06 Thread Yang, Rong R
2 comments below. BTW: This patch is for byte/short's vector load/store. Can we also use untype read/write to optimize scalar char/short load/store? -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Ruiling Song

Re: [Beignet] [PATCH V2 1/3] GBE: make vload3 only read 3 elements.

2014-03-06 Thread Yang, Rong R
The patchset LGTM, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Ruiling Song Sent: Friday, March 07, 2014 1:49 PM To: beignet@lists.freedesktop.org Cc: Song, Ruiling Subject: [Beignet] [PATCH V2 1/3]

Re: [Beignet] [PATCH 5/5] GBE: use S16 vector to represent bool.

2014-03-19 Thread Yang, Rong R
One comment. And One question: why set thread control to GEN_THREAD_SWITCH for CMP instruction? -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Friday, March 14, 2014 9:44 AM To:

Re: [Beignet] [PATCH] GBE: Optimize the forward jump instruction.

2014-03-19 Thread Yang, Rong R
Good catch, LGTM. -Original Message- From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Monday, March 17, 2014 6:03 PM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet] [PATCH] GBE: Optimize the forward jump instruction. As

Re: [Beignet] [PATCH 5/5] GBE: use S16 vector to represent bool.

2014-03-19 Thread Yang, Rong R
-Original Message- From: Zhigang Gong [mailto:zhigang.g...@linux.intel.com] Sent: Wednesday, March 19, 2014 4:08 PM To: Yang, Rong R; Gong, Zhigang; beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: RE: [Beignet] [PATCH 5/5] GBE: use S16 vector to represent bool. -Original

Re: [Beignet] [PATCH 01/18] GBE: Add a new pass to handle barrier function's noduplicate attribute correctly.

2014-04-02 Thread Yang, Rong R
One comment. -Original Message- From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Friday, March 28, 2014 3:11 PM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet] [PATCH 01/18] GBE: Add a new pass to handle barrier

Re: [Beignet] [PATCH 10/18] GBE: Disable SPF and use JMPI + IF/ENDIF to handle each blocks.

2014-04-02 Thread Yang, Rong R
-Original Message- From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Friday, March 28, 2014 3:11 PM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet] [PATCH 10/18] GBE: Disable SPF and use JMPI + IF/ENDIF to handle each

Re: [Beignet] [PATCH 16/18] GBE: Add two helper scalar registers to hold 0 and all 1s.

2014-04-02 Thread Yang, Rong R
One comment. -Original Message- From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Friday, March 28, 2014 3:11 PM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet] [PATCH 16/18] GBE: Add two helper scalar registers to hold 0

Re: [Beignet] [PATCH 02/18] GBE: Remove BBs if it only has a label instruction.

2014-04-02 Thread Yang, Rong R
-Original Message- From: Gong, Zhigang Sent: Wednesday, April 02, 2014 4:52 PM To: Yang, Rong R; beignet@lists.freedesktop.org Subject: RE: [Beignet] [PATCH 02/18] GBE: Remove BBs if it only has a label instruction. -Original Message- From: Yang, Rong R Sent: Wednesday

Re: [Beignet] [PATCH V2] GBE: Optimize the bool register allocation/processing.

2014-04-04 Thread Yang, Rong R
The patch LGTM, thanks. -Original Message- From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Tuesday, April 01, 2014 10:10 AM To: beignet@lists.freedesktop.org Cc: Zhigang Gong Subject: [Beignet] [PATCH V2] GBE: Optimize the bool register

Re: [Beignet] [PATCH] GBE: fixed two 'long' related bugs.

2014-04-10 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Tuesday, April 08, 2014 6:00 PM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet] [PATCH] GBE: fixed two 'long' related bugs. Didn't modify

Re: [Beignet] [PATCH] GBE: fixed the undefined phi value's liveness analysis.

2014-04-10 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Thursday, April 10, 2014 2:37 PM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet] [PATCH] GBE: fixed the undefined phi value's liveness

Re: [Beignet] [PATCH 1/2] GBE: Optimize read_image performance for CL_ADDRESS_CLAMP..

2014-04-10 Thread Yang, Rong R
Two comments. -Original Message- From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Thursday, April 10, 2014 12:41 PM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet] [PATCH 1/2] GBE: Optimize read_image performance for

  1   2   3   4   5   6   7   >