Re: [Beignet] [PATCH] fix a bug when the first operand of intel_sub_group_shuffle is uniform

2015-12-24 Thread Yang, Rong R
LGTM, pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Guo, Yejun > Sent: Wednesday, December 23, 2015 15:10 > To: beignet@lists.freedesktop.org > Subject: Re: [Beignet] [PATCH] fix a bug when the first operand of > intel_su

Re: [Beignet] [PATCH] FindLLVM: check for empty system-libs variable

2015-12-27 Thread Yang, Rong R
Pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Steven Newbury > Sent: Thursday, December 24, 2015 0:26 > To: beignet@lists.freedesktop.org > Subject: [Beignet] [PATCH] FindLLVM: check for empty system-libs variable > > Wh

Re: [Beignet] [PATCH] do not call memcpy for cl_enqueue_read_buffer if userptr is enabled

2016-01-04 Thread Yang, Rong R
LGTM, pushed. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Guo Yejun > Sent: Monday, January 4, 2016 9:45 > To: beignet@lists.freedesktop.org > Cc: Guo, Yejun > Subject: [Beignet] [PATCH] do not call memcpy for cl_enqueue_read_buffer >

Re: [Beignet] [PATCH V2] should convert from llvm address to GEN address space to compare.

2016-01-04 Thread Yang, Rong R
LGTM, pushed. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > rong.r.y...@intel.com > Sent: Wednesday, December 30, 2015 15:32 > To: beignet@lists.freedesktop.org > Cc: Luo, Xionghu > Subject: [Beignet] [PATCH V2] should convert from llvm

Re: [Beignet] [PATCH 2/2] change built-in function name from get_sub_group_id to get_sub_group_local_id

2016-01-07 Thread Yang, Rong R
LGTM, pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Guo, Yejun > Sent: Thursday, January 7, 2016 8:52 > To: beignet@lists.freedesktop.org > Subject: Re: [Beignet] [PATCH 2/2] change built-in function name from > get_sub_g

Re: [Beignet] [PATCH] fix typo for DEBUGP to avoid print extra empty line

2016-01-18 Thread Yang, Rong R
Pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > He Junyan > Sent: Friday, January 15, 2016 20:55 > To: beignet@lists.freedesktop.org > Subject: Re: [Beignet] [PATCH] fix typo for DEBUGP to avoid print extra > empty line >

Re: [Beignet] [PATCH Release_v1.1] Backend: Fix the bug of printf in multi kernels within on file.

2016-01-18 Thread Yang, Rong R
LGTM, pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > junyan...@inbox.com > Sent: Thursday, January 14, 2016 16:01 > To: beignet@lists.freedesktop.org > Subject: [Beignet] [PATCH Release_v1.1] Backend: Fix the bug of printf

Re: [Beignet] [PATCH 2/2] Add the serializeToBin and deserializeFromBin for kernel arg info.

2016-01-18 Thread Yang, Rong R
LGTM, pushed to master and Release_v1.1. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > junyan...@inbox.com > Sent: Monday, January 18, 2016 16:49 > To: beignet@lists.freedesktop.org > Subject: [Beignet] [PATCH 2/2] Add the serializeToBin

Re: [Beignet] Most of utest cases run failed

2016-01-20 Thread Yang, Rong R
All errores are CL_INVALID_BUFFER_SIZE, seems device's global_mem_size or/and max_mem_alloc_size too small. These values are calculated from drm_intel_get_aperture_sizes and sysinfo, can you provide these functions return value in file src/cl_device_id.c and src/intel/intel_driver.c. Thanks. >

Re: [Beignet] [PATCH V4] Fix the bug when we pass argument with spaces.

2016-01-24 Thread Yang, Rong R
LGTM, pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > junyan...@inbox.com > Sent: Thursday, January 21, 2016 18:44 > To: beignet@lists.freedesktop.org > Subject: [Beignet] [PATCH V4] Fix the bug when we pass argument with >

Re: [Beignet] [PATCH] utest: correct a typo in compiler_cl_finish.cpp

2016-01-24 Thread Yang, Rong R
LGTM, pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Guo Yejun > Sent: Monday, January 25, 2016 3:32 > To: beignet@lists.freedesktop.org > Cc: Guo, Yejun > Subject: [Beignet] [PATCH] utest: correct a typo in compiler_cl_fi

Re: [Beignet] [PATCH V2] Backend: Add support for LLVM release 3.8

2016-02-13 Thread Yang, Rong R
Pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Song, Ruiling > Sent: Monday, February 1, 2016 11:26 > To: Pan, Xiuli; beignet@lists.freedesktop.org > Cc: Pan, Xiuli > Subject: Re: [Beignet] [PATCH V2] Backend: Add support

Re: [Beignet] [PATCH V2] correct ASM output for byte scattered read/write

2016-02-13 Thread Yang, Rong R
LGTM, pushed. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Guo Yejun > Sent: Friday, February 5, 2016 7:57 > To: beignet@lists.freedesktop.org > Cc: Guo, Yejun > Subject: [Beignet] [PATCH V2] correct ASM output for byte scattered > read

Re: [Beignet] [PATCH] Backend: Remove uselsee ParseCommandLineOptions

2016-02-13 Thread Yang, Rong R
LGTM, pushed. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Pan Xiuli > Sent: Friday, January 29, 2016 17:14 > To: beignet@lists.freedesktop.org > Cc: Pan, Xiuli > Subject: [Beignet] [PATCH] Backend: Remove uselsee > ParseCommandLineOpti

Re: [Beignet] [PATCH V2 3/3] enable byte gather for vload2/3/4/8(offset, char*) on SKL, BXT and BDW

2016-02-24 Thread Yang, Rong R
Pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Song, Ruiling > Sent: Wednesday, February 24, 2016 13:49 > To: Guo, Yejun ; beignet@lists.freedesktop.org > Cc: Guo, Yejun > Subject: Re: [Beignet] [PATCH V2 3/3] enable byte

Re: [Beignet] [PATCH] Fix building with clang++

2016-02-24 Thread Yang, Rong R
The patchset LGTM, pushed, thanks. BTW: please add the signed-off info when format patch next time:) > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Armin K > Sent: Monday, February 22, 2016 8:47 > To: beignet@lists.freedesktop.org > Cc:

Re: [Beignet] [PATCH] Revert "GBE: disable mad for some cases."

2016-02-24 Thread Yang, Rong R
Pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Song, Ruiling > Sent: Friday, February 19, 2016 16:43 > To: Gong, Zhigang ; > beignet@lists.freedesktop.org > Cc: Gong, Zhigang > Subject: Re: [Beignet] [PATCH] Revert "GBE:

Re: [Beignet] [PATCH] GBE: remove stacksize 64KB limitation.

2016-02-24 Thread Yang, Rong R
> > + p->MUL(stackptr, stackptr, GenRegister::immud(perLaneSize)); // > > + (threadId > > * simdWidth + laneId)*perLaneSize > According to Hardware Spec: > For IVB and HSW, When both src0 and src1 are of type D or UD, only the low > 16 bits of each element of src1 are used. The accumulator mai

Re: [Beignet] Intel Skylake Xeon + FreeBSD?

2016-03-01 Thread Yang, Rong R
Yes, Beignet support Skylake. It looks like your Beignet installed, but can’t open device when run. Is there any device under path /dev/dri/? If /dev/dri/renderDxxx or /dev/dri/cardxx exist, please you try root to run clinfo again. From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On

Re: [Beignet] [PATCH] GBE: remove stacksize 64KB limitation.

2016-03-01 Thread Yang, Rong R
Remove the .swp files and pushed, thanks. > -Original Message- > From: Song, Ruiling > Sent: Tuesday, March 1, 2016 20:23 > To: Yang, Rong R ; beignet@lists.freedesktop.org > Cc: Yang, Rong R > Subject: RE: [Beignet] [PATCH] GBE: remove stacksize 64KB limitation. >

Re: [Beignet] cl_khr_fp64 on OpenCL 1.2+

2016-03-02 Thread Yang, Rong R
Yes, In OpenCL 1.2, using double no longer requires using the pragma cl_khr_fp64. But clang support it from clang 3.7. which llvm/clang version do you use? Could you update to llvm/clang 3.7 and try again? > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.or

Re: [Beignet] [PATCH OCL20 11/11] Backend: Add uncompatiblePCHOptions for OCL20

2016-03-15 Thread Yang, Rong R
The patchset pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Xiuli Pan > Sent: Wednesday, March 2, 2016 11:02 > To: beignet@lists.freedesktop.org > Cc: Pan, Xiuli > Subject: [Beignet] [PATCH OCL20 11/11] Backend: Add > unc

Re: [Beignet] [PATCH OCL20 5/5] Runtime: Add support for clGetMemObjectInfo

2016-03-15 Thread Yang, Rong R
Patchset LGTM, pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Xiuli Pan > Sent: Friday, March 4, 2016 10:05 > To: beignet@lists.freedesktop.org > Cc: Pan, Xiuli > Subject: [Beignet] [PATCH OCL20 5/5] Runtime: Add support

Re: [Beignet] [PATCH] Refine custom unrolling policy.

2016-03-18 Thread Yang, Rong R
LGTM, pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Zhigang Gong > Sent: Friday, March 4, 2016 14:53 > To: beignet@lists.freedesktop.org > Cc: Zhigang Gong > Subject: [Beignet] [PATCH] Refine custom unrolling policy. >

Re: [Beignet] [PATCH 1/2] Backend: Refine get_enqueued_local_size and get_local_size

2016-03-19 Thread Yang, Rong R
LGTM, pushed. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Xiuli Pan > Sent: Wednesday, March 16, 2016 7:53 > To: beignet@lists.freedesktop.org > Cc: Pan, Xiuli > Subject: [Beignet] [PATCH 1/2] Backend: Refine get_enqueued_local_size >

Re: [Beignet] [PATCH] change behavior of mul24/mad24 when out of range

2016-03-19 Thread Yang, Rong R
LGTM, pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Guo, Yejun > Sent: Tuesday, March 8, 2016 14:54 > To: Guo, Yejun ; beignet@lists.freedesktop.org > Subject: Re: [Beignet] [PATCH] change behavior of mul24/mad24 when out

Re: [Beignet] [PATCH] enable FP_CONTRACT on as default, and implemented with MAD

2016-03-19 Thread Yang, Rong R
Pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Guo, Yejun > Sent: Tuesday, March 8, 2016 14:52 > To: Song, Ruiling ; beignet@lists.freedesktop.org > Subject: Re: [Beignet] [PATCH] enable FP_CONTRACT on as default, and > im

Re: [Beignet] [PATCH] Add condition checking of residuals because it may be NULL.

2016-04-05 Thread Yang, Rong R
Pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Weng, Chuanbo > Sent: Tuesday, March 29, 2016 11:04 > To: yan.w...@linux.intel.com; beignet@lists.freedesktop.org > Subject: Re: [Beignet] [PATCH] Add condition checking of re

Re: [Beignet] [PATCH] [OCL20] atomic bug fix.

2016-04-05 Thread Yang, Rong R
Pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Pan, Xiuli > Sent: Monday, March 21, 2016 15:23 > To: Luo, Xionghu ; beignet@lists.freedesktop.org > Cc: Luo, Xionghu > Subject: Re: [Beignet] [PATCH] [OCL20] atomic bug fix.

Re: [Beignet] [PATCH] Libocl: change prototype of math built-in for OCL2.0 spec

2016-04-05 Thread Yang, Rong R
Pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Xiuli Pan > Sent: Tuesday, March 22, 2016 12:38 > To: beignet@lists.freedesktop.org > Cc: Pan, Xiuli > Subject: [Beignet] [PATCH] Libocl: change prototype of math built-in fo

Re: [Beignet] [PATCH] Prepend std namespace to isnan and isinf calls.

2016-04-07 Thread Yang, Rong R
The format have some error, fix it by manual. Pushed, thanks for your contribution. From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Pan, Xiuli Sent: Wednesday, April 6, 2016 12:35 To: Pan, Xiuli ; Sean Lynch Cc: beignet@lists.freedesktop.org Subject: Re: [Beignet] [PAT

Re: [Beignet] [PATCH] utest: do not check MV near image border

2016-04-07 Thread Yang, Rong R
Pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > yan.w...@linux.intel.com > Sent: Thursday, March 17, 2016 17:33 > To: Guo, Yejun > Cc: Guo, Yejun ; beignet@lists.freedesktop.org > Subject: Re: [Beignet] [PATCH] utest: do n

Re: [Beignet] [PATCH] libocl: Refine return type of workitem built-in functions

2016-04-07 Thread Yang, Rong R
LGTM, pushed, merge your patch "[Beignet] [PATCH] Utest: Add utest load spir for spir64" to one commit to avoid utest assert. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Xiuli Pan > Sent: Tuesday, March 29, 2016 16:12 > To: beignet@li

Re: [Beignet] [PATCH] Increase size for compile log output

2016-04-07 Thread Yang, Rong R
LGTM, pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Giuseppe Bilotta > Sent: Friday, March 25, 2016 19:15 > To: beignet@lists.freedesktop.org > Cc: Giuseppe Bilotta > Subject: [Beignet] [PATCH] Increase size for compile

Re: [Beignet] [PATCH] Runtime: Add SKL device id for new SKL device

2016-04-07 Thread Yang, Rong R
LGTM, pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Xiuli Pan > Sent: Friday, April 1, 2016 5:15 > To: beignet@lists.freedesktop.org > Cc: in...@terre-adelie.org; Pan, Xiuli > Subject: [Beignet] [PATCH] Runtime: Add SKL

Re: [Beignet] [PATCH V2] GBE: add ocl 2.0 work_group_barrier support.

2016-04-08 Thread Yang, Rong R
The patchset pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Ruiling Song > Sent: Tuesday, April 5, 2016 15:20 > To: beignet@lists.freedesktop.org > Cc: Song, Ruiling > Subject: [Beignet] [PATCH V2] GBE: add ocl 2.0 work_g

Re: [Beignet] [PATCH] Flush kernel source dump stream

2016-04-12 Thread Yang, Rong R
LGTM, pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Zhenyu Wang > Sent: Tuesday, April 12, 2016 14:45 > To: beignet@lists.freedesktop.org > Subject: [Beignet] [PATCH] Flush kernel source dump stream > > If kernel source

Re: [Beignet] [PATCH V2] Utest: Add result error tolerance for float data types

2016-04-13 Thread Yang, Rong R
Tha patchset pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > grigore.lupe...@intel.com > Sent: Wednesday, April 13, 2016 18:29 > To: beignet@lists.freedesktop.org > Subject: [Beignet] [PATCH V2] Utest: Add result error tole

Re: [Beignet] [PATCH v4 3/5] standalone utest for unified OpenCL implementation.

2016-04-26 Thread Yang, Rong R
LGTM, pushed, thanks. It's better to add readme for it. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > xionghu@intel.com > Sent: Saturday, April 23, 2016 0:37 > To: beignet@lists.freedesktop.org > Cc: Luo, Xionghu > Subject: [Beigne

Re: [Beignet] [PATCH] runtime: handle PROGRAM_BUILD_GLOBAL_VARIABLE_TOTAL_SIZE

2016-04-26 Thread Yang, Rong R
Pushed, thanks. > -Original Message- > From: Pan, Xiuli > Sent: Tuesday, April 26, 2016 14:43 > To: Song, Ruiling ; 'beignet@lists.freedesktop.org' > > Cc: Yang, Rong R > Subject: RE: [Beignet] [PATCH] runtime: handle > PROGRAM_BUILD_GLOBAL_VAR

Re: [Beignet] [PATCH] GBE: Fix destination grf register type for cmp instruction.

2016-04-26 Thread Yang, Rong R
Pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Pan, Xiuli > Sent: Tuesday, April 26, 2016 14:40 > To: Song, Ruiling ; beignet@lists.freedesktop.org > Cc: Song, Ruiling > Subject: Re: [Beignet] [PATCH] GBE: Fix destination

Re: [Beignet] [PATCH] only release cmrt device when it is already created

2016-04-28 Thread Yang, Rong R
LGTM, pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Guo Yejun > Sent: Thursday, April 28, 2016 7:48 > To: beignet@lists.freedesktop.org > Cc: Guo, Yejun > Subject: [Beignet] [PATCH] only release cmrt device when it is al

Re: [Beignet] [PATCH V2 2/2] write mask in disassembly not parse correctly.

2016-04-28 Thread Yang, Rong R
The patchset pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Guo, Yejun > Sent: Thursday, April 28, 2016 10:00 > To: Luo, Xionghu ; beignet@lists.freedesktop.org > Cc: Luo, Xionghu > Subject: Re: [Beignet] [PATCH V2 2/2] w

Re: [Beignet] [PATCH V2 2/2] enable utest compiler_math_3op for mad test.

2016-04-28 Thread Yang, Rong R
The patchset pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Guo, Yejun > Sent: Wednesday, April 27, 2016 15:53 > To: Luo, Xionghu ; beignet@lists.freedesktop.org > Cc: Luo, Xionghu > Subject: Re: [Beignet] [PATCH V2 2/2]

Re: [Beignet] drm/i915/bxt: Pooled EU support in beignet

2016-04-28 Thread Yang, Rong R
This patch separate all EUs into 2 EU pools when the sub slice is 3, right? I think Beignet could use it to enlarge the work group size, thanks! But beignet need a libdrm api to check the kernel whether support Pooled EU or not to decide the work group size, as drm_intel_get_eu_total, does libdrm

Re: [Beignet] [PATCH OCL20 V2 1/4] Backend: Chang scan limit for GVN pass

2016-04-28 Thread Yang, Rong R
This patch would be reverted when LLVM have another solution instead of break GVN silently. The patchset LGTM, pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Xiuli Pan > Sent: Friday, April 29, 2016 11:25 > To: beignet@li

Re: [Beignet] [PATCH] FindLLVM: allow LLVM/Clang 3.7

2016-05-11 Thread Yang, Rong R
LGTM, pushed. Beignet support llvm from 3.5 to 3.8 now, I will add llvm3.8 and also remove some legacy version, thanks for your patch. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Rebecca N. Palmer > Sent: Monday, April 25, 2016 5:41

Re: [Beignet] [PATCH] cl_api; Check image origin and region for NULL

2016-05-11 Thread Yang, Rong R
LGTM, pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Jan Vesely > Sent: Friday, April 29, 2016 10:43 > To: beignet@lists.freedesktop.org > Subject: [Beignet] [PATCH] cl_api; Check image origin and region for NULL > > Sign

Re: [Beignet] [PATCH] Remove unncessary assertion in printf processing.

2016-05-16 Thread Yang, Rong R
Pushed. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Pan, Xiuli > Sent: Tuesday, May 3, 2016 14:43 > To: yan.w...@linux.intel.com; beignet@lists.freedesktop.org > Subject: Re: [Beignet] [PATCH] Remove unncessary assertion in printf > pr

Re: [Beignet] [PATCH] Add support for gcc 6

2016-05-16 Thread Yang, Rong R
LGTM, pushed. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Xiuli Pan > Sent: Tuesday, May 3, 2016 10:58 > To: beignet@lists.freedesktop.org > Cc: Pan, Xiuli > Subject: [Beignet] [PATCH] Add support for gcc 6 > > From: Pan Xiuli > >

Re: [Beignet] [PATCH] Backend: Fix bug build with clang

2016-05-16 Thread Yang, Rong R
LGTM, pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Xiuli Pan > Sent: Friday, April 29, 2016 14:32 > To: beignet@lists.freedesktop.org > Cc: Pan, Xiuli > Subject: [Beignet] [PATCH] Backend: Fix bug build with clang > >

Re: [Beignet] [PATCH 01/12] gbe/llvm: fix potential null pointer dereference.

2016-05-23 Thread Yang, Rong R
The patchset LGTM, pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > xionghu@intel.com > Sent: Friday, May 6, 2016 0:12 > To: beignet@lists.freedesktop.org > Cc: Luo, Xionghu > Subject: [Beignet] [PATCH 01/12] gbe/llvm:

Re: [Beignet] [PATCH] add howto for stand alone utest.

2016-05-23 Thread Yang, Rong R
Pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > xionghu@intel.com > Sent: Friday, May 6, 2016 0:11 > To: beignet@lists.freedesktop.org > Cc: Luo, Xionghu > Subject: [Beignet] [PATCH] add howto for stand alone utest. >

Re: [Beignet] [PATCH 2/2] Ensure paths to beignet.bc and beignet.pch include a / before the filename

2016-05-24 Thread Yang, Rong R
Pushed. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Guo, Yejun > Sent: Wednesday, May 25, 2016 8:59 > To: Burton, Ross ; beignet@lists.freedesktop.org > Subject: Re: [Beignet] [PATCH 2/2] Ensure paths to beignet.bc and > beignet.pch in

Re: [Beignet] [PATCH 07/10] Android: disable the read byte as DW.

2016-05-25 Thread Yang, Rong R
Ok, I will send a new version. From: Zhigang Gong [mailto:zhigang.g...@gmail.com] Sent: Thursday, May 26, 2016 9:52 To: Yang, Rong R Cc: beignet@lists.freedesktop.org; Gong, Zhigang Subject: Re: [Beignet] [PATCH 07/10] Android: disable the read byte as DW. This patch should not be a android

Re: [Beignet] Issue: Event callbacks not being called on event completion

2016-05-25 Thread Yang, Rong R
Yes, you are right, the beignet is hard to fix your case. I simplify your case: error_code = clEnqueueNDRangeKernel(command_queue, kernel, 1, nullptr, &global_work_size, nullptr, 0, nullptr, &event); error_code = clSetEventCallback(event,

Re: [Beignet] [Patch V2 07/10] GBE: disable the read byte as DW.

2016-05-26 Thread Yang, Rong R
Pushed, thanks. From: Zhigang Gong [mailto:zhigang.g...@gmail.com] Sent: Thursday, May 26, 2016 17:33 To: Yang, Rong R Cc: beignet@lists.freedesktop.org; Gong, Zhigang Subject: Re: [Beignet] [Patch V2 07/10] GBE: disable the read byte as DW. The whole patchset LGTM, thanks. On Thu, May 26

Re: [Beignet] [PATCH] GBE: Optimize extraLiveOut register info.

2016-06-12 Thread Yang, Rong R
Pushed, thanks. From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Monday, June 6, 2016 11:19 To: Song, Ruiling Cc: beignet@lists.freedesktop.org Subject: Re: [Beignet] [PATCH] GBE: Optimize extraLiveOut register info. This patch LGTM, thx. On Thu, Jun

Re: [Beignet] [PATCH] Runtime: Disable image hostptr for default

2016-06-12 Thread Yang, Rong R
LGTM, pushed. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Xiuli Pan > Sent: Friday, June 3, 2016 11:02 > To: beignet@lists.freedesktop.org > Cc: Pan, Xiuli > Subject: [Beignet] [PATCH] Runtime: Disable image hostptr for default > > F

Re: [Beignet] [PATCH] Add cl_khr_3d_image_writes into info string.

2016-06-12 Thread Yang, Rong R
LGTM, pushed. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > yan.w...@linux.intel.com > Sent: Friday, June 3, 2016 13:38 > To: beignet@lists.freedesktop.org > Cc: Yan Wang > Subject: [Beignet] [PATCH] Add cl_khr_3d_image_writes into info

Re: [Beignet] [PATCH] runtime: The depth should be 1 for CL_MEM_OBJECT_IMAGE2D in beignet's implementation.

2016-06-12 Thread Yang, Rong R
LGTM, pushed. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Chuanbo Weng > Sent: Tuesday, June 7, 2016 11:04 > To: beignet@lists.freedesktop.org > Cc: Weng, Chuanbo > Subject: [Beignet] [PATCH] runtime: The depth should be 1 for > CL_ME

Re: [Beignet] [PATCH V3 11/12] Backend: Add intel_sub_group_block_read/write form image

2016-06-13 Thread Yang, Rong R
The patchset LGTM, pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Xiuli Pan > Sent: Sunday, June 12, 2016 5:33 > To: beignet@lists.freedesktop.org > Cc: Pan, Xiuli > Subject: [Beignet] [PATCH V3 11/12] Backend: Add > inte

Re: [Beignet] Fix definition of FLT_MIN/FLT_MAX for clang-3.8 compilation

2016-06-13 Thread Yang, Rong R
Pushed. From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Pan, Xiuli Sent: Sunday, June 12, 2016 16:26 To: Andrew Lavin ; Beignet Subject: Re: [Beignet] Fix definition of FLT_MIN/FLT_MAX for clang-3.8 compilation LGTM! Thanks! From: Beignet [mailto:beignet-boun...@list

Re: [Beignet] [PATCH 2/2] GBE: warning when the GEN binary version mismatch.

2016-06-22 Thread Yang, Rong R
Ok, I will push this patch first, and post a refine patch. > -Original Message- > From: Song, Ruiling > Sent: Wednesday, June 22, 2016 10:31 > To: Yang, Rong R ; beignet@lists.freedesktop.org > Cc: Yang, Rong R > Subject: RE: [Beignet] [PATCH 2/2] GBE: warning w

Re: [Beignet] [PATCH] output message instead of assert when .bc file does not exist

2016-06-22 Thread Yang, Rong R
LGTM, pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Guo Yejun > Sent: Friday, June 17, 2016 3:28 > To: beignet@lists.freedesktop.org > Cc: Guo, Yejun > Subject: [Beignet] [PATCH] output message instead of assert when .bc

Re: [Beignet] [PATCH] Libocl: Add define for new added cl_khr_3d_image_writes extension

2016-06-22 Thread Yang, Rong R
LGTM, pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Xiuli Pan > Sent: Wednesday, June 22, 2016 13:19 > To: beignet@lists.freedesktop.org > Cc: Pan, Xiuli > Subject: [Beignet] [PATCH] Libocl: Add define for new added > cl

Re: [Beignet] [PATCH 4/5] Backend: Optimization internal math, use mad

2016-06-22 Thread Yang, Rong R
This patchset will cause some math utests fail in IVB, such as builtin_acos_asin, builtin_lgamma_float and so on. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Song, Ruiling > Sent: Monday, June 6, 2016 16:39 > To: Lupescu, Grigore ; >

Re: [Beignet] [PATCH 1/2] Remove nonexisting unit test cases in Android.mk.

2016-06-24 Thread Yang, Rong R
The patchset LGTM, will push later. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Zhigang Gong > Sent: Thursday, June 23, 2016 10:25 > To: beignet@lists.freedesktop.org > Cc: Gong, Zhigang > Subject: [Beignet] [PATCH 1/2] Remove nonexis

Re: [Beignet] [PATCH V2] GBE: Improve spill policy by considering use count.

2016-06-24 Thread Yang, Rong R
The patchset LGTM, and the algorithm finding spill cost could refine later. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Ruiling Song > Sent: Friday, June 24, 2016 16:20 > To: beignet@lists.freedesktop.org > Cc: Song, Ruiling > Subject

Re: [Beignet] [PATCH V5] Backend: Refine block read/write buffer

2016-06-24 Thread Yang, Rong R
The patchset LGTM, pushed. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Xiuli Pan > Sent: Friday, June 24, 2016 11:08 > To: beignet@lists.freedesktop.org > Cc: Pan, Xiuli > Subject: [Beignet] [PATCH V5] Backend: Refine block read/write

Re: [Beignet] [PATCH 4/5] Backend: Optimization internal math, use mad

2016-06-24 Thread Yang, Rong R
Can you compare the LLVM IR/GEN IR/ASM between the IVB and HSW, use same version llvm, maybe could quick find the root cause. > -Original Message- > From: Lupescu, Grigore > Sent: Friday, June 24, 2016 1:16 > To: Yang, Rong R ; Song, Ruiling > ; beignet@lists.freedeskto

Re: [Beignet] [PATCH] intel: Export pooled EU and min no. of eus in a pool.

2016-06-30 Thread Yang, Rong R
Hi, Arun, Beignet patch is reviewed by ruiling, can you have to export them? Thanks, Yang Rong > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Arun Siluvery > Sent: Wednesday, June 15, 2016 16:17 > To: Yang, R

Re: [Beignet] [PATCH] enlarge buf size to avoid memory out of range written by GPU (kernel)

2016-07-04 Thread Yang, Rong R
LGTM, pushed, with indent refine, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Guo, Yejun > Sent: Monday, July 4, 2016 9:10 > To: Guo, Yejun ; beignet@lists.freedesktop.org > Subject: Re: [Beignet] [PATCH] enlarge buf size to av

Re: [Beignet] [PATCH] GBE: reorder the condition to avoid array overflow.

2016-07-04 Thread Yang, Rong R
Pushed, thanks. > -Original Message- > From: Song, Ruiling > Sent: Monday, July 4, 2016 10:34 > To: Yang, Rong R ; beignet@lists.freedesktop.org > Cc: Yang, Rong R > Subject: RE: [Beignet] [PATCH] GBE: reorder the condition to avoid array > overflow. > > LGTM.

Re: [Beignet] [PATCH] intel: Export pooled EU and min no. of eus in a pool.

2016-07-05 Thread Yang, Rong R
Yes, it is libdrm patch. I have merged the beignet patch right now, but still depend on the libdrm patch, I will resend it to libdrm now. Thanks. > -Original Message- > From: Arun Siluvery [mailto:arun.siluv...@linux.intel.com] > Sent: Tuesday, July 5, 2016 18:01 > To:

Re: [Beignet] [PATCH] Report build failures in backend to the build log

2016-07-13 Thread Yang, Rong R
Sorry I missed this patch. GBE has two type assert, one is internal debug assert, another one is caused by user's kernel. I think the second assert is unreasonable and need to report the failures instead of assert. Your patch is one of unreasonable assert, this patch is LGTM. And maybe we coul

Re: [Beignet] [PATCH] intel: Export pooled EU and min no. of eus in a pool.

2016-07-14 Thread Yang, Rong R
OK, I have send a new version patch. > -Original Message- > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > Sent: Thursday, July 14, 2016 3:10 > To: Arun Siluvery > Cc: Yang, Rong R ; beignet@lists.freedesktop.org; > dri-de...@lists.freedesktop.org; Dani

Re: [Beignet] [PATCH V2 5/6] Backend: Add intel_sub_group_shuffle_down/up/xor

2016-07-15 Thread Yang, Rong R
The first 4 patches is LGTM, will push them. For intel_sub_group_shuffle_down/up implement, we'd better handle it in the opencl c level. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Xiuli Pan > Sent: Thursday, July 7, 2016 11:10 > To:

Re: [Beignet] cl_get_gt_device(): error while running OPenCL on Kabylake

2016-07-19 Thread Yang, Rong R
I am starting to support KBL. As I know KBL is very similar with SKL, suppose beignet could basically support (pass some test and without performance tuning) KBL soon. From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Mahesh kumar.p. Sent: Monday, July 18, 2016 16:46 To:

Re: [Beignet] [Patch V3] intel: Export pooled EU and min no. of eus in a pool.

2016-08-01 Thread Yang, Rong R
top.org; dri-de...@lists.freedesktop.org > Cc: Yang, Rong R > Subject: [Beignet] [Patch V3] intel: Export pooled EU and min no. of eus in a > pool. > > Update kernel interface with new I915_GETPARAM ioctl entries for pooled > EU and min no. of eus in a pool. Add a wrapping function for each pa

Re: [Beignet] [PATCH 4/4] Backend: Optimization internal math, use mad

2016-08-03 Thread Yang, Rong R
The patchset pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > grigore.lupe...@intel.com > Sent: Tuesday, July 26, 2016 21:25 > To: beignet@lists.freedesktop.org > Subject: [Beignet] [PATCH 4/4] Backend: Optimization internal

Re: [Beignet] [PATCH] only check beignet special test cases on beignet

2016-08-03 Thread Yang, Rong R
All utest patches pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Guo Yejun > Sent: Wednesday, August 3, 2016 3:13 > To: beignet@lists.freedesktop.org > Cc: Guo, Yejun > Subject: [Beignet] [PATCH] only check beignet specia

Re: [Beignet] [PATCH 1/2] FindLLVM: allow LLVM/Clang 3.8 and reorder the llvm-config priority.

2016-08-03 Thread Yang, Rong R
Pushed. > -Original Message- > From: Song, Ruiling > Sent: Tuesday, August 2, 2016 14:18 > To: Yang, Rong R ; beignet@lists.freedesktop.org > Cc: Yang, Rong R > Subject: RE: [Beignet] [PATCH 1/2] FindLLVM: allow LLVM/Clang 3.8 and > reorder the llvm-config priority.

Re: [Beignet] [PATCH] Runtime: Fix hang for bsw device with 12 EU

2016-08-03 Thread Yang, Rong R
Pushed. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Xiuli Pan > Sent: Friday, July 29, 2016 17:53 > To: beignet@lists.freedesktop.org > Cc: Pan, Xiuli > Subject: [Beignet] [PATCH] Runtime: Fix hang for bsw device with 12 EU > > From:

Re: [Beignet] [PATCH] Runtime: fix a userptr bug.

2016-08-03 Thread Yang, Rong R
Pushed. > -Original Message- > From: Guo, Yejun > Sent: Tuesday, July 26, 2016 15:20 > To: Yang, Rong R ; beignet@lists.freedesktop.org > Cc: Yang, Rong R > Subject: RE: [Beignet] [PATCH] Runtime: fix a userptr bug. > > LGTM, thanks. > > -Origina

Re: [Beignet] [PATCH V3] Utset: Add check for workgroup tests

2016-08-03 Thread Yang, Rong R
Pushed. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Guo, Yejun > Sent: Wednesday, July 27, 2016 10:27 > To: Pan, Xiuli ; beignet@lists.freedesktop.org > Cc: Pan, Xiuli > Subject: Re: [Beignet] [PATCH V3] Utset: Add check for workgroup

Re: [Beignet] [PATCH] Runtime: Add assert of pthread_getspecific.

2016-08-04 Thread Yang, Rong R
Ping for review. > -Original Message- > From: Yang, Rong R > Sent: Monday, June 6, 2016 18:10 > To: beignet@lists.freedesktop.org > Cc: Yang, Rong R > Subject: [PATCH] Runtime: Add assert of pthread_getspecific. > > Signed-off-by: Yang Rong >

Re: [Beignet] [PATCH 1/2] GBE: Further optimize phiNode elimination.

2016-08-11 Thread Yang, Rong R
I think this optimization is too special. Maybe we could analyze the hole in IR, optimize register allocate to approach the same optimize. It is more common. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Ruiling Song > Sent: Friday, Ju

Re: [Beignet] [PATCH V2 7/9] Utest: Add test for half type subgroup functions

2016-08-12 Thread Yang, Rong R
One comment. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Xiuli Pan > Sent: Monday, August 8, 2016 11:31 > To: beignet@lists.freedesktop.org > Cc: Pan, Xiuli > Subject: [Beignet] [PATCH V2 7/9] Utest: Add test for half type subgroup >

Re: [Beignet] [PATCH 1/2] Utest: Fix utest case with issues value

2016-08-12 Thread Yang, Rong R
The patchset LGTM, pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Xiuli Pan > Sent: Friday, August 12, 2016 16:54 > To: beignet@lists.freedesktop.org > Cc: Pan, Xiuli > Subject: [Beignet] [PATCH 1/2] Utest: Fix utest case

[Beignet] [ANNOUNCE] Beignet 1.2.0

2016-08-30 Thread Yang, Rong R
order the condition to avoid array overflow. Runtime: set the sub slice according to kernel pooled EU configure. README: remove "legacy Illegal pointer issue" section. FindLLVM: allow LLVM/Clang 3.8 and reorder the llvm-config priority. KBL: add kabylake pciid

Re: [Beignet] [PATCH] Backend: Refine gen ir ALU1 inst getType

2016-08-30 Thread Yang, Rong R
The float mov's performance may double compare to integer's, in the GEN7 and GEN75, so it is an optimization. This patch will disable this optimization, is there any other method to fix this bug? > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Beh

Re: [Beignet] [PATCH] Backend: Refine block_read buffer with unaligned OWord block read

2016-08-30 Thread Yang, Rong R
Maybe aligned OWord block read's performance is better than unaligned, but because there is no way to check the address is OWord aligned or not in the compiler, and will introduce the other overhead if check in the runtime, so use unaligned OWord block read is OK to me. Will push it later. > -

Re: [Beignet] [PATCH] Utest: Add test for half type subgroup functions

2016-08-30 Thread Yang, Rong R
LGTM, will push it later, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Xiuli Pan > Sent: Thursday, August 18, 2016 12:57 > To: beignet@lists.freedesktop.org > Cc: Pan, Xiuli > Subject: [Beignet] [PATCH] Utest: Add test for half

Re: [Beignet] [PATCH] fix the condition to check if there are built-in kernels

2016-08-30 Thread Yang, Rong R
LGTM, will push it, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Guo Yejun > Sent: Friday, August 19, 2016 7:37 > To: beignet@lists.freedesktop.org > Cc: Guo, Yejun > Subject: [Beignet] [PATCH] fix the condition to check if the

Re: [Beignet] [PATCH] use OCL_MAP_BUFFER_GTT to map climage

2016-08-30 Thread Yang, Rong R
LGTM, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Guo Yejun > Sent: Friday, August 19, 2016 8:57 > To: beignet@lists.freedesktop.org > Cc: Guo, Yejun > Subject: [Beignet] [PATCH] use OCL_MAP_BUFFER_GTT to map climage > > Sign

Re: [Beignet] [PATCH] Apply image offset to read/write/map operations

2016-08-31 Thread Yang, Rong R
Yes, if images are created from clCreateImageFromLibvaIntel or created from buffer, the images may have an offset. Now this offset is only used in GPU side, when GPU/write, the result is correct. But in the CPU side, read/write/map, it is ignored, this is wrong. Thanks for your patch, could you f

Re: [Beignet] [PATCH V2] fix the condition to check if there are built-in kernels

2016-08-31 Thread Yang, Rong R
Will use this version, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Guo Yejun > Sent: Monday, August 22, 2016 2:58 > To: beignet@lists.freedesktop.org > Cc: Guo, Yejun > Subject: [Beignet] [PATCH V2] fix the condition to check

Re: [Beignet] [PATCH] avoid too many messages when the driver could not find good values for local_size

2016-08-31 Thread Yang, Rong R
Yes, this message is just a hint, I think one time is enough, LGTM, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Guo Yejun > Sent: Wednesday, August 31, 2016 7:20 > To: beignet@lists.freedesktop.org > Cc: Guo, Yejun > Subject:

Re: [Beignet] [PATCH] Runtime: Fix null device for clGetKernelWorkGroupInfo

2016-08-31 Thread Yang, Rong R
LGTM, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Xiuli Pan > Sent: Friday, August 19, 2016 17:46 > To: beignet@lists.freedesktop.org > Cc: Pan, Xiuli > Subject: [Beignet] [PATCH] Runtime: Fix null device for > clGetKernelWork

  1   2   3   4   5   6   7   8   9   >