Re: [Beignet] [PATCH v2] Fix bug: Initialize bti of LoadInstuctionPattern::shootByteGatherMsg().

2016-11-30 Thread Yang, Rong R
Pushed, thanks.

> -Original Message-
> From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of
> Song, Ruiling
> Sent: Thursday, November 24, 2016 14:56
> To: yan.w...@linux.intel.com; beignet@lists.freedesktop.org
> Subject: Re: [Beignet] [PATCH v2] Fix bug: Initialize bti of
> LoadInstuctionPattern::shootByteGatherMsg().
> 
> Looks good. Thanks for the fix.
> 
> - Ruiling
> 
> > -Original Message-
> > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf
> > Of yan.w...@linux.intel.com
> > Sent: Thursday, November 24, 2016 2:55 PM
> > To: beignet@lists.freedesktop.org
> > Cc: Yan Wang <yan.w...@linux.intel.com>
> > Subject: [Beignet] [PATCH v2] Fix bug: Initialize bti of
> > LoadInstuctionPattern::shootByteGatherMsg().
> >
> > From: Yan Wang <yan.w...@linux.intel.com>
> >
> > If it isn't initialized, Luxmark hotel scene will display wrong.
> > ---
> >  backend/src/backend/gen_insn_selection.cpp | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/backend/src/backend/gen_insn_selection.cpp
> > b/backend/src/backend/gen_insn_selection.cpp
> > index c14e0bc..c9a5be7 100644
> > --- a/backend/src/backend/gen_insn_selection.cpp
> > +++ b/backend/src/backend/gen_insn_selection.cpp
> > @@ -4487,7 +4487,7 @@ extern bool OCL_DEBUGINFO; // first defined by
> > calling BVAR in program.cpp
> >using namespace ir;
> >unsigned addrBytes = typeSize(addr.type);
> >AddressMode AM = insn.getAddressMode();
> > -  vector btiTemp;
> > +  vector btiTemp = sel.getBTITemps(AM);
> >if (AM == AM_DynamicBti || AM == AM_StaticBti) {
> >  if (AM == AM_DynamicBti) {
> >Register btiReg = insn.getBtiReg();
> > --
> > 2.7.4
> >
> > ___
> > Beignet mailing list
> > Beignet@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/beignet
> ___
> Beignet mailing list
> Beignet@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/beignet
___
Beignet mailing list
Beignet@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/beignet


Re: [Beignet] [PATCH v2] Fix bug: Initialize bti of LoadInstuctionPattern::shootByteGatherMsg().

2016-11-23 Thread Song, Ruiling
Looks good. Thanks for the fix.

- Ruiling

> -Original Message-
> From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of
> yan.w...@linux.intel.com
> Sent: Thursday, November 24, 2016 2:55 PM
> To: beignet@lists.freedesktop.org
> Cc: Yan Wang 
> Subject: [Beignet] [PATCH v2] Fix bug: Initialize bti of
> LoadInstuctionPattern::shootByteGatherMsg().
> 
> From: Yan Wang 
> 
> If it isn't initialized, Luxmark hotel scene will display wrong.
> ---
>  backend/src/backend/gen_insn_selection.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/backend/src/backend/gen_insn_selection.cpp
> b/backend/src/backend/gen_insn_selection.cpp
> index c14e0bc..c9a5be7 100644
> --- a/backend/src/backend/gen_insn_selection.cpp
> +++ b/backend/src/backend/gen_insn_selection.cpp
> @@ -4487,7 +4487,7 @@ extern bool OCL_DEBUGINFO; // first defined by
> calling BVAR in program.cpp
>using namespace ir;
>unsigned addrBytes = typeSize(addr.type);
>AddressMode AM = insn.getAddressMode();
> -  vector btiTemp;
> +  vector btiTemp = sel.getBTITemps(AM);
>if (AM == AM_DynamicBti || AM == AM_StaticBti) {
>  if (AM == AM_DynamicBti) {
>Register btiReg = insn.getBtiReg();
> --
> 2.7.4
> 
> ___
> Beignet mailing list
> Beignet@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/beignet
___
Beignet mailing list
Beignet@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/beignet