Commit: 12c42738f3dad4c89d1b1b0935a4478c02005545 Author: Sergey Sharybin Date: Tue May 19 16:38:31 2020 +0200 Branches: master https://developer.blender.org/rB12c42738f3dad4c89d1b1b0935a4478c02005545
OpenSubdiv: Add TODO avoid checking face-varying topology for equality =================================================================== M intern/opensubdiv/internal/topology/topology_refiner_impl_compare.cc =================================================================== diff --git a/intern/opensubdiv/internal/topology/topology_refiner_impl_compare.cc b/intern/opensubdiv/internal/topology/topology_refiner_impl_compare.cc index 2d0c5ec599f..d8f52e5bbb5 100644 --- a/intern/opensubdiv/internal/topology/topology_refiner_impl_compare.cc +++ b/intern/opensubdiv/internal/topology/topology_refiner_impl_compare.cc @@ -76,6 +76,10 @@ bool checkPreliminaryMatches(const TopologyRefinerImpl *topology_refiner_impl, //////////////////////////////////////////////////////////////////////////////// // Compare attributes which affects on topology. +// +// TODO(sergey): Need to look into how auto-winding affects on face-varying +// indexing and, possibly, move to mesh topology as well if winding affects +// face-varyign as well. bool checkSingleUVLayerMatch(const OpenSubdiv::Far::TopologyLevel &base_level, const OpenSubdiv_Converter *converter, @@ -136,6 +140,8 @@ bool TopologyRefinerImpl::isEqualToConverter(const OpenSubdiv_Converter *convert return false; } + // NOTE: Do after geometry check, to be sure topology does match and all + // indexing will go fine. if (!blender::opensubdiv::checkTopologyAttributesMatch(this, converter)) { return false; } _______________________________________________ Bf-blender-cvs mailing list Bf-blender-cvs@blender.org https://lists.blender.org/mailman/listinfo/bf-blender-cvs