Re: [Bf-committers] .git-blame-ignore-revs entries.

2020-12-28 Thread amdbcg via Bf-committers
I'm new to this. Where is the procedure for code review? On Mon, Dec 28, 2020 at 6:06 PM Ray Molenkamp via Bf-committers < bf-committers@blender.org> wrote: > I'd prefer if we excluded small commits completely, but willing to > settle on clarifying that the "smaller" commits still ought to be > t

Re: [Bf-committers] .git-blame-ignore-revs entries.

2020-12-28 Thread Ray Molenkamp via Bf-committers
I'd prefer if we excluded small commits completely, but willing to settle on clarifying that the "smaller" commits still ought to be the result of automated tools, If there is no clear indication a cleanup was automated the commit should not be added. ie a commit "Cleanup: clang-tidy some-check" co

Re: [Bf-committers] .git-blame-ignore-revs entries.

2020-12-28 Thread Brecht Van Lommel via Bf-committers
Hi Ankit, Please go through code review for all commits, unless you are a module owner or admin that is the policy. Note that there are guidelines in the file itself. We could document it in the wiki too, but I'm not sure it's needed. Perhaps the wording can be clarified? Suggestions are welcome.

Re: [Bf-committers] .git-blame-ignore-revs entries.

2020-12-28 Thread Ray Molenkamp via Bf-committers
On 2020-12-28 12:47 p.m., Ankit wrote: > Hello > I'm getting used to it. > I'll remove several commits soon, now that I have received the > feedback on the last commit, and will use stricter conditions in the future. I'd like to replace "stricter conditions" with "well defined/documented conditio

Re: [Bf-committers] .git-blame-ignore-revs entries.

2020-12-28 Thread Ankit via Bf-committers
Hello I'm getting used to it. I'll remove several commits soon, now that I have received the feedback on the last commit, and will use stricter conditions in the future. My premise - for being lenient was that it saves other people from committing to the file which keeps the noise in git log lo

[Bf-committers] .git-blame-ignore-revs entries.

2020-12-28 Thread Ray Molenkamp via Bf-committers
All, What's going in with this file? there's 50+ commits in there and I disagree with virtually every single hash I sampled from it. If we want to hide large changes made by automated tools like the big clang-format [1] change, yeah awesome, but I really would still like to see smaller and clearl

[Bf-committers] GSoC 2020 testing frameworks branch merged

2020-12-28 Thread Himanshi kalra via Bf-committers
The soc-2020-testing-frameworks branch was successfully added to master. Commit link [1] New tests are welcome :) Currently, there are about 40 tests for mesh operators, and there are about 160 mesh operators in total.[2][3] [1]: https://developer.blender.org/rBe7b698327cd91 [2]: https://docs.go

[Bf-committers] Blender developer meeting notes - 2020.12.28

2020-12-28 Thread Bastien Montagne via Bf-committers
Hi, Here are the notes from today's developer meeting. Next meeting is Monday, 04 January 18:00 CET / 17:00 UTC, in #blender-coders on blender.chat. For the complete report read it on: https://devtalk.blender.org/t/28-december-2020/16728 Announcements == Was a very short meeting,

[Bf-committers] UI Loclization video

2020-12-28 Thread Ja Ga via Bf-committers
Dear all, I want to start translating Blender's user interface into Slovenian. I’ve seen the instructions posted on the website https://wiki.blender.org/wiki/Process/Translate_Blender, but sincerely this is pretty intimidating to me as amateur Windows user when I see command lines... I have alread