Re: [Bf-committers] Revisions for the final 2.78: Rigify super_arm super_leg

2016-09-28 Thread Lucio Rossi
Hello, Following the suggestions of Sergey I committed a new fix to the super_leg and super_arm sub-rigs. We got rid of the Child_of constraints altogether using copy_transforms on an MCH-socket bone and parenting the ik ctrls to it. This simplifies the code and solves both the problems we had: -

Re: [Bf-committers] Revisions for the final 2.78

2016-09-26 Thread Lucio Rossi
Thank you very much Sergey! I really appreciate it, Cheers Lucio 2016-09-26 14:33 GMT+02:00 Sergey Sharybin : > Hi again, > > After some discussion with Rigify guys, requested 4 revisions in this area > were also ported. > > Now i'm doing final touches to repositories, soon

Re: [Bf-committers] Revisions for the final 2.78

2016-09-26 Thread Sergey Sharybin
Hi again, After some discussion with Rigify guys, requested 4 revisions in this area were also ported. Now i'm doing final touches to repositories, soon it'll be an AHOY. On Mon, Sep 26, 2016 at 10:54 AM, Sergey Sharybin wrote: > Hi, > > Main repository, checked up to

Re: [Bf-committers] Revisions for the final 2.78: Rigify super_arm super_leg

2016-09-26 Thread Sergey Sharybin
Ok, have a more clear picture now. Let's port those changes over and call it all settled :) On Mon, Sep 26, 2016 at 12:37 PM, Lucio Rossi wrote: > Hi, > 1. No, we don't apply the same child_of twice. It think it depends on the > interaction between the single

Re: [Bf-committers] Revisions for the final 2.78: Rigify super_arm super_leg

2016-09-26 Thread Lucio Rossi
Hi, 1. No, we don't apply the same child_of twice. It think it depends on the interaction between the single constraint and the IK chain. 2. The fix "corrects" the ik-fk snapping functions in the case hand or foot ctrl bones have the child_of constraints on top of it. Unfortunately we very

Re: [Bf-committers] Revisions for the final 2.78: Rigify super_arm super_leg

2016-09-26 Thread Sergey Sharybin
Hi, On Mon, Sep 26, 2016 at 11:46 AM, Lucio Rossi wrote: > About the double matrix multiplication IMO it depends on the fact that two > extra child_of constraints have been added to the IK controller bones. > Though it works together with the fk/ik snaps we're

Re: [Bf-committers] Revisions for the final 2.78: Rigify super_arm super_leg

2016-09-26 Thread Lucio Rossi
Hi Sergei, I totally agree with you about the flaws you're pointing out in the code. Nonetheless, consider that the "bulk" code of these sub-rigs is copy-pasted from super_limb.py, arm.py and leg.py and it is in Rigify since the beginning. Rigify is a tremendous add-on though it surely needs some

Re: [Bf-committers] Revisions for the final 2.78

2016-09-26 Thread Sergey Sharybin
Hi, Main repository, checked up to 7c53260, following commits are ported: 4b891b4 Fix: Collada Importer did not import the Blender Profile information correctly when multiple objects are bound to same armature. This caused Bone tails to be placed wrong. 7a259d8 Collada: Trying to get rif of some

Re: [Bf-committers] Revisions for the final 2.78: Rigify super_arm super_leg

2016-09-26 Thread Sergey Sharybin
Hi, First two commtis are quite some code which does not address regression or trivial fix. So it is rather really risky to accept it now. The code itself is also weird: - You can clearly simplify the layer mask creation, and don't have it inlined as a list of False, False, False in

[Bf-committers] Revisions for the final 2.78: Rigify super_arm super_leg

2016-09-24 Thread Lucio Rossi
Hi, Adding to the last mail two commits that were missing... If it's possible include the following commits in the 2.78 release. They add a new super_arm and super_leg rigs with switchable child_of parenting: rBAff11927e8e07a46c8199d9681af639be52b6b1af

Re: [Bf-committers] Revisions for the final 2.78

2016-09-24 Thread Gaia Clary
If possible please also add the following 3 fixes for Collada: 4b891b40c218ef5f45706cbc4636a5333469dd1c Fix for an issue with the new Blender collada profile. Tested with Linux Build Bot: https://builder.blender.org/builders/linux_glibc219_x86_64_cmake/builds/289

Re: [Bf-committers] Revisions for the final 2.78

2016-09-23 Thread Joshua Leung
Hi, bf2c2d43ef3ff955560a6b22be04c8860d0beabe needs to be backported too Cheers, Joshua On Fri, Sep 23, 2016 at 1:17 AM, Sergey Sharybin wrote: > Hi, > > Ported that revision. > > Also ported ab09a80 from Bastien. > > On Thu, Sep 22, 2016 at 1:43 PM, Julian Eisel

Re: [Bf-committers] Revisions for the final 2.78

2016-09-22 Thread Sergey Sharybin
Hi, Ported that revision. Also ported ab09a80 from Bastien. On Thu, Sep 22, 2016 at 1:43 PM, Julian Eisel wrote: > Hi, > > Would propose to also include 63b90851c (GPencil: Fix memory leak > using stroke arrange OP). > > Cheers, > - Julian - > > On 22 September 2016 at

Re: [Bf-committers] Revisions for the final 2.78

2016-09-22 Thread Julian Eisel
Hi, Would propose to also include 63b90851c (GPencil: Fix memory leak using stroke arrange OP). Cheers, - Julian - On 22 September 2016 at 12:39, Sergey Sharybin wrote: > Hi, > > We are working on getting 2.78 finally released. > > here are the lists of revisions ported

[Bf-committers] Revisions for the final 2.78

2016-09-22 Thread Sergey Sharybin
Hi, We are working on getting 2.78 finally released. here are the lists of revisions ported to the branch since Release Candidate 2. Blender: 3b6ce41 Fix memory leak in copy pose operator 804f6bf fix Mac build with Xcode 8 fe28e35 Fix T49179: Parts of mesh disappear with adaptive subdivision