Re: [Bf-committers] Revisions for the final 2.78: Rigify super_arm super_leg
Hello, Following the suggestions of Sergey I committed a new fix to the super_leg and super_arm sub-rigs. We got rid of the Child_of constraints altogether using copy_transforms on an MCH-socket bone and parenting the ik ctrls to it. This simplifies the code and solves both the problems we had: - weird matrix multiplications - funny interaction with Visual Transformations you can find the fix here https://developer.blender.org/rBAbf668cc3eef5 Same as before this is totally back-compatible. The user can try the new limbs only choosing them explicitly. Besides this fix doesn't mess up with rigs already made with super_arm or super_leg limbs Hope there's still time for porting... Thank you :) Lucio 2016-09-26 14:32 GMT+02:00 Sergey Sharybin : > Ok, have a more clear picture now. > > Let's port those changes over and call it all settled :) > > On Mon, Sep 26, 2016 at 12:37 PM, Lucio Rossi > wrote: > > > Hi, > > 1. No, we don't apply the same child_of twice. It think it depends on the > > interaction between the single constraint and the IK chain. > > > > 2. The fix "corrects" the ik-fk snapping functions in the case hand or > foot > > ctrl bones have the child_of constraints on top of it. Unfortunately we > > very recently noticed that, independently of the modifications we made, > > adding the two child_of constraints on top of the IK ctrl bones messes up > > with the apply visual transform. This is not, I repaeat, dependent on the > > fix or on the previous code, it's just the interaction with the > constraints > > (IK and Child_of) and the transform functions. > > > > 3. By not-default I mean that when the user chooses a Pitchipoy rig the > > arms and legs are marked as super_limb (arm) and super_limb (leg) same as > > before the commits. If, and only if, the user wants to try the new > > functionality he/she has to give, esplicitly, the super_arm or super_leg > > property to the those bones. > > > > To sum up everything works as before the commits unless anyone wants to > try > > the new sub-rigs... > > > > 2016-09-26 12:16 GMT+02:00 Sergey Sharybin : > > > > > Hi, > > > > > > On Mon, Sep 26, 2016 at 11:46 AM, Lucio Rossi > > > > wrote: > > > > > > > About the double matrix multiplication IMO it depends on the fact > that > > > two > > > > > > > extra child_of constraints have been added to the IK controller bones. > > > > Though it works together with the fk/ik snaps we're experiencing some > > > other > > > > issue in the apply visual transform we're trying to address. > > > > > > > > > > That would be weird if same child_of matrix is applied twice. If it's > two > > > different child_of, then multiplying matrix by itself is not a correct > > way > > > to go to a proper space. > > > > > > You mention some other transform issues, so the fix is not even > complete? > > > > > > > > > > Finally, please consider that the two subrigs introduced are not (up > to > > > > now) default for arms and legs in the Pitchipoy rigs. > > > > > > > > > > We've passed two release candidates and few hours from calling a final > > > release. We have to be strict, meaning: the fix should either be fixing > > > regression or be dead-simple for inclusion. Currently this doesn't seem > > to > > > be the case here (especially assuming even with the fixes applied there > > are > > > still other issues). > > > > > > Did i understand correctly, that the fixes are in the area which is now > > > became default? In this case, how much unusable things are prior to the > > > fix? How much it's unusable after the fixes (you mentioned some issues > > > still)? > > > > > > 2016-09-26 10:46 GMT+02:00 Sergey Sharybin : > > > > > > > > > Hi, > > > > > > > > > > First two commtis are quite some code which does not address > > regression > > > > or > > > > > trivial fix. So it is rather really risky to accept it now. > > > > > > > > > > The code itself is also weird: > > > > > > > > > > - You can clearly simplify the layer mask creation, and don't have > it > > > > > inlined as a list of False, False, False in multiple places > > > > > - Multiple subsequent try/catch could be replaced with a single > check > > > > > whether `rigify_parameters` is in pbone. Using exceptions for that > is > > > > > totally wrong! > > > > > - The goal is to have code pep8-compliant, and the new code is > > clearly > > > > not > > > > > > > > > > Remaining two commits is clearly less code, but they are still > > > > suspicious. > > > > > Never heard of getting square of a transform matrix (mat*mat), and > > not > > > > sure > > > > > code was tested well enough after the change was done by all the > > users. > > > > > > > > > > On Sat, Sep 24, 2016 at 3:16 PM, Lucio Rossi < > > lucio.ross...@gmail.com> > > > > > wrote: > > > > > > > > > > > Hi, > > > > > > Adding to the last mail two commits that were missing... > > > > > > > > > > > > If it's possible include the following commits in the 2.78 > release. > > > > > > They add a new super_arm and super_leg
Re: [Bf-committers] Revisions for the final 2.78
Thank you very much Sergey! I really appreciate it, Cheers Lucio 2016-09-26 14:33 GMT+02:00 Sergey Sharybin : > Hi again, > > After some discussion with Rigify guys, requested 4 revisions in this area > were also ported. > > Now i'm doing final touches to repositories, soon it'll be an AHOY. > > On Mon, Sep 26, 2016 at 10:54 AM, Sergey Sharybin > wrote: > > > Hi, > > > > Main repository, checked up to 7c53260, following commits are ported: > > > > 4b891b4 Fix: Collada Importer did not import the Blender Profile > > information correctly when multiple objects are bound to same armature. > > This caused Bone tails to be placed wrong. > > 7a259d8 Collada: Trying to get rif of some warning messages on linux > > 36d0ea3 Collada: Trying to get rid of some warning messages on linux > > bf2c2d4 Fix T49441: Grease Pencil - pie menu - brush name field crashes > > blender > > 776a854 Fix T49430: append scene with gamelogic broken. > > 7c53260 Fix crash in own recent rB776a8548f03a049. > > d84c55f Fix T49417: Cycles crash - can't use 5 Gigabyte Tile EXR texture > > file > > 2372e67 Cycles: Don't sum up memory usage of all devices together for the > > stats > > 4e3578f Cycles: Prevent crash in special cases when object has less slots > > than mesh > > 1b2b7cf Cycles: Fix overflow caused by wrong size calculation in > > Mesh::add_undisplaced > > 335ee5c Fix T49310: incorrect Cycles standalone normals with negative > > scale. > > 0b89b31 Cycles: Fix T49411: Multiscatter GGX with zero roughness when > > Filter Glossy is enabled > > > > Addons repository, checked up to 434fa71, following commit was ported: > > > > 434fa71 Fix T49432: Archimesh crashes blender when room height info > changed > > > > > > On Sat, Sep 24, 2016 at 11:37 AM, Gaia Clary < > gaia.cl...@machinimatrix.org > > > wrote: > > > >> If possible please also add the following 3 fixes for Collada: > >> > >> 4b891b40c218ef5f45706cbc4636a5333469dd1c > >> > >> Fix for an issue with the new Blender collada profile. > >> Tested with Linux Build Bot: > >> https://builder.blender.org/builders/linux_glibc219_x86_64_ > >> cmake/builds/289 > >> > >> 7a259d8422b9fd29fb9990269821fa64fc146a01 > >> > >> Fixes Linux compiler warnings regarding the collada module. > >> Tested with Linux Build Bot: > >> https://builder.blender.org/builders/linux_glibc219_x86_64_ > >> cmake/builds/290) > >> > >> 36d0ea3123743e675333e90c712c69d666fe5710 > >> > >> Fixes another Linux compiler warning (sorry, amend did not work > >> after push) > >> Tested with Linux Build Bot: > >> https://builder.blender.org/builders/linux_glibc219_x86_64_ > >> cmake/builds/291 > >> > >> @whoever uses Collada: > >> > >> Please could you do a quick check if the commit 4b891b40 works for you? > >> Export rigged model -> import back rigged model > >> The imported skeleton should look similar to the exported skeleton (bone > >> lengths). > >> > >> thanks, > >> Gaia > >> > >> > >> On 22.09.2016 12:39, Sergey Sharybin wrote: > >> > Hi, > >> > > >> > We are working on getting 2.78 finally released. > >> > > >> > here are the lists of revisions ported to the branch since Release > >> > Candidate 2. > >> > > >> > Blender: > >> > > >> > 3b6ce41 Fix memory leak in copy pose operator > >> > 804f6bf fix Mac build with Xcode 8 > >> > fe28e35 Fix T49179: Parts of mesh disappear with adaptive subdivision > >> > e007552 Fix Py's IDs user mapping: do not consider proxy_from here. > >> > a2a5ae5 Fix Py's IDs user mapping: do not consider ShapeKeys' from > here. > >> > a8ed914 Fix crash in some cases when deleting particle systems. > >> > ddbbcbb Fix filebrowser not getting back to valid dir in Release > builds. > >> > 4b046c5 Fix T49372: Fresnel node: difference between 2.76 and 2.78 > GLSL > >> > output > >> > 0552d58 Fix T49384: crash in tangent space calculation with NaN mesh > >> > vertices. > >> > 6c28d3b Fix T49245: Adaptive Subdivision with Auto Smooth causes weird > >> mesh > >> > appearance > >> > 772dab9 Cycles: Fix typo that would sometimes result in subsurf > modifier > >> > being disabled > >> > 76b CacheFile: make sure SpinLock is destroyed when exiting > Blender. > >> > cc9d0ef Lowercase includes for psapi.h and dbghelp.h windows includes. > >> This > >> > makes cross compilation a little less painful > >> > 1f5cd85 Fix T49375: align rotation with snap target isn't toggleable > in > >> > edit mode. > >> > f2da63c Fix T49386: Blender crashes when told to load an OCIO LUT that > >> does > >> > not exist > >> > 2382d1c regression fix for 1346482d23f167fa57049128384246397fda8d27: > >> The > >> > length of leaf bones should always be set to the length of the > smallest > >> > bone. since the mentioned commit the importer did only recalculate the > >> leaf > >> > bone length when the 'fix leaf bones' option was also enabled. > >> > 0b9cfbf GPencil D+W Pie: Don't show editing operators when not in > >> editmode > >> > 586c589 Fix: Grease Pencil sculpting crashes when sculpting on laye
Re: [Bf-committers] Revisions for the final 2.78
Hi again, After some discussion with Rigify guys, requested 4 revisions in this area were also ported. Now i'm doing final touches to repositories, soon it'll be an AHOY. On Mon, Sep 26, 2016 at 10:54 AM, Sergey Sharybin wrote: > Hi, > > Main repository, checked up to 7c53260, following commits are ported: > > 4b891b4 Fix: Collada Importer did not import the Blender Profile > information correctly when multiple objects are bound to same armature. > This caused Bone tails to be placed wrong. > 7a259d8 Collada: Trying to get rif of some warning messages on linux > 36d0ea3 Collada: Trying to get rid of some warning messages on linux > bf2c2d4 Fix T49441: Grease Pencil - pie menu - brush name field crashes > blender > 776a854 Fix T49430: append scene with gamelogic broken. > 7c53260 Fix crash in own recent rB776a8548f03a049. > d84c55f Fix T49417: Cycles crash - can't use 5 Gigabyte Tile EXR texture > file > 2372e67 Cycles: Don't sum up memory usage of all devices together for the > stats > 4e3578f Cycles: Prevent crash in special cases when object has less slots > than mesh > 1b2b7cf Cycles: Fix overflow caused by wrong size calculation in > Mesh::add_undisplaced > 335ee5c Fix T49310: incorrect Cycles standalone normals with negative > scale. > 0b89b31 Cycles: Fix T49411: Multiscatter GGX with zero roughness when > Filter Glossy is enabled > > Addons repository, checked up to 434fa71, following commit was ported: > > 434fa71 Fix T49432: Archimesh crashes blender when room height info changed > > > On Sat, Sep 24, 2016 at 11:37 AM, Gaia Clary > wrote: > >> If possible please also add the following 3 fixes for Collada: >> >> 4b891b40c218ef5f45706cbc4636a5333469dd1c >> >> Fix for an issue with the new Blender collada profile. >> Tested with Linux Build Bot: >> https://builder.blender.org/builders/linux_glibc219_x86_64_ >> cmake/builds/289 >> >> 7a259d8422b9fd29fb9990269821fa64fc146a01 >> >> Fixes Linux compiler warnings regarding the collada module. >> Tested with Linux Build Bot: >> https://builder.blender.org/builders/linux_glibc219_x86_64_ >> cmake/builds/290) >> >> 36d0ea3123743e675333e90c712c69d666fe5710 >> >> Fixes another Linux compiler warning (sorry, amend did not work >> after push) >> Tested with Linux Build Bot: >> https://builder.blender.org/builders/linux_glibc219_x86_64_ >> cmake/builds/291 >> >> @whoever uses Collada: >> >> Please could you do a quick check if the commit 4b891b40 works for you? >> Export rigged model -> import back rigged model >> The imported skeleton should look similar to the exported skeleton (bone >> lengths). >> >> thanks, >> Gaia >> >> >> On 22.09.2016 12:39, Sergey Sharybin wrote: >> > Hi, >> > >> > We are working on getting 2.78 finally released. >> > >> > here are the lists of revisions ported to the branch since Release >> > Candidate 2. >> > >> > Blender: >> > >> > 3b6ce41 Fix memory leak in copy pose operator >> > 804f6bf fix Mac build with Xcode 8 >> > fe28e35 Fix T49179: Parts of mesh disappear with adaptive subdivision >> > e007552 Fix Py's IDs user mapping: do not consider proxy_from here. >> > a2a5ae5 Fix Py's IDs user mapping: do not consider ShapeKeys' from here. >> > a8ed914 Fix crash in some cases when deleting particle systems. >> > ddbbcbb Fix filebrowser not getting back to valid dir in Release builds. >> > 4b046c5 Fix T49372: Fresnel node: difference between 2.76 and 2.78 GLSL >> > output >> > 0552d58 Fix T49384: crash in tangent space calculation with NaN mesh >> > vertices. >> > 6c28d3b Fix T49245: Adaptive Subdivision with Auto Smooth causes weird >> mesh >> > appearance >> > 772dab9 Cycles: Fix typo that would sometimes result in subsurf modifier >> > being disabled >> > 76b CacheFile: make sure SpinLock is destroyed when exiting Blender. >> > cc9d0ef Lowercase includes for psapi.h and dbghelp.h windows includes. >> This >> > makes cross compilation a little less painful >> > 1f5cd85 Fix T49375: align rotation with snap target isn't toggleable in >> > edit mode. >> > f2da63c Fix T49386: Blender crashes when told to load an OCIO LUT that >> does >> > not exist >> > 2382d1c regression fix for 1346482d23f167fa57049128384246397fda8d27: >> The >> > length of leaf bones should always be set to the length of the smallest >> > bone. since the mentioned commit the importer did only recalculate the >> leaf >> > bone length when the 'fix leaf bones' option was also enabled. >> > 0b9cfbf GPencil D+W Pie: Don't show editing operators when not in >> editmode >> > 586c589 Fix: Grease Pencil sculpting crashes when sculpting on layers >> > without any strokes >> > c77da24 Fix non-finite normalization factor in certain cases >> > f339d5a [windows] add some helpers to make.bat to facilitate making >> release >> > builds. >> > 42c17cb Bring blender_release.cmake uptodate with the changes from D2227 >> > f915ee8 CMake: Fix copy-paste error >> > 8f28441 Cycles: Adaptive isolation >> > 940f360 Cycles: Fix update of subdivision meshes
Re: [Bf-committers] Revisions for the final 2.78: Rigify super_arm super_leg
Ok, have a more clear picture now. Let's port those changes over and call it all settled :) On Mon, Sep 26, 2016 at 12:37 PM, Lucio Rossi wrote: > Hi, > 1. No, we don't apply the same child_of twice. It think it depends on the > interaction between the single constraint and the IK chain. > > 2. The fix "corrects" the ik-fk snapping functions in the case hand or foot > ctrl bones have the child_of constraints on top of it. Unfortunately we > very recently noticed that, independently of the modifications we made, > adding the two child_of constraints on top of the IK ctrl bones messes up > with the apply visual transform. This is not, I repaeat, dependent on the > fix or on the previous code, it's just the interaction with the constraints > (IK and Child_of) and the transform functions. > > 3. By not-default I mean that when the user chooses a Pitchipoy rig the > arms and legs are marked as super_limb (arm) and super_limb (leg) same as > before the commits. If, and only if, the user wants to try the new > functionality he/she has to give, esplicitly, the super_arm or super_leg > property to the those bones. > > To sum up everything works as before the commits unless anyone wants to try > the new sub-rigs... > > 2016-09-26 12:16 GMT+02:00 Sergey Sharybin : > > > Hi, > > > > On Mon, Sep 26, 2016 at 11:46 AM, Lucio Rossi > > wrote: > > > > > About the double matrix multiplication IMO it depends on the fact that > > two > > > > > extra child_of constraints have been added to the IK controller bones. > > > Though it works together with the fk/ik snaps we're experiencing some > > other > > > issue in the apply visual transform we're trying to address. > > > > > > > That would be weird if same child_of matrix is applied twice. If it's two > > different child_of, then multiplying matrix by itself is not a correct > way > > to go to a proper space. > > > > You mention some other transform issues, so the fix is not even complete? > > > > > > > Finally, please consider that the two subrigs introduced are not (up to > > > now) default for arms and legs in the Pitchipoy rigs. > > > > > > > We've passed two release candidates and few hours from calling a final > > release. We have to be strict, meaning: the fix should either be fixing > > regression or be dead-simple for inclusion. Currently this doesn't seem > to > > be the case here (especially assuming even with the fixes applied there > are > > still other issues). > > > > Did i understand correctly, that the fixes are in the area which is now > > became default? In this case, how much unusable things are prior to the > > fix? How much it's unusable after the fixes (you mentioned some issues > > still)? > > > > 2016-09-26 10:46 GMT+02:00 Sergey Sharybin : > > > > > > > Hi, > > > > > > > > First two commtis are quite some code which does not address > regression > > > or > > > > trivial fix. So it is rather really risky to accept it now. > > > > > > > > The code itself is also weird: > > > > > > > > - You can clearly simplify the layer mask creation, and don't have it > > > > inlined as a list of False, False, False in multiple places > > > > - Multiple subsequent try/catch could be replaced with a single check > > > > whether `rigify_parameters` is in pbone. Using exceptions for that is > > > > totally wrong! > > > > - The goal is to have code pep8-compliant, and the new code is > clearly > > > not > > > > > > > > Remaining two commits is clearly less code, but they are still > > > suspicious. > > > > Never heard of getting square of a transform matrix (mat*mat), and > not > > > sure > > > > code was tested well enough after the change was done by all the > users. > > > > > > > > On Sat, Sep 24, 2016 at 3:16 PM, Lucio Rossi < > lucio.ross...@gmail.com> > > > > wrote: > > > > > > > > > Hi, > > > > > Adding to the last mail two commits that were missing... > > > > > > > > > > If it's possible include the following commits in the 2.78 release. > > > > > They add a new super_arm and super_leg rigs with switchable > child_of > > > > > parenting: > > > > > > > > > > rBAff11927e8e07a46c8199d9681af639be52b6b1af > > > > > > > > > > > > > > > rBAfecd5c9f566e0075e91d6d5830ccc0a622932736 > > > > > > > > > > And as said in the previous mail: > > > > > > > > > > rBA816df6cfe1054acffad2ec23edd63ae504ab325f > > > > > > > > > > rBA4ed120fafb157aeeb9fbdb072a0e75375d658e24 > > > > > > > > > > Lucio > > > > > ___ > > > > > Bf-committers mailing list > > > > > Bf-committers@blender.org > > > > > https://lists.blender.org/mailman/listinfo/bf-committers > > > > > > > > > > > > > > > > > > > > > -- > > > > With best regards, Sergey Sharybin > > > > ___ > > > > Bf-committers mailing list > > > > Bf-committers@blender.org > > > > https://lists.blender.org/mailman/listinfo/bf-committers > > > > > > > ___ > > > Bf-committers mailing list > > > Bf-committers
Re: [Bf-committers] Revisions for the final 2.78: Rigify super_arm super_leg
Hi, 1. No, we don't apply the same child_of twice. It think it depends on the interaction between the single constraint and the IK chain. 2. The fix "corrects" the ik-fk snapping functions in the case hand or foot ctrl bones have the child_of constraints on top of it. Unfortunately we very recently noticed that, independently of the modifications we made, adding the two child_of constraints on top of the IK ctrl bones messes up with the apply visual transform. This is not, I repaeat, dependent on the fix or on the previous code, it's just the interaction with the constraints (IK and Child_of) and the transform functions. 3. By not-default I mean that when the user chooses a Pitchipoy rig the arms and legs are marked as super_limb (arm) and super_limb (leg) same as before the commits. If, and only if, the user wants to try the new functionality he/she has to give, esplicitly, the super_arm or super_leg property to the those bones. To sum up everything works as before the commits unless anyone wants to try the new sub-rigs... 2016-09-26 12:16 GMT+02:00 Sergey Sharybin : > Hi, > > On Mon, Sep 26, 2016 at 11:46 AM, Lucio Rossi > wrote: > > > About the double matrix multiplication IMO it depends on the fact that > two > > > extra child_of constraints have been added to the IK controller bones. > > Though it works together with the fk/ik snaps we're experiencing some > other > > issue in the apply visual transform we're trying to address. > > > > That would be weird if same child_of matrix is applied twice. If it's two > different child_of, then multiplying matrix by itself is not a correct way > to go to a proper space. > > You mention some other transform issues, so the fix is not even complete? > > > > Finally, please consider that the two subrigs introduced are not (up to > > now) default for arms and legs in the Pitchipoy rigs. > > > > We've passed two release candidates and few hours from calling a final > release. We have to be strict, meaning: the fix should either be fixing > regression or be dead-simple for inclusion. Currently this doesn't seem to > be the case here (especially assuming even with the fixes applied there are > still other issues). > > Did i understand correctly, that the fixes are in the area which is now > became default? In this case, how much unusable things are prior to the > fix? How much it's unusable after the fixes (you mentioned some issues > still)? > > 2016-09-26 10:46 GMT+02:00 Sergey Sharybin : > > > > > Hi, > > > > > > First two commtis are quite some code which does not address regression > > or > > > trivial fix. So it is rather really risky to accept it now. > > > > > > The code itself is also weird: > > > > > > - You can clearly simplify the layer mask creation, and don't have it > > > inlined as a list of False, False, False in multiple places > > > - Multiple subsequent try/catch could be replaced with a single check > > > whether `rigify_parameters` is in pbone. Using exceptions for that is > > > totally wrong! > > > - The goal is to have code pep8-compliant, and the new code is clearly > > not > > > > > > Remaining two commits is clearly less code, but they are still > > suspicious. > > > Never heard of getting square of a transform matrix (mat*mat), and not > > sure > > > code was tested well enough after the change was done by all the users. > > > > > > On Sat, Sep 24, 2016 at 3:16 PM, Lucio Rossi > > > wrote: > > > > > > > Hi, > > > > Adding to the last mail two commits that were missing... > > > > > > > > If it's possible include the following commits in the 2.78 release. > > > > They add a new super_arm and super_leg rigs with switchable child_of > > > > parenting: > > > > > > > > rBAff11927e8e07a46c8199d9681af639be52b6b1af > > > > > > > > > > > > rBAfecd5c9f566e0075e91d6d5830ccc0a622932736 > > > > > > > > And as said in the previous mail: > > > > > > > > rBA816df6cfe1054acffad2ec23edd63ae504ab325f > > > > > > > > rBA4ed120fafb157aeeb9fbdb072a0e75375d658e24 > > > > > > > > Lucio > > > > ___ > > > > Bf-committers mailing list > > > > Bf-committers@blender.org > > > > https://lists.blender.org/mailman/listinfo/bf-committers > > > > > > > > > > > > > > > > -- > > > With best regards, Sergey Sharybin > > > ___ > > > Bf-committers mailing list > > > Bf-committers@blender.org > > > https://lists.blender.org/mailman/listinfo/bf-committers > > > > > ___ > > Bf-committers mailing list > > Bf-committers@blender.org > > https://lists.blender.org/mailman/listinfo/bf-committers > > > > > > -- > With best regards, Sergey Sharybin > ___ > Bf-committers mailing list > Bf-committers@blender.org > https://lists.blender.org/mailman/listinfo/bf-committers > ___ Bf-committers mailing list Bf-committers@blender.org https://lists.blender.org/mailman/listi
Re: [Bf-committers] Revisions for the final 2.78: Rigify super_arm super_leg
Hi, On Mon, Sep 26, 2016 at 11:46 AM, Lucio Rossi wrote: > About the double matrix multiplication IMO it depends on the fact that two > extra child_of constraints have been added to the IK controller bones. > Though it works together with the fk/ik snaps we're experiencing some other > issue in the apply visual transform we're trying to address. > That would be weird if same child_of matrix is applied twice. If it's two different child_of, then multiplying matrix by itself is not a correct way to go to a proper space. You mention some other transform issues, so the fix is not even complete? > Finally, please consider that the two subrigs introduced are not (up to > now) default for arms and legs in the Pitchipoy rigs. > We've passed two release candidates and few hours from calling a final release. We have to be strict, meaning: the fix should either be fixing regression or be dead-simple for inclusion. Currently this doesn't seem to be the case here (especially assuming even with the fixes applied there are still other issues). Did i understand correctly, that the fixes are in the area which is now became default? In this case, how much unusable things are prior to the fix? How much it's unusable after the fixes (you mentioned some issues still)? 2016-09-26 10:46 GMT+02:00 Sergey Sharybin : > > > Hi, > > > > First two commtis are quite some code which does not address regression > or > > trivial fix. So it is rather really risky to accept it now. > > > > The code itself is also weird: > > > > - You can clearly simplify the layer mask creation, and don't have it > > inlined as a list of False, False, False in multiple places > > - Multiple subsequent try/catch could be replaced with a single check > > whether `rigify_parameters` is in pbone. Using exceptions for that is > > totally wrong! > > - The goal is to have code pep8-compliant, and the new code is clearly > not > > > > Remaining two commits is clearly less code, but they are still > suspicious. > > Never heard of getting square of a transform matrix (mat*mat), and not > sure > > code was tested well enough after the change was done by all the users. > > > > On Sat, Sep 24, 2016 at 3:16 PM, Lucio Rossi > > wrote: > > > > > Hi, > > > Adding to the last mail two commits that were missing... > > > > > > If it's possible include the following commits in the 2.78 release. > > > They add a new super_arm and super_leg rigs with switchable child_of > > > parenting: > > > > > > rBAff11927e8e07a46c8199d9681af639be52b6b1af > > > > > > > > > rBAfecd5c9f566e0075e91d6d5830ccc0a622932736 > > > > > > And as said in the previous mail: > > > > > > rBA816df6cfe1054acffad2ec23edd63ae504ab325f > > > > > > rBA4ed120fafb157aeeb9fbdb072a0e75375d658e24 > > > > > > Lucio > > > ___ > > > Bf-committers mailing list > > > Bf-committers@blender.org > > > https://lists.blender.org/mailman/listinfo/bf-committers > > > > > > > > > > > -- > > With best regards, Sergey Sharybin > > ___ > > Bf-committers mailing list > > Bf-committers@blender.org > > https://lists.blender.org/mailman/listinfo/bf-committers > > > ___ > Bf-committers mailing list > Bf-committers@blender.org > https://lists.blender.org/mailman/listinfo/bf-committers > -- With best regards, Sergey Sharybin ___ Bf-committers mailing list Bf-committers@blender.org https://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Revisions for the final 2.78: Rigify super_arm super_leg
Hi Sergei, I totally agree with you about the flaws you're pointing out in the code. Nonetheless, consider that the "bulk" code of these sub-rigs is copy-pasted from super_limb.py, arm.py and leg.py and it is in Rigify since the beginning. Rigify is a tremendous add-on though it surely needs some extensive code cleaning (I'm really looking forward to talk about it). About the double matrix multiplication IMO it depends on the fact that two extra child_of constraints have been added to the IK controller bones. Though it works together with the fk/ik snaps we're experiencing some other issue in the apply visual transform we're trying to address. Finally, please consider that the two subrigs introduced are not (up to now) default for arms and legs in the Pitchipoy rigs. Thank you for your support Cheers Lucio 2016-09-26 10:46 GMT+02:00 Sergey Sharybin : > Hi, > > First two commtis are quite some code which does not address regression or > trivial fix. So it is rather really risky to accept it now. > > The code itself is also weird: > > - You can clearly simplify the layer mask creation, and don't have it > inlined as a list of False, False, False in multiple places > - Multiple subsequent try/catch could be replaced with a single check > whether `rigify_parameters` is in pbone. Using exceptions for that is > totally wrong! > - The goal is to have code pep8-compliant, and the new code is clearly not > > Remaining two commits is clearly less code, but they are still suspicious. > Never heard of getting square of a transform matrix (mat*mat), and not sure > code was tested well enough after the change was done by all the users. > > On Sat, Sep 24, 2016 at 3:16 PM, Lucio Rossi > wrote: > > > Hi, > > Adding to the last mail two commits that were missing... > > > > If it's possible include the following commits in the 2.78 release. > > They add a new super_arm and super_leg rigs with switchable child_of > > parenting: > > > > rBAff11927e8e07a46c8199d9681af639be52b6b1af > > > > > > rBAfecd5c9f566e0075e91d6d5830ccc0a622932736 > > > > And as said in the previous mail: > > > > rBA816df6cfe1054acffad2ec23edd63ae504ab325f > > > > rBA4ed120fafb157aeeb9fbdb072a0e75375d658e24 > > > > Lucio > > ___ > > Bf-committers mailing list > > Bf-committers@blender.org > > https://lists.blender.org/mailman/listinfo/bf-committers > > > > > > -- > With best regards, Sergey Sharybin > ___ > Bf-committers mailing list > Bf-committers@blender.org > https://lists.blender.org/mailman/listinfo/bf-committers > ___ Bf-committers mailing list Bf-committers@blender.org https://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Revisions for the final 2.78
Hi, Main repository, checked up to 7c53260, following commits are ported: 4b891b4 Fix: Collada Importer did not import the Blender Profile information correctly when multiple objects are bound to same armature. This caused Bone tails to be placed wrong. 7a259d8 Collada: Trying to get rif of some warning messages on linux 36d0ea3 Collada: Trying to get rid of some warning messages on linux bf2c2d4 Fix T49441: Grease Pencil - pie menu - brush name field crashes blender 776a854 Fix T49430: append scene with gamelogic broken. 7c53260 Fix crash in own recent rB776a8548f03a049. d84c55f Fix T49417: Cycles crash - can't use 5 Gigabyte Tile EXR texture file 2372e67 Cycles: Don't sum up memory usage of all devices together for the stats 4e3578f Cycles: Prevent crash in special cases when object has less slots than mesh 1b2b7cf Cycles: Fix overflow caused by wrong size calculation in Mesh::add_undisplaced 335ee5c Fix T49310: incorrect Cycles standalone normals with negative scale. 0b89b31 Cycles: Fix T49411: Multiscatter GGX with zero roughness when Filter Glossy is enabled Addons repository, checked up to 434fa71, following commit was ported: 434fa71 Fix T49432: Archimesh crashes blender when room height info changed On Sat, Sep 24, 2016 at 11:37 AM, Gaia Clary wrote: > If possible please also add the following 3 fixes for Collada: > > 4b891b40c218ef5f45706cbc4636a5333469dd1c > > Fix for an issue with the new Blender collada profile. > Tested with Linux Build Bot: > https://builder.blender.org/builders/linux_glibc219_x86_ > 64_cmake/builds/289 > > 7a259d8422b9fd29fb9990269821fa64fc146a01 > > Fixes Linux compiler warnings regarding the collada module. > Tested with Linux Build Bot: > https://builder.blender.org/builders/linux_glibc219_x86_ > 64_cmake/builds/290) > > 36d0ea3123743e675333e90c712c69d666fe5710 > > Fixes another Linux compiler warning (sorry, amend did not work > after push) > Tested with Linux Build Bot: > https://builder.blender.org/builders/linux_glibc219_x86_ > 64_cmake/builds/291 > > @whoever uses Collada: > > Please could you do a quick check if the commit 4b891b40 works for you? > Export rigged model -> import back rigged model > The imported skeleton should look similar to the exported skeleton (bone > lengths). > > thanks, > Gaia > > > On 22.09.2016 12:39, Sergey Sharybin wrote: > > Hi, > > > > We are working on getting 2.78 finally released. > > > > here are the lists of revisions ported to the branch since Release > > Candidate 2. > > > > Blender: > > > > 3b6ce41 Fix memory leak in copy pose operator > > 804f6bf fix Mac build with Xcode 8 > > fe28e35 Fix T49179: Parts of mesh disappear with adaptive subdivision > > e007552 Fix Py's IDs user mapping: do not consider proxy_from here. > > a2a5ae5 Fix Py's IDs user mapping: do not consider ShapeKeys' from here. > > a8ed914 Fix crash in some cases when deleting particle systems. > > ddbbcbb Fix filebrowser not getting back to valid dir in Release builds. > > 4b046c5 Fix T49372: Fresnel node: difference between 2.76 and 2.78 GLSL > > output > > 0552d58 Fix T49384: crash in tangent space calculation with NaN mesh > > vertices. > > 6c28d3b Fix T49245: Adaptive Subdivision with Auto Smooth causes weird > mesh > > appearance > > 772dab9 Cycles: Fix typo that would sometimes result in subsurf modifier > > being disabled > > 76b CacheFile: make sure SpinLock is destroyed when exiting Blender. > > cc9d0ef Lowercase includes for psapi.h and dbghelp.h windows includes. > This > > makes cross compilation a little less painful > > 1f5cd85 Fix T49375: align rotation with snap target isn't toggleable in > > edit mode. > > f2da63c Fix T49386: Blender crashes when told to load an OCIO LUT that > does > > not exist > > 2382d1c regression fix for 1346482d23f167fa57049128384246397fda8d27: The > > length of leaf bones should always be set to the length of the smallest > > bone. since the mentioned commit the importer did only recalculate the > leaf > > bone length when the 'fix leaf bones' option was also enabled. > > 0b9cfbf GPencil D+W Pie: Don't show editing operators when not in > editmode > > 586c589 Fix: Grease Pencil sculpting crashes when sculpting on layers > > without any strokes > > c77da24 Fix non-finite normalization factor in certain cases > > f339d5a [windows] add some helpers to make.bat to facilitate making > release > > builds. > > 42c17cb Bring blender_release.cmake uptodate with the changes from D2227 > > f915ee8 CMake: Fix copy-paste error > > 8f28441 Cycles: Adaptive isolation > > 940f360 Cycles: Fix update of subdivision meshes when global dice rates > > change > > 7994548 Cycles: Soft minimum for dice rates > > > > Addons: > > > > b9c3f23 Urgent fix: T49403 Fix for broken change tab category feature: > user > > preferences save was broken > > 0872705 Manual Reference: add links for object tab > > 959f9d2 Fix T49357: OBJ importer cannot deal with texture names with > spaces. > > 510cd44 Use relative impor
Re: [Bf-committers] Revisions for the final 2.78: Rigify super_arm super_leg
Hi, First two commtis are quite some code which does not address regression or trivial fix. So it is rather really risky to accept it now. The code itself is also weird: - You can clearly simplify the layer mask creation, and don't have it inlined as a list of False, False, False in multiple places - Multiple subsequent try/catch could be replaced with a single check whether `rigify_parameters` is in pbone. Using exceptions for that is totally wrong! - The goal is to have code pep8-compliant, and the new code is clearly not Remaining two commits is clearly less code, but they are still suspicious. Never heard of getting square of a transform matrix (mat*mat), and not sure code was tested well enough after the change was done by all the users. On Sat, Sep 24, 2016 at 3:16 PM, Lucio Rossi wrote: > Hi, > Adding to the last mail two commits that were missing... > > If it's possible include the following commits in the 2.78 release. > They add a new super_arm and super_leg rigs with switchable child_of > parenting: > > rBAff11927e8e07a46c8199d9681af639be52b6b1af > > > rBAfecd5c9f566e0075e91d6d5830ccc0a622932736 > > And as said in the previous mail: > > rBA816df6cfe1054acffad2ec23edd63ae504ab325f > > rBA4ed120fafb157aeeb9fbdb072a0e75375d658e24 > > Lucio > ___ > Bf-committers mailing list > Bf-committers@blender.org > https://lists.blender.org/mailman/listinfo/bf-committers > -- With best regards, Sergey Sharybin ___ Bf-committers mailing list Bf-committers@blender.org https://lists.blender.org/mailman/listinfo/bf-committers
[Bf-committers] Revisions for the final 2.78: Rigify super_arm super_leg
Hi, Adding to the last mail two commits that were missing... If it's possible include the following commits in the 2.78 release. They add a new super_arm and super_leg rigs with switchable child_of parenting: rBAff11927e8e07a46c8199d9681af639be52b6b1af rBAfecd5c9f566e0075e91d6d5830ccc0a622932736 And as said in the previous mail: rBA816df6cfe1054acffad2ec23edd63ae504ab325f rBA4ed120fafb157aeeb9fbdb072a0e75375d658e24 Lucio ___ Bf-committers mailing list Bf-committers@blender.org https://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Revisions for the final 2.78
If possible please also add the following 3 fixes for Collada: 4b891b40c218ef5f45706cbc4636a5333469dd1c Fix for an issue with the new Blender collada profile. Tested with Linux Build Bot: https://builder.blender.org/builders/linux_glibc219_x86_64_cmake/builds/289 7a259d8422b9fd29fb9990269821fa64fc146a01 Fixes Linux compiler warnings regarding the collada module. Tested with Linux Build Bot: https://builder.blender.org/builders/linux_glibc219_x86_64_cmake/builds/290) 36d0ea3123743e675333e90c712c69d666fe5710 Fixes another Linux compiler warning (sorry, amend did not work after push) Tested with Linux Build Bot: https://builder.blender.org/builders/linux_glibc219_x86_64_cmake/builds/291 @whoever uses Collada: Please could you do a quick check if the commit 4b891b40 works for you? Export rigged model -> import back rigged model The imported skeleton should look similar to the exported skeleton (bone lengths). thanks, Gaia On 22.09.2016 12:39, Sergey Sharybin wrote: > Hi, > > We are working on getting 2.78 finally released. > > here are the lists of revisions ported to the branch since Release > Candidate 2. > > Blender: > > 3b6ce41 Fix memory leak in copy pose operator > 804f6bf fix Mac build with Xcode 8 > fe28e35 Fix T49179: Parts of mesh disappear with adaptive subdivision > e007552 Fix Py's IDs user mapping: do not consider proxy_from here. > a2a5ae5 Fix Py's IDs user mapping: do not consider ShapeKeys' from here. > a8ed914 Fix crash in some cases when deleting particle systems. > ddbbcbb Fix filebrowser not getting back to valid dir in Release builds. > 4b046c5 Fix T49372: Fresnel node: difference between 2.76 and 2.78 GLSL > output > 0552d58 Fix T49384: crash in tangent space calculation with NaN mesh > vertices. > 6c28d3b Fix T49245: Adaptive Subdivision with Auto Smooth causes weird mesh > appearance > 772dab9 Cycles: Fix typo that would sometimes result in subsurf modifier > being disabled > 76b CacheFile: make sure SpinLock is destroyed when exiting Blender. > cc9d0ef Lowercase includes for psapi.h and dbghelp.h windows includes. This > makes cross compilation a little less painful > 1f5cd85 Fix T49375: align rotation with snap target isn't toggleable in > edit mode. > f2da63c Fix T49386: Blender crashes when told to load an OCIO LUT that does > not exist > 2382d1c regression fix for 1346482d23f167fa57049128384246397fda8d27: The > length of leaf bones should always be set to the length of the smallest > bone. since the mentioned commit the importer did only recalculate the leaf > bone length when the 'fix leaf bones' option was also enabled. > 0b9cfbf GPencil D+W Pie: Don't show editing operators when not in editmode > 586c589 Fix: Grease Pencil sculpting crashes when sculpting on layers > without any strokes > c77da24 Fix non-finite normalization factor in certain cases > f339d5a [windows] add some helpers to make.bat to facilitate making release > builds. > 42c17cb Bring blender_release.cmake uptodate with the changes from D2227 > f915ee8 CMake: Fix copy-paste error > 8f28441 Cycles: Adaptive isolation > 940f360 Cycles: Fix update of subdivision meshes when global dice rates > change > 7994548 Cycles: Soft minimum for dice rates > > Addons: > > b9c3f23 Urgent fix: T49403 Fix for broken change tab category feature: user > preferences save was broken > 0872705 Manual Reference: add links for object tab > 959f9d2 Fix T49357: OBJ importer cannot deal with texture names with spaces. > 510cd44 Use relative import > 5b7b6a5 Referance Manual: Fix links > ___ Bf-committers mailing list Bf-committers@blender.org https://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Revisions for the final 2.78
Hi, bf2c2d43ef3ff955560a6b22be04c8860d0beabe needs to be backported too Cheers, Joshua On Fri, Sep 23, 2016 at 1:17 AM, Sergey Sharybin wrote: > Hi, > > Ported that revision. > > Also ported ab09a80 from Bastien. > > On Thu, Sep 22, 2016 at 1:43 PM, Julian Eisel > wrote: > > > Hi, > > > > Would propose to also include 63b90851c (GPencil: Fix memory leak > > using stroke arrange OP). > > > > Cheers, > > - Julian - > > > > On 22 September 2016 at 12:39, Sergey Sharybin > > wrote: > > > Hi, > > > > > > We are working on getting 2.78 finally released. > > > > > > here are the lists of revisions ported to the branch since Release > > > Candidate 2. > > > > > > Blender: > > > > > > 3b6ce41 Fix memory leak in copy pose operator > > > 804f6bf fix Mac build with Xcode 8 > > > fe28e35 Fix T49179: Parts of mesh disappear with adaptive subdivision > > > e007552 Fix Py's IDs user mapping: do not consider proxy_from here. > > > a2a5ae5 Fix Py's IDs user mapping: do not consider ShapeKeys' from > here. > > > a8ed914 Fix crash in some cases when deleting particle systems. > > > ddbbcbb Fix filebrowser not getting back to valid dir in Release > builds. > > > 4b046c5 Fix T49372: Fresnel node: difference between 2.76 and 2.78 GLSL > > > output > > > 0552d58 Fix T49384: crash in tangent space calculation with NaN mesh > > > vertices. > > > 6c28d3b Fix T49245: Adaptive Subdivision with Auto Smooth causes weird > > mesh > > > appearance > > > 772dab9 Cycles: Fix typo that would sometimes result in subsurf > modifier > > > being disabled > > > 76b CacheFile: make sure SpinLock is destroyed when exiting > Blender. > > > cc9d0ef Lowercase includes for psapi.h and dbghelp.h windows includes. > > This > > > makes cross compilation a little less painful > > > 1f5cd85 Fix T49375: align rotation with snap target isn't toggleable in > > > edit mode. > > > f2da63c Fix T49386: Blender crashes when told to load an OCIO LUT that > > does > > > not exist > > > 2382d1c regression fix for 1346482d23f167fa57049128384246397fda8d27: > The > > > length of leaf bones should always be set to the length of the smallest > > > bone. since the mentioned commit the importer did only recalculate the > > leaf > > > bone length when the 'fix leaf bones' option was also enabled. > > > 0b9cfbf GPencil D+W Pie: Don't show editing operators when not in > > editmode > > > 586c589 Fix: Grease Pencil sculpting crashes when sculpting on layers > > > without any strokes > > > c77da24 Fix non-finite normalization factor in certain cases > > > f339d5a [windows] add some helpers to make.bat to facilitate making > > release > > > builds. > > > 42c17cb Bring blender_release.cmake uptodate with the changes from > D2227 > > > f915ee8 CMake: Fix copy-paste error > > > 8f28441 Cycles: Adaptive isolation > > > 940f360 Cycles: Fix update of subdivision meshes when global dice rates > > > change > > > 7994548 Cycles: Soft minimum for dice rates > > > > > > Addons: > > > > > > b9c3f23 Urgent fix: T49403 Fix for broken change tab category feature: > > user > > > preferences save was broken > > > 0872705 Manual Reference: add links for object tab > > > 959f9d2 Fix T49357: OBJ importer cannot deal with texture names with > > spaces. > > > 510cd44 Use relative import > > > 5b7b6a5 Referance Manual: Fix links > > > > > > -- > > > With best regards, Sergey Sharybin > > > ___ > > > Bf-committers mailing list > > > Bf-committers@blender.org > > > https://lists.blender.org/mailman/listinfo/bf-committers > > ___ > > Bf-committers mailing list > > Bf-committers@blender.org > > https://lists.blender.org/mailman/listinfo/bf-committers > > > > > > -- > With best regards, Sergey Sharybin > ___ > Bf-committers mailing list > Bf-committers@blender.org > https://lists.blender.org/mailman/listinfo/bf-committers > ___ Bf-committers mailing list Bf-committers@blender.org https://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Revisions for the final 2.78
Hi, Ported that revision. Also ported ab09a80 from Bastien. On Thu, Sep 22, 2016 at 1:43 PM, Julian Eisel wrote: > Hi, > > Would propose to also include 63b90851c (GPencil: Fix memory leak > using stroke arrange OP). > > Cheers, > - Julian - > > On 22 September 2016 at 12:39, Sergey Sharybin > wrote: > > Hi, > > > > We are working on getting 2.78 finally released. > > > > here are the lists of revisions ported to the branch since Release > > Candidate 2. > > > > Blender: > > > > 3b6ce41 Fix memory leak in copy pose operator > > 804f6bf fix Mac build with Xcode 8 > > fe28e35 Fix T49179: Parts of mesh disappear with adaptive subdivision > > e007552 Fix Py's IDs user mapping: do not consider proxy_from here. > > a2a5ae5 Fix Py's IDs user mapping: do not consider ShapeKeys' from here. > > a8ed914 Fix crash in some cases when deleting particle systems. > > ddbbcbb Fix filebrowser not getting back to valid dir in Release builds. > > 4b046c5 Fix T49372: Fresnel node: difference between 2.76 and 2.78 GLSL > > output > > 0552d58 Fix T49384: crash in tangent space calculation with NaN mesh > > vertices. > > 6c28d3b Fix T49245: Adaptive Subdivision with Auto Smooth causes weird > mesh > > appearance > > 772dab9 Cycles: Fix typo that would sometimes result in subsurf modifier > > being disabled > > 76b CacheFile: make sure SpinLock is destroyed when exiting Blender. > > cc9d0ef Lowercase includes for psapi.h and dbghelp.h windows includes. > This > > makes cross compilation a little less painful > > 1f5cd85 Fix T49375: align rotation with snap target isn't toggleable in > > edit mode. > > f2da63c Fix T49386: Blender crashes when told to load an OCIO LUT that > does > > not exist > > 2382d1c regression fix for 1346482d23f167fa57049128384246397fda8d27: The > > length of leaf bones should always be set to the length of the smallest > > bone. since the mentioned commit the importer did only recalculate the > leaf > > bone length when the 'fix leaf bones' option was also enabled. > > 0b9cfbf GPencil D+W Pie: Don't show editing operators when not in > editmode > > 586c589 Fix: Grease Pencil sculpting crashes when sculpting on layers > > without any strokes > > c77da24 Fix non-finite normalization factor in certain cases > > f339d5a [windows] add some helpers to make.bat to facilitate making > release > > builds. > > 42c17cb Bring blender_release.cmake uptodate with the changes from D2227 > > f915ee8 CMake: Fix copy-paste error > > 8f28441 Cycles: Adaptive isolation > > 940f360 Cycles: Fix update of subdivision meshes when global dice rates > > change > > 7994548 Cycles: Soft minimum for dice rates > > > > Addons: > > > > b9c3f23 Urgent fix: T49403 Fix for broken change tab category feature: > user > > preferences save was broken > > 0872705 Manual Reference: add links for object tab > > 959f9d2 Fix T49357: OBJ importer cannot deal with texture names with > spaces. > > 510cd44 Use relative import > > 5b7b6a5 Referance Manual: Fix links > > > > -- > > With best regards, Sergey Sharybin > > ___ > > Bf-committers mailing list > > Bf-committers@blender.org > > https://lists.blender.org/mailman/listinfo/bf-committers > ___ > Bf-committers mailing list > Bf-committers@blender.org > https://lists.blender.org/mailman/listinfo/bf-committers > -- With best regards, Sergey Sharybin ___ Bf-committers mailing list Bf-committers@blender.org https://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Revisions for the final 2.78
Hi, Would propose to also include 63b90851c (GPencil: Fix memory leak using stroke arrange OP). Cheers, - Julian - On 22 September 2016 at 12:39, Sergey Sharybin wrote: > Hi, > > We are working on getting 2.78 finally released. > > here are the lists of revisions ported to the branch since Release > Candidate 2. > > Blender: > > 3b6ce41 Fix memory leak in copy pose operator > 804f6bf fix Mac build with Xcode 8 > fe28e35 Fix T49179: Parts of mesh disappear with adaptive subdivision > e007552 Fix Py's IDs user mapping: do not consider proxy_from here. > a2a5ae5 Fix Py's IDs user mapping: do not consider ShapeKeys' from here. > a8ed914 Fix crash in some cases when deleting particle systems. > ddbbcbb Fix filebrowser not getting back to valid dir in Release builds. > 4b046c5 Fix T49372: Fresnel node: difference between 2.76 and 2.78 GLSL > output > 0552d58 Fix T49384: crash in tangent space calculation with NaN mesh > vertices. > 6c28d3b Fix T49245: Adaptive Subdivision with Auto Smooth causes weird mesh > appearance > 772dab9 Cycles: Fix typo that would sometimes result in subsurf modifier > being disabled > 76b CacheFile: make sure SpinLock is destroyed when exiting Blender. > cc9d0ef Lowercase includes for psapi.h and dbghelp.h windows includes. This > makes cross compilation a little less painful > 1f5cd85 Fix T49375: align rotation with snap target isn't toggleable in > edit mode. > f2da63c Fix T49386: Blender crashes when told to load an OCIO LUT that does > not exist > 2382d1c regression fix for 1346482d23f167fa57049128384246397fda8d27: The > length of leaf bones should always be set to the length of the smallest > bone. since the mentioned commit the importer did only recalculate the leaf > bone length when the 'fix leaf bones' option was also enabled. > 0b9cfbf GPencil D+W Pie: Don't show editing operators when not in editmode > 586c589 Fix: Grease Pencil sculpting crashes when sculpting on layers > without any strokes > c77da24 Fix non-finite normalization factor in certain cases > f339d5a [windows] add some helpers to make.bat to facilitate making release > builds. > 42c17cb Bring blender_release.cmake uptodate with the changes from D2227 > f915ee8 CMake: Fix copy-paste error > 8f28441 Cycles: Adaptive isolation > 940f360 Cycles: Fix update of subdivision meshes when global dice rates > change > 7994548 Cycles: Soft minimum for dice rates > > Addons: > > b9c3f23 Urgent fix: T49403 Fix for broken change tab category feature: user > preferences save was broken > 0872705 Manual Reference: add links for object tab > 959f9d2 Fix T49357: OBJ importer cannot deal with texture names with spaces. > 510cd44 Use relative import > 5b7b6a5 Referance Manual: Fix links > > -- > With best regards, Sergey Sharybin > ___ > Bf-committers mailing list > Bf-committers@blender.org > https://lists.blender.org/mailman/listinfo/bf-committers ___ Bf-committers mailing list Bf-committers@blender.org https://lists.blender.org/mailman/listinfo/bf-committers
[Bf-committers] Revisions for the final 2.78
Hi, We are working on getting 2.78 finally released. here are the lists of revisions ported to the branch since Release Candidate 2. Blender: 3b6ce41 Fix memory leak in copy pose operator 804f6bf fix Mac build with Xcode 8 fe28e35 Fix T49179: Parts of mesh disappear with adaptive subdivision e007552 Fix Py's IDs user mapping: do not consider proxy_from here. a2a5ae5 Fix Py's IDs user mapping: do not consider ShapeKeys' from here. a8ed914 Fix crash in some cases when deleting particle systems. ddbbcbb Fix filebrowser not getting back to valid dir in Release builds. 4b046c5 Fix T49372: Fresnel node: difference between 2.76 and 2.78 GLSL output 0552d58 Fix T49384: crash in tangent space calculation with NaN mesh vertices. 6c28d3b Fix T49245: Adaptive Subdivision with Auto Smooth causes weird mesh appearance 772dab9 Cycles: Fix typo that would sometimes result in subsurf modifier being disabled 76b CacheFile: make sure SpinLock is destroyed when exiting Blender. cc9d0ef Lowercase includes for psapi.h and dbghelp.h windows includes. This makes cross compilation a little less painful 1f5cd85 Fix T49375: align rotation with snap target isn't toggleable in edit mode. f2da63c Fix T49386: Blender crashes when told to load an OCIO LUT that does not exist 2382d1c regression fix for 1346482d23f167fa57049128384246397fda8d27: The length of leaf bones should always be set to the length of the smallest bone. since the mentioned commit the importer did only recalculate the leaf bone length when the 'fix leaf bones' option was also enabled. 0b9cfbf GPencil D+W Pie: Don't show editing operators when not in editmode 586c589 Fix: Grease Pencil sculpting crashes when sculpting on layers without any strokes c77da24 Fix non-finite normalization factor in certain cases f339d5a [windows] add some helpers to make.bat to facilitate making release builds. 42c17cb Bring blender_release.cmake uptodate with the changes from D2227 f915ee8 CMake: Fix copy-paste error 8f28441 Cycles: Adaptive isolation 940f360 Cycles: Fix update of subdivision meshes when global dice rates change 7994548 Cycles: Soft minimum for dice rates Addons: b9c3f23 Urgent fix: T49403 Fix for broken change tab category feature: user preferences save was broken 0872705 Manual Reference: add links for object tab 959f9d2 Fix T49357: OBJ importer cannot deal with texture names with spaces. 510cd44 Use relative import 5b7b6a5 Referance Manual: Fix links -- With best regards, Sergey Sharybin ___ Bf-committers mailing list Bf-committers@blender.org https://lists.blender.org/mailman/listinfo/bf-committers
