Re: [Bf-committers] Revisions for the final 2.78: Rigify super_arm super_leg

Hello, Following the suggestions of Sergey I committed a new fix to the super_leg and super_arm sub-rigs. We got rid of the Child_of constraints altogether using copy_transforms on an MCH-socket bone and parenting the ik ctrls to it. This simplifies the code and solves both the problems we had: -

Re: [Bf-committers] Revisions for the final 2.78: Rigify super_arm super_leg

Ok, have a more clear picture now. Let's port those changes over and call it all settled :) On Mon, Sep 26, 2016 at 12:37 PM, Lucio Rossi wrote: > Hi, > 1. No, we don't apply the same child_of twice. It think it depends on the > interaction between the single

Re: [Bf-committers] Revisions for the final 2.78: Rigify super_arm super_leg

Hi, 1. No, we don't apply the same child_of twice. It think it depends on the interaction between the single constraint and the IK chain. 2. The fix "corrects" the ik-fk snapping functions in the case hand or foot ctrl bones have the child_of constraints on top of it. Unfortunately we very

Re: [Bf-committers] Revisions for the final 2.78: Rigify super_arm super_leg

Hi, On Mon, Sep 26, 2016 at 11:46 AM, Lucio Rossi wrote: > About the double matrix multiplication IMO it depends on the fact that two > extra child_of constraints have been added to the IK controller bones. > Though it works together with the fk/ik snaps we're

Re: [Bf-committers] Revisions for the final 2.78: Rigify super_arm super_leg

Hi Sergei, I totally agree with you about the flaws you're pointing out in the code. Nonetheless, consider that the "bulk" code of these sub-rigs is copy-pasted from super_limb.py, arm.py and leg.py and it is in Rigify since the beginning. Rigify is a tremendous add-on though it surely needs some

Re: [Bf-committers] Revisions for the final 2.78: Rigify super_arm super_leg

Hi, First two commtis are quite some code which does not address regression or trivial fix. So it is rather really risky to accept it now. The code itself is also weird: - You can clearly simplify the layer mask creation, and don't have it inlined as a list of False, False, False in