Revision: 22804
http://sourceforge.net/p/bibdesk/svn/22804
Author: hofman
Date: 2018-10-11 14:35:31 +0000 (Thu, 11 Oct 2018)
Log Message:
-----------
No need to cache base path for external file group, the path is always resolved
Modified Paths:
--------------
trunk/bibdesk/BDSKURLGroup.h
trunk/bibdesk/BDSKURLGroup.m
Modified: trunk/bibdesk/BDSKURLGroup.h
===================================================================
--- trunk/bibdesk/BDSKURLGroup.h 2018-10-11 14:31:23 UTC (rev 22803)
+++ trunk/bibdesk/BDSKURLGroup.h 2018-10-11 14:35:31 UTC (rev 22804)
@@ -44,7 +44,6 @@
{
NSURL *URL;
NSString *filePath;
- NSString *basePath;
BOOL isRetrieving;
BOOL failedDownload;
NSURLDownload *URLDownload;
Modified: trunk/bibdesk/BDSKURLGroup.m
===================================================================
--- trunk/bibdesk/BDSKURLGroup.m 2018-10-11 14:31:23 UTC (rev 22803)
+++ trunk/bibdesk/BDSKURLGroup.m 2018-10-11 14:35:31 UTC (rev 22804)
@@ -124,7 +124,6 @@
BDSKENSURE_MAIN_THREAD( [self stopRetrieving]; );
BDSKDESTROY(URL);
BDSKDESTROY(filePath);
- BDSKDESTROY(basePath);
[super dealloc];
}
@@ -178,8 +177,6 @@
{
[filePath autorelease];
filePath = [path copy];
- [basePath release];
- basePath = [[[path stringByStandardizingPath]
stringByDeletingLastPathComponent] retain];
}
- (void)downloadDidFinish:(NSURLDownload *)download
@@ -255,7 +252,7 @@
- (NSURL *)fileURL { return [NSURL fileURLWithPath:filePath]; }
-- (NSString *)basePath { return basePath; }
+- (NSString *)basePath { return [filePath stringByDeletingLastPathComponent]; }
- (NSString *)fileName { return filePath; }
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Bibdesk-commit mailing list
Bibdesk-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
