Re: [Bioc-devel] Interpreting BiocCheck output

2022-10-07 Thread Henrik Bengtsson
I'm throwing in another 1 cent. I agree that utils::globalVariables() is risky; since it goes in the root of the package code, it applies to *all* functions in the package, which is a bit too broad of a stroke for my taste. The way I deal with false globals from non-standard evaluation (NSE), is

Re: [Bioc-devel] Interpreting BiocCheck output

2022-10-07 Thread Martin Morgan
Just my two cents, but I don’t think using `globalVariables()` is a good idea in a package – it’s too easy to say that R should ignore a variable that it should not. In the context of dplyr, the alternative is to `importFrom dplyr .data` or to use ‘standard’ evaluation, depending on

Re: [Bioc-devel] Interpreting BiocCheck output

2022-10-07 Thread Marcel Ramos
Hi Giulia, Thanks for sharing. I took a look at https://github.com/calabrialab/ISAnalytics and I'm glad you resolved the issue. Just a reminder, you can also use `utils::globalVariables('.')` in your package for functions that use `'.'` (and other symbols) as a variable, e.g. in `purrr::pmap`.