Re: [Bioc-devel] Questions about some checks in the latest BiocCheck

2018-11-29 Thread Michael Lawrence
On Thu, Nov 29, 2018 at 8:32 AM Kasper Daniel Hansen wrote: > > First, the issue with using class() is that the return is a vector possibly > with >1 element. This _does_ happen. This is why is() etc is much better,. > And of course it also considers S4 inheritance. > Second, why do you need

Re: [Bioc-devel] Questions about some checks in the latest BiocCheck

2018-11-29 Thread Kasper Daniel Hansen
First, the issue with using class() is that the return is a vector possibly with >1 element. This _does_ happen. This is why is() etc is much better,. Second, why do you need case insensitivity when testing for class. That makes NO sense to me. You should be testing for a specific (collection)

Re: [Bioc-devel] Questions about some checks in the latest BiocCheck

2018-11-28 Thread Vincent Carey
Can you provide the repo for your package in development? These BiocCheck issues are important and should be resolved at your end. We can give some advice on how to get better results with BiocCheck. On Wed, Nov 28, 2018 at 10:34 AM Casper Peters wrote: > So in the package I'm developing, I

[Bioc-devel] Questions about some checks in the latest BiocCheck

2018-11-28 Thread Casper Peters
So in the package I'm developing, I have a few specific use cases that make BiocCheck not so happy. 1: ``` * WARNING: Avoid class()== or class()!= ; use is() or !is() ``` So my first problem arises with checking the classes of objects. I want the interface to be such that I can allow for