Re: [Bioc-devel] Adding a lengths() method to List class

2015-10-16 Thread Hervé Pagès
On 10/15/2015 11:24 AM, Michael Lawrence wrote: Btw, a subtle issue here is that elementLengths currently calls NROW(), not length(), and code might be relying on DataFrameList returning row counts. That behavior has proven convenient, so it would be nice not to lose it. I guess nrow() already

Re: [Bioc-devel] Adding a lengths() method to List class

2015-10-15 Thread Michael Lawrence
Btw, a subtle issue here is that elementLengths currently calls NROW(), not length(), and code might be relying on DataFrameList returning row counts. That behavior has proven convenient, so it would be nice not to lose it. I guess nrow() already does that, but anyway, lengths() is not the

Re: [Bioc-devel] Adding a lengths() method to List class

2015-10-02 Thread Peter Hickey
Thanks, Michael! On Fri, 2 Oct 2015 at 13:54 Michael Lawrence wrote: > Change was made. Should dispatch to length and [[ methods. > > On Wed, Sep 30, 2015 at 9:37 PM, Hervé Pagès wrote: > >> On 09/30/2015 05:28 PM, Michael Lawrence wrote: >> >>>

Re: [Bioc-devel] Adding a lengths() method to List class

2015-10-01 Thread Michael Lawrence
Change was made. Should dispatch to length and [[ methods. On Wed, Sep 30, 2015 at 9:37 PM, Hervé Pagès wrote: > On 09/30/2015 05:28 PM, Michael Lawrence wrote: > >> It wasn't a conscious choice, but it would slow things down a bit. Not >> by much though, since we're

Re: [Bioc-devel] Adding a lengths() method to List class

2015-09-30 Thread Hervé Pagès
Hi Michael, I was expecting this to just work: base::lengths(IntegerList(1:4, 1:6)) but it doesn't: Error in base::lengths(IntegerList(1:4, 1:6)) : 'x' must be a list or atomic vector The man page says: This function loops over ‘x’ and returns a compatible vector

Re: [Bioc-devel] Adding a lengths() method to List class

2015-09-30 Thread Michael Lawrence
It wasn't a conscious choice, but it would slow things down a bit. Not by much though, since we're already attempting dispatch on length(). I can make the change. On Wed, Sep 30, 2015 at 1:33 PM, Hervé Pagès wrote: > Hi Michael, > > I was expecting this to just work: > >

Re: [Bioc-devel] Adding a lengths() method to List class

2015-09-30 Thread Hervé Pagès
On 09/30/2015 05:28 PM, Michael Lawrence wrote: It wasn't a conscious choice, but it would slow things down a bit. Not by much though, since we're already attempting dispatch on length(). I can make the change. That would be great. Thanks Michael! H. On Wed, Sep 30, 2015 at 1:33 PM, Hervé

Re: [Bioc-devel] Adding a lengths() method to List class

2015-09-29 Thread Cook, Malcolm
Bioc-devel] Adding a lengths() method to List class The plan is to move to only having lengths(). On Tue, Sep 29, 2015 at 9:02 AM, Cook, Malcolm <m...@stowers.org<mailto:m...@stowers.org>> wrote: Dumb question (?) follows in line: > That is the plan. Note that we already

Re: [Bioc-devel] Adding a lengths() method to List class

2015-09-29 Thread Cook, Malcolm
Dumb question (?) follows in line: > That is the plan. Note that we already have elementLengths() that serves the > same purpose. It was the direct inspiration for lengths(). Why have both? > > On Mon, Sep 28, 2015 at 9:41 PM, Peter Hickey > wrote: > > > The

Re: [Bioc-devel] Adding a lengths() method to List class

2015-09-29 Thread Michael Lawrence
The plan is to move to only having lengths(). On Tue, Sep 29, 2015 at 9:02 AM, Cook, Malcolm wrote: > Dumb question (?) follows in line: > > > That is the plan. Note that we already have elementLengths() that serves > the > > same purpose. It was the direct inspiration for

Re: [Bioc-devel] Adding a lengths() method to List class

2015-09-28 Thread Michael Lawrence
That is the plan. Note that we already have elementLengths() that serves the same purpose. It was the direct inspiration for lengths(). On Mon, Sep 28, 2015 at 9:41 PM, Peter Hickey wrote: > The lengths() function was added in R 3.2 to "get the length of each > element