Re: [Bioc-devel] return value of BiocManager::install()

2019-01-22 Thread Martin Morgan
require is expensive and detach() fraught with subtle difficulties. Using withCallingHandlers is more elegant than capture.output(). See and direct further commentary to the issue. Martin On 1/22/19, 4:41 AM, "Bioc-devel on behalf of Levi Waldron" wrote: BTW I just noticed the

Re: [Bioc-devel] return value of BiocManager::install()

2019-01-22 Thread Levi Waldron
BTW I just noticed the alternative approach of searching through the warnings, used at https://github.com/Bioconductor/bioc_docker/blob/5be6d37ded4f97995640cbb3a7d201165234b1e4/src/core/install.R.in#L42 : if (!is.null(warnings())) { w <- capture.output(warnings()) if (length(grep("is not

[Bioc-devel] return value of BiocManager::install()

2019-01-22 Thread Levi Waldron
I opened an issue on BiocManager ( https://github.com/Bioconductor/BiocManager/issues/39) somewhat related to Sean's recent post, about what BiocManager::install() should return, and it occurs to me that I should mention it here too for feedback: > Having `BiocManager::install()` return the