Re: [Bioc-devel] Changes in AnnotationDbi

2015-06-09 Thread Simon Anders
Hi My two cents: On 04/06/15 19:50, James W. MacDonald wrote: In other words, for me it is a common practice to do something like this: fit - lmFit(eset, design) fit2 - eBayes(fit) gns - select(chippackage, featureNames(eset), c(ENTREZID,SYMBOL)) gns - gns[!duplicated(gns[,1]),] fit2$genes -

Re: [Bioc-devel] Changes in AnnotationDbi

2015-06-09 Thread Simon Anders
Hi Martin On 09/06/15 15:35, Martin Morgan wrote: In case you missed it in Marc's reply, and acknowledging that this is different from your suggestion, there is mapIds() for doing this on a single column basis, which is the common use case where one doesn't care too much about multiple mapping

Re: [Bioc-devel] Changes in AnnotationDbi

2015-06-09 Thread Martin Morgan
On 06/09/2015 02:52 AM, Simon Anders wrote: Hi My two cents: On 04/06/15 19:50, James W. MacDonald wrote: In other words, for me it is a common practice to do something like this: fit - lmFit(eset, design) fit2 - eBayes(fit) gns - select(chippackage, featureNames(eset), c(ENTREZID,SYMBOL))

Re: [Bioc-devel] Changes in AnnotationDbi

2015-06-08 Thread James W. MacDonald
Thanks Marc! On Mon, Jun 8, 2015 at 3:12 PM, Marc Carlson mcarl...@fredhutch.org wrote: OK Jim, I will put very simple messages in (one liners) that will simply state whether the relationship between keys and the requested columns was 1:1, 1:many, many:1, or many:many. Hopefully this

Re: [Bioc-devel] Changes in AnnotationDbi

2015-06-08 Thread Marc Carlson
OK Jim, I will put very simple messages in (one liners) that will simply state whether the relationship between keys and the requested columns was 1:1, 1:many, many:1, or many:many. Hopefully this will represent an acceptable compromise. Marc On 06/05/2015 08:37 AM, James W. MacDonald

Re: [Bioc-devel] Changes in AnnotationDbi

2015-06-04 Thread Marc Carlson
Hi Jim, I do agree that the warning was protective for that (this is why I put it there). But it was also annoying for many and a source of some confusion because when people see a warning() they think that something has gone wrong with the code that was just run. And in this case the

Re: [Bioc-devel] Changes in AnnotationDbi

2015-06-04 Thread Vincent Carey
On Thu, Jun 4, 2015 at 1:50 PM, James W. MacDonald jmac...@uw.edu wrote: In the last release, the warning message from select() telling people that their results include one-to-many mappings was removed. While some may find this warning annoying, I think silently returning something unexpected