Re: [Bioc-devel] Extending biovizBase and ggbio packages

Awesome. That's great (and fast) work. I will add you to the author list of both packages. Thanks a lot for your contribution, Michael On Wed, Dec 16, 2015 at 6:15 AM, Rainer Johannes wrote: > OK, I have cleared the code duplications and pushed to my biovizBase and >

Re: [Bioc-devel] Extending biovizBase and ggbio packages

Great, thanks for this valuable contribution. I made some comments on the commits. The biggest issue is that I think there is a lot of code duplication between the EnsDb and TxDb methods. We should try hard to reduce this. Michael On Tue, Dec 15, 2015 at 1:37 AM, Rainer Johannes

Re: [Bioc-devel] Extending biovizBase and ggbio packages

Thanks for the comments! I’ll make some changes and push a “cleaner” version once I’m done. Indeed, I have to reduce code duplications. I could also use the same or similar code than for TxDb, but I wanted to make as much use of the EnsDb filter system as possible to reduce processing time. jo

Re: [Bioc-devel] Extending biovizBase and ggbio packages

Rainer, Pull requests to the git mirrors will be closed automatically because they are read only mirrors. However you can still fork the mirror yourself and commit your changes to your fork to make them easy for Michael and Tengfei to review. Jim On Mon, Dec 14, 2015 at 9:03 AM, Rainer Johannes