Re: [Bioc-devel] How to speed up GRange comparision

2020-01-30 Thread Pages, Herve
On 1/30/20 13:17, Michael Lawrence wrote: > That sucks. It was broken since it was added in 2017... now fixed. Unfortunately these things tend to happen to stuff that doesn't have examples or unit tests. Thanks for the fix! H. ___

Re: [Bioc-devel] How to speed up GRange comparision

2020-01-30 Thread Michael Lawrence via Bioc-devel
That sucks. It was broken since it was added in 2017... now fixed. On Thu, Jan 30, 2020 at 11:20 AM Pages, Herve wrote: > > On 1/30/20 11:10, Hervé Pagès wrote: > > Yes poverlaps() is a good option, as mentioned earlier. > > Well actually not. Looks like it's broken: > > >

Re: [Bioc-devel] How to speed up GRange comparision

2020-01-30 Thread Pages, Herve
On 1/30/20 11:10, Hervé Pagès wrote: > Yes poverlaps() is a good option, as mentioned earlier. Well actually not. Looks like it's broken: > poverlaps(GRanges("chr1:11-15"), GRanges("chr1:16-20")) Error in isSingleNumber(minoverlap) : object 'minoverlaps' not found H.

Re: [Bioc-devel] How to speed up GRange comparision

2020-01-30 Thread Pages, Herve
Yes poverlaps() is a good option, as mentioned earlier. I was just commenting about doing something like: out <- vector("numeric", length(x)) out[(which(foo(x))] <- 1 when you can just do: out <- foo(x) H. On 1/30/20 10:56, Michael Lawrence wrote: > What happened to just

Re: [Bioc-devel] How to speed up GRange comparision

2020-01-30 Thread Michael Lawrence via Bioc-devel
What happened to just poverlaps()? On Thu, Jan 30, 2020 at 10:34 AM Pages, Herve wrote: > > On 1/29/20 23:31, web working wrote: > > Hi Herve, > > > > Thank you for your answer. pcompare works fine for me. Here my solution: > > > > query <- GRanges(rep("chr1", 4), IRanges(c(1, 5, 9, 20), c(2, 6,

Re: [Bioc-devel] How to speed up GRange comparision

2020-01-30 Thread Pages, Herve
On 1/29/20 23:31, web working wrote: > Hi Herve, > > Thank you for your answer. pcompare works fine for me. Here my solution: > > query <- GRanges(rep("chr1", 4), IRanges(c(1, 5, 9, 20), c(2, 6, 10, 22))) > subject <- GRanges(rep("chr1",4), IRanges(c(3, 1, 1, 15), c(4, 2, 2, 21))) > out <-

[Bioc-devel] Version when submitting to Bioconductor

2020-01-30 Thread Roman Hillje via Bioc-devel
Hi everyone, I’d like to submit a package soon but am unsure about the versioning. I’m expecting there to be some revisions to the code which will then later require that I bump the version count to trigger the rebuild. Currently, I’m at v1.1.1 (GitHub). If/when the package is accepted, I’d