Re: [Bioc-devel] Incorrect warning about failing package built

2024-02-01 Thread Griss Johannes
Dear Hervé, Thanks a lot for the explanation and clarification! Issue should be fixed by now. Kind regards, Johannes Am 2024-02-02 01:37, schrieb Hervé Pagès: > Just to clarify: we build the vignettes on all platforms, via 'R CMD > build'. However when a package contains more than one

Re: [Bioc-devel] Incorrect warning about failing package built

2024-02-01 Thread Hervé Pagès
Just to clarify: we build the vignettes on all platforms, via 'R CMD build'. However when a package contains more than one vignette like here, keep in mind that 'R CMD build' evaluates them all in the same R session. This "feature" can help a vignette succeed even if it's broken. For example

Re: [Bioc-devel] Incorrect warning about failing package built

2024-02-01 Thread Johannes Griss
Hi, Thanks a lot for the quick reply! Vignette is already fixed and committed. Kind regards, Johannes On 01.02.24 22:24, Martin Grigorov wrote: Hi, On Thu, 1 Feb 2024 at 23:05, Jennifer Wokaty mailto:jennifer.wok...@sph.cuny.edu>> wrote: Hi Johannes, Looking at R CMD Check on

Re: [Bioc-devel] Incorrect warning about failing package built

2024-02-01 Thread Martin Grigorov
Hi, On Thu, 1 Feb 2024 at 23:05, Jennifer Wokaty wrote: > Hi Johannes, > > Looking at R CMD Check on devel, it looks like you're missing a > `library(ReactomeGSA)` in reanalysing-public-data.Rmd, which is why it > doesn't find the function `get_public_species()`. We only build the > vignettes

Re: [Bioc-devel] Incorrect warning about failing package built

2024-02-01 Thread Jennifer Wokaty
Hi Johannes, Looking at R CMD Check on devel, it looks like you're missing a `library(ReactomeGSA)` in reanalysing-public-data.Rmd, which is why it doesn't find the function `get_public_species()`. We only build the vignettes on the Linux builders, which this error is only caught there.

[Bioc-devel] Incorrect warning about failing package built

2024-02-01 Thread Johannes Griss
Hello, I just received a second warning the our package ReactomeGSA is failing in both release and devel on all platforms. Quickly checking the respective reports shows that this is not the case: https://bioconductor.org/checkResults/release/bioc-LATEST/ReactomeGSA/