Re: [Bioc-devel] merging DFrames

2020-10-21 Thread Laurent Gatto
: [Bioc-devel] merging DFrames Laurent, Thanks for bringing this up and offering to help. Yes, please raise an issue. There's an opportunity to implement faster matching than base::merge(), using stuff like matchIntegerQuads(), findMatches(), and grouping(). grouping() can be really fast

Re: [Bioc-devel] merging DFrames

2020-10-21 Thread Michael Lawrence via Bioc-devel
Laurent, Thanks for bringing this up and offering to help. Yes, please raise an issue. There's an opportunity to implement faster matching than base::merge(), using stuff like matchIntegerQuads(), findMatches(), and grouping(). grouping() can be really fast for character vectors, since it takes

Re: [Bioc-devel] merging DFrames

2020-10-21 Thread Pages, Herve
Hi Laurent, I think the current implementation was just an expedient to have something that works (in most cases). I don't know if a proper implementation that doesn't go thru data.frame is on the TODO list. Michael? I suggest you open an issue on GitHub under S4Vectors. Cheers, H. PS: Note

[Bioc-devel] merging DFrames

2020-10-21 Thread Laurent Gatto
When merging DFrame instances, the *List types are lost: The following two instances have NumericList columns (y and z) d1 <- DataFrame(x = letters[1:3], y = List(list(1, 1:2, 1:3))) d2 <- DataFrame(x = letters[1:3], z = List(list(1:3, 1:2, 1))) d1 ## DataFrame with 3 rows and 2 columns ##