Re: [Bioc-devel] msPurity check failure on Windows

2016-10-13 Thread Thomas Lawson
Hi Martin, That's great thanks! After running the following code in my unit test: - msmsPths <- list.files(system.file("extdata", "lcms", "mzML", package="msPurityData"), full.names =

Re: [Bioc-devel] RMassBank (almost) builds ...

2016-10-13 Thread Stravs, Michael
Hi, Is there any compelling reason why one wouldn't want to upgrade BioC to Java 8? One way or another this update will have to come in the near future anyway, so causing disruption by downgrading rcdk now, then upgrading it again in the future seems unnecessary... From: Schymanski, Emma

Re: [Bioc-devel] RMassBank (almost) builds ...

2016-10-13 Thread Egon Willighagen
Hi all, including all BioC developers, On Thu, Oct 13, 2016 at 4:32 PM, Zach Charlop-Powers wrote: > When I initially submitted to CRAN I did NOT check the Java version and > therefore users would be able to use Java 7 and would encounter errors only > when using

Re: [Bioc-devel] RMassBank (almost) builds ...

2016-10-13 Thread Egon Willighagen
cc: Rajarshi Hi Emma, On Wed, Oct 12, 2016 at 10:18 PM, Schymanski, Emma wrote: > Thanks to Laurent and Jo for updating MSnbase and thanks to the BioC team for > getting the email updates working again! The good news is that RMassBank now > builds on most

Re: [Bioc-devel] RMassBank (almost) builds ...

2016-10-13 Thread Hervé Pagès
Hi Emma, On 10/12/2016 01:18 PM, Schymanski, Emma wrote: Hi all, Thanks to Laurent and Jo for updating MSnbase and thanks to the BioC team for getting the email updates working again! The good news is that RMassBank now builds on most platforms... but ... 1) we have a build error due to a

[Bioc-devel] msPurity check failure on Windows

2016-10-13 Thread Thomas Lawson
Hi all, Thanks for everybody who worked to get mzR to build and pass on Windows. The package msPurity, which relies on mzR, was building and passing all checks after the mzR updates but then unfortunately started failing on a unit test on the Windows server. The problem seems to be from when I

Re: [Bioc-devel] msPurity check failure on Windows

2016-10-13 Thread Martin Morgan
On 10/13/2016 08:17 AM, Thomas Lawson wrote: Hi all, Thanks for everybody who worked to get mzR to build and pass on Windows. The package msPurity, which relies on mzR, was building and passing all checks after the mzR updates but then unfortunately started failing on a unit test on the