Re: Multiple ebgp neighbours to the same peer

2023-01-23 Thread Alexander Zubkov via Bird-users
On Mon, Jan 23, 2023 at 3:17 PM Alexander Zubkov wrote: > > > On Mon, Jan 23, 2023 at 3:06 PM Ondrej Zajicek > wrote: > >> On Mon, Jan 23, 2023 at 12:40:30AM +0100, Alexander Zubkov wrote: >> > Hi all, >> > >> > A quick try to fix the problem. But I'm not sure in complete correctness >> >

Re: rename symbols

2023-01-23 Thread Alexander Zubkov via Bird-users
On Tue, Jan 24, 2023 at 7:05 AM Maria Matejka via Bird-users < bird-users@network.cz> wrote: > Hello! > > > For example I may want to refactor the naming scheme for > > protocols/tables in my bird config. But when I apply the new config with > > the new names, such renamed protocols will be

Re: rename symbols

2023-01-23 Thread Maria Matejka via Bird-users
On 24 January 2023 07:54:23 CET, Ondrej Zajicek wrote: >On Tue, Jan 24, 2023 at 07:44:47AM +0100, Maria Matejka wrote: >> >Hello >> > >> >I thing that the most elegant way how to handle renaming of objects >> >during reconfiguration is to allow multiple names / aliases. There could >> >be be

Re: rename symbols

2023-01-23 Thread Alexander Zubkov via Bird-users
On Tue, Jan 24, 2023 at 7:59 AM Ondrej Zajicek wrote: > On Tue, Jan 24, 2023 at 07:44:47AM +0100, Maria Matejka wrote: > > >Hello > > > > > >I thing that the most elegant way how to handle renaming of objects > > >during reconfiguration is to allow multiple names / aliases. There could > > >be

Re: [PATCH] feature to keep protocol's state while configuring

2023-01-23 Thread Ondrej Zajicek
On Mon, Jan 23, 2023 at 03:19:43AM +0100, Alexander Zubkov wrote: > Hello, > > Not sure if those are forgotten or are unwanted modifications. Please let > me know. > > And I also have another idea regarding the subject. The idea is to > configure the file where bird will keep the states of the

Re: rename symbols

2023-01-23 Thread Ondrej Zajicek
On Tue, Jan 24, 2023 at 07:44:47AM +0100, Maria Matejka wrote: > >Hello > > > >I thing that the most elegant way how to handle renaming of objects > >during reconfiguration is to allow multiple names / aliases. There could > >be be more symbols pointing to given object (but the object points back

Re: rename symbols

2023-01-23 Thread Maria Matejka via Bird-users
On 24 January 2023 07:33:24 CET, Ondrej Zajicek wrote: >On Tue, Jan 24, 2023 at 06:57:01AM +0100, Maria Matejka via Bird-users wrote: >> Hello! >> >> > For example I may want to refactor the naming scheme for >> > protocols/tables in my bird config. But when I apply the new config with >> >

Re: rename symbols

2023-01-23 Thread Ondrej Zajicek
On Tue, Jan 24, 2023 at 06:57:01AM +0100, Maria Matejka via Bird-users wrote: > Hello! > > > For example I may want to refactor the naming scheme for > > protocols/tables in my bird config. But when I apply the new config with > > the new names, such renamed protocols will be recreated or

Re: rename symbols

2023-01-23 Thread Maria Matejka via Bird-users
Hello! For example I may want to refactor the naming scheme for protocols/tables in my bird config. But when I apply the new config with the new names, such renamed protocols will be recreated or restarted, which may be undesired. So if I could rename protocols/tables in advance and then

[PATCH] babel: Keep separate auth PC counters for unicast and multicast

2023-01-23 Thread Toke Høiland-Jørgensen via Bird-users
The babel protocol normally sends all its messages as multicast packets, but the protocol specification allows most messages to be sent as either unicast or multicast, and the two can be mixed freely. In particular, the babeld implementation can be configured to unicast updates to all peers

rename symbols

2023-01-23 Thread Alexander Zubkov via Bird-users
Hi all, Some weird idea. I'm not sure it needs to be in the mainstream version, but somebody might find it helpful. For example I may want to refactor the naming scheme for protocols/tables in my bird config. But when I apply the new config with the new names, such renamed protocols will be

回覆: 回覆: Question: ROA verification does not work properly on bird 2.0.11

2023-01-23 Thread haima via Bird-users
Hi Robert, Thanks for your reply, I used this write method, but it still returns this error I modified it to look like this: function is_rpki_invalid() { if (net.type = NET_IP4 && roa_check(roa_table4, net, bgp_path.last) = ROA_INVALID) then return true; else if (net.type =

回覆: 回覆: Question: ROA verification does not work properly on bird 2.0.11

2023-01-23 Thread haima via Bird-users
Hi Maria, This is not an empty Funciton, it is complete as follows: function is_rpki_invalid() { if roa_check(roa_table4, net, bgp_path.last) = ROA_INVALID then return true; if roa_check(roa_table6, net, bgp_path.last) = ROA_INVALID then return true; return false; }

Re: 回覆: Question: ROA verification does not work properly on bird 2.0.11

2023-01-23 Thread Robert Scheck
On Mon, 23 Jan 2023, haima via Bird-users wrote: > function is_rpki_invalid () { } > if roa_check(roa_table4, net, bgp_path.last) = ROA_INVALID then > return true > if roa_check(roa_table6, net, bgp_path.last) = ROA_INVALID then > return true; > return false; > } I might

RE: 回覆: Question: ROA verification does not work properly on bird 2.0.11

2023-01-23 Thread haima via Bird-users
Hi Maria, This is not an empty Funciton, it is complete as follows: function is_rpki_invalid() { if roa_check(roa_table4, net, bgp_path.last) = ROA_INVALID then return true; if roa_check(roa_table6, net, bgp_path.last) = ROA_INVALID then return true; return false; }

Re: 回覆: Question: ROA verification does not work properly on bird 2.0.11

2023-01-23 Thread Maria Matejka via Bird-users
Oh, looking at your previous post, I've spotted that on the previous line, you have this: function is_rpki_invalid() { } The ending brace creates an empty function and the following line is then probably misinterpreted as something strange. Maria On 1/23/23 16:50, haima wrote: Hi, Maria,

回覆: Question: ROA verification does not work properly on bird 2.0.11

2023-01-23 Thread haima via Bird-users
Hi, Maria, Thanks for your reply, Line 59 reads as follows: if roa_check(roa_table4, net, bgp_path.last) = ROA_INVALID then return true; Thanks, Haima MoeBee Network 寄件者: Bird-users 代表 Maria Matejka via Bird-users 已傳送: 星期一, 2023 年 1 月 23 日 23:38 收件者:

Re: Question: ROA verification does not work properly on bird 2.0.11

2023-01-23 Thread Maria Matejka via Bird-users
Hello! bird will return the following error: /etc/bird/function.conf:59:22 Syntax error, unexpected CF_SYM_UNDEFINED, expecting CF_SYM_KNOWN The numbers 59:22 are actually the line:char index in that file. Could you please disclose what is in /etc/bird/function.conf around line 59 to let us

回覆: Question: ROA verification does not work properly on bird 2.0.11

2023-01-23 Thread haima via Bird-users
Oh, I found that the translation tool seems to delete the semicolon in the function configuration, but it actually exists. 寄件者: haima 寄件日期: 2023年1月23日 22:44 收件者: bird-users@network.cz 主旨: Question: ROA verification does not work properly on bird 2.0.11 Hello

Question: ROA verification does not work properly on bird 2.0.11

2023-01-23 Thread haima via Bird-users
Hello dear community members, I am configuring RPKI verification for my network, but I have encountered a strange syntax error problem. My configuration is as follows: roa4 table roa_table4; roa6 table roa_table6; protocol rpki Cloudflare_RPKI {         roa4 { table roa_table4; };        

Re: Multiple ebgp neighbours to the same peer

2023-01-23 Thread Alexander Zubkov via Bird-users
On Mon, Jan 23, 2023 at 3:06 PM Ondrej Zajicek wrote: > On Mon, Jan 23, 2023 at 12:40:30AM +0100, Alexander Zubkov wrote: > > Hi all, > > > > A quick try to fix the problem. But I'm not sure in complete correctness > > though. > > Hi > > That looks more-or-less OK, will merge. > > > -

Re: Multiple ebgp neighbours to the same peer

2023-01-23 Thread Ondrej Zajicek
On Mon, Jan 23, 2023 at 12:40:30AM +0100, Alexander Zubkov wrote: > Hi all, > > A quick try to fix the problem. But I'm not sure in complete correctness > though. Hi That looks more-or-less OK, will merge. > -ipa_equal(x->addr, y->addr); > +ipa_equal(x->addr, y->addr) && > +

Re: small fix of indenting

2023-01-23 Thread Ondrej Zajicek
On Mon, Jan 23, 2023 at 02:48:13AM +0100, Alexander Zubkov via Bird-users wrote: > Hello, > > I found some bad indenting of if/else statements. Please see the attached > patch. Hello Merged. -- Elen sila lumenn' omentielvo Ondrej 'Santiago' Zajicek (email: santi...@crfreenet.org) OpenPGP

Re: Multiple ebgp neighbours to the same peer

2023-01-23 Thread Prem Anand
Hi Alexander, Thanks for the quick patch. I did a quick test with your patch and I could bringup both the bgp neighbours. :) I haven’t seen any issue so far with my limited testing Regards Prem > On 22 Jan 2023, at 23:40, Alexander Zubkov wrote: > > Hi all, > > A quick try to fix the

BIRD version 2.0.12

2023-01-23 Thread Ondrej Filip
Dear users, happy new year for everyone. We just released first stable version of BIRD this year. Many thanks to my great colleagues and namely Santiago. This release fixes some important bugs, here is a list of the main improvements: Version 2.0.12 (2023-01-23) o Filter: New 'onlink'