Re: [PATCH] feature to keep protocol's state while configuring

2023-01-26 Thread Alexander Zubkov via Bird-users
Updated the patch for keeping state in the file. Moved the read/write functions to sysdep/unix/main.c and made better parsing. So it is not a draft anymore, but something more or less "stable". I can add documentation patch in case there is interest to include that into upstream. On Tue, Jan 24, 2

SYM_MAX_LEN

2023-01-26 Thread Alexander Zubkov via Bird-users
Hi, If I do not mistake, cf_new_symbol() has incorrect check of symbol length. In other places where SYM_MAX_LEN is used, it is expected that leading zero is counted in it. But the check in cf_new_symbol() allows symbol length equal to SYM_MAX_LEN. This does not cause a problem (as I unederstand),

Re: [PATCH] babel: Keep separate auth PC counters for unicast and multicast

2023-01-26 Thread Toke Høiland-Jørgensen via Bird-users
Ondrej Zajicek writes: > On Tue, Jan 24, 2023 at 08:05:41PM +0100, Toke Høiland-Jørgensen wrote: >> > I think that simple sequence numbers work in two cases - if there is >> > sufficient interval between packets, or there is only one packet >> > flying (e.g. LSREQ-LSUPD ping-pong in OSPF). That i