Re: Start BIRD automatically

2020-06-02 Thread Toke Høiland-Jørgensen
"Fabiano D'Agostino" writes: > Hi, > how can BIRD automatically start after a reboot or a crash? Should I use > systemd? > I am using BIRD v2 on Ubuntu 20.04. I'm using this: [Unit] Description=BIRD routing daemon After=network.target [Service] Type=forking Restart=always

[PATCH v2] babel: Set onlink flag for IPv4 routes with unreachable next hop

2020-05-26 Thread Toke Høiland-Jørgensen
package for Bird since the v1 submission two years ago. The behaviour introduced here is essential for common deployments of Babel and matches the behaviour of babeld. Signed-off-by: Toke Høiland-Jørgensen --- v2: - Rebase to current master (using neigh_find() instead of neigh_find2()) proto/babel

Re: [PATCH 0/4] Add MAC authentication support to the Babel protocol

2020-03-11 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > On Tue, Mar 10, 2020 at 04:58:26PM +0100, Toke Høiland-Jørgensen wrote: >> > I think that random_bytes() should not fail. >> >> Preferably not; but we don't really have any guarantees that the syscall >> will succeed, do we? I gues

Re: [PATCH 0/4] Add MAC authentication support to the Babel protocol

2020-03-10 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > On Sun, Feb 23, 2020 at 11:56:33PM +0100, Toke Høiland-Jørgensen wrote: >> This series adds MAC authentication support to the Babel protocol as >> specified >> in by the IETF Babel working group in draft-babel-hmac-10: > > Hi > > Some m

Re: [PATCH 0/4] Add MAC authentication support to the Babel protocol

2020-02-26 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > On Tue, Feb 25, 2020 at 07:30:46PM +0100, Toke Høiland-Jørgensen wrote: >> Ondrej Zajicek writes: >> > For blake2s_bird_init(), IMHO it should behave like other keyed-hash, >> > i.e. pad with zeroes (for shorter) or ignore rest (for longer).

Re: [PATCH 0/4] Add MAC authentication support to the Babel protocol

2020-02-25 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > On Tue, Feb 25, 2020 at 05:35:50PM +0100, Toke Høiland-Jørgensen wrote: >> > 1) The documentation says: >> > >> > protocol will only accept HMAC-based algorithms or one of the Blake >> > algorithms, and the length of

Re: [PATCH 0/4] Add MAC authentication support to the Babel protocol

2020-02-25 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > On Sun, Feb 23, 2020 at 11:56:33PM +0100, Toke Høiland-Jørgensen wrote: >> This series adds MAC authentication support to the Babel protocol as >> specified >> in by the IETF Babel working group in draft-babel-hmac-10: >> >> https://too

[PATCH 4/4] babel: Add MAC authentication support

2020-02-23 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen This implements support for MAC authentication in the Babel protocol, as specified by draft-babel-hmac-10. The implementation seeks to follow the draft as close as possible, with the only deliberate deviation being the addition of support for all the HMAC algorithms

[PATCH 1/4] sysdep: Add wrapper to get random bytes

2020-02-23 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen The Babel authentication code added by a subsequent commit needs a way to get random bytes for generating nonces. This patch adds a wrapper function in sysdep to get random bytes, and the required checks in configure.ac to select how to do it. The configure script

[PATCH 3/4] babel: Refactor packet parsing code for reuse in authentication checks

2020-02-23 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen The subsequent commit will add authentication support to the Babel protocol, which also requires parsing the packet TLVs. To make this easier, this commit refactors the packet parsing code by adding a helper macro to loop over TLVs, and generalising

[PATCH 2/4] nest: Add Blake2s and Blake2b hash functions

2020-02-23 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen The Babel MAC authentication draft recommends implementing Blake2s as one of the supported algorithms. In order to achieve do this, add the blake2b and blake2s hash functions for MAC authentication. The hashing function implementations are the reference

[PATCH 0/4] Add MAC authentication support to the Babel protocol

2020-02-23 Thread Toke Høiland-Jørgensen
://github.com/jech/babeld/pull/52 [2] https://github.com/tohojo/bird/tree/babel-mac-01 --- Toke Høiland-Jørgensen (4): sysdep: Add wrapper to get random bytes nest: Add Blake2s and Blake2b hash functions babel: Refactor packet parsing code for reuse in authentication checks babel

Re: GCC 10 build failures at BIRD 2.0.7

2020-02-04 Thread Toke Høiland-Jørgensen
Robert Scheck writes: > On Mon, 03 Feb 2020, Toke Høiland-Jørgensen wrote: >> I think the below patch (against master) ought to fix it? Don't have a >> GCC v10 handy to test with, but at least it doesn't seem to break >> anything on GCC v9 :) >> >> I think the

Re: GCC 10 build failures at BIRD 2.0.7

2020-02-03 Thread Toke Høiland-Jørgensen
Robert Scheck writes: > Hello folks, > > trying to build BIRD 2.0.7 using GCC 10 (which landed in Fedora these days) > leads to a build failure like this: > > /usr/bin/ld: > obj/conf/cf-lex.o:/builddir/build/BUILD/bird-2.0.7/./nest/route.h:461: > multiple definition of `rta_dest_names'; >

Re: [babel] Purpose of 'generate from/to' and 'accept from/to' for passwords?

2020-01-21 Thread Toke Høiland-Jørgensen
Juliusz Chroboczek writes: > Thanks, Ondrej. > >> Well, it is requirement of OSPF spec (RFC 2328). I could assume it could >> help for smoother key transitions when clocks are not perfectly synchronized. > > Ah, I see. > > OSPF only allows one key in the trailer, so it needs the ability to send

Purpose of 'generate from/to' and 'accept from/to' for passwords?

2020-01-20 Thread Toke Høiland-Jørgensen
Hi Bird people When specifying passwords for protocol authentication in the Bird config, it is possible to specify time windows in which the password will be used to sign messages (the 'generate from/to' configuration options), and a separate time window in which that password will be accepted to

Re: Debian packages for BIRD 2

2019-09-13 Thread Toke Høiland-Jørgensen
Kees Meijs writes: > Hi list, > > Since our business is using BIRD (and Debian) a lot I just contact > Ondřej Surý and volunteered for help in terms of maintaining the package. > > My goals are to (try to) get BIRD2 2.0.5 in stretch-backports and maybe > BIRD 2.0.6 in the upcoming Debian

Re: IPv6 routes inserted into the kernel with 'route' end up with invalid type

2019-08-23 Thread Toke Høiland-Jørgensen
David Ahern writes: > On 8/23/19 8:43 AM, Toke Høiland-Jørgensen wrote: >> Hi David >> >> Tom noticed[0] that on newer kernels, the Bird routing daemon rejects IPv6 >> routes received from the kernel if those routes were inserted with the >> old 'route' uti

Re: bird 1.6 seems to ignore ipv6 kernel routes on 4.19

2019-08-23 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > On Wed, Aug 21, 2019 at 11:30:53PM +0200, Toke Høiland-Jørgensen wrote: >> >> # ip r a 2001:db8:1:14::/64 via 2001:db8:1:1::14 >> >> # route -6 add 2001:db8:1:15::/64 gw 2001:db8:1:1::15 >> > >> > This command uses the old

Re: BIRD 2.0.4 (with RPKI support) in EPEL 7/8 (for RHEL/CentOS 7/8)

2019-07-24 Thread Toke Høiland-Jørgensen
On 24 July 2019 16:35:17 CEST, Robert Scheck wrote: >On Wed, 24 Jul 2019, Toke Høiland-Jørgensen wrote: >> Should we try to consolidate those differences? I'm the co-maintainer >of >> the Fedora package :) > >Not sure if I created a misunderstanding here, but to consol

Re: Introduce Wireguard support to bird

2019-06-11 Thread Toke Høiland-Jørgensen
Bernd Naumann writes: > On 08.06.19 00:18, Toke Høiland-Jørgensen wrote: > >> - The algorithm is basically O(P*M*N) for inserting N routes on an >> interface with P peers that each have M existing AllowedIPs. That is >> not going to scale very far :/ >> >&

Re: Introduce Wireguard support to bird

2019-06-07 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > On Fri, Jun 07, 2019 at 06:21:42PM +, Janne Heß wrote: >> Hey everyone, >> >> as advertised, I have completed the Wireguard support. >> You might see that I am not really a C expert, but I hope the code is good >> enough. >> If you need me to change anything or

Re: Introduce Wireguard support to bird

2019-06-07 Thread Toke Høiland-Jørgensen
Janne Heß writes: > Hey everyone, > > as advertised, I have completed the Wireguard support. > You might see that I am not really a C expert, but I hope the code is good > enough. > If you need me to change anything or have additional questions, just > let me know. Hi Janne Awesome that you

Re: Kernel protocol and different namespaces

2019-06-07 Thread Toke Høiland-Jørgensen
Alexander Zubkov writes: > Hello, > > We want to use bird with different namespaces too, but proposed > changes is not an option for us anyway because of somewhat proprietary > kernel we are working with (there are some missing definitions for > namespaces in headers and vanilla does not fit).

Re: 2 upstreams 1 downstream BGP configuration optimization

2019-06-04 Thread Toke Høiland-Jørgensen
Kevin B writes: > Hello, > > I have 2 upstream transit providers and 1 downstream customer we provide > transit to - http://paste.debian.net/1086030/ (full Bird configuration > with explanation) > > There is a problem: Bird is exporting all the imported prefixes from my > upstreams back to

Re: Submitting code? (Wireguard)

2019-06-02 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > On Thu, May 30, 2019 at 09:16:42PM +, Janne Heß wrote: >> Hey everyone, >> >> I wrote code that adds Wireguard support (new kernelspace VPN) to Bird 2. >> The problem is that with the cryptokey routing of Wireguard, it needs to >> know which IPs are behind which

Re: Learning BIRD source

2019-04-12 Thread Toke Høiland-Jørgensen
Brian Topping writes: > Developer team: > > I’d like to get better with the source. Due to being an inferior > specimen and/or too many other projects, I need help from tools like > CLion to make sense of source trees within weeks instead of years. > > Are others working on BIRD source within

Re: Incomprehensible error concerning identical babel config for bird and bird6 (bird-v1.6.4 on ubuntu18.04.1)

2018-11-13 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > On Tue, Nov 13, 2018 at 10:11:58PM +0100, Christoffer Hansen wrote: >> Hi Maria, >> >> On 13/11/2018 21:29, Maria Jan Matějka wrote: >> > >> > Anyway, in version 2 you may use the dual stack babel protocol. Feel free >> > to try it and report any bug please. >> >>

Re: Quick yes / no question about BGP in Bird 1.x.

2018-11-08 Thread Toke Høiland-Jørgensen
Grant Taylor writes: > Does Bird 1.x support both IPv4 and IPv6 prefixes being advertised over > the same BGP neighbor session, which happens to be IPv4 connected? > > I've not done any research about this specific question yet and I'm just > hoping for a "yes it does" or "no it does not"

Re: change routing while exporting to kernel

2018-11-05 Thread Toke Høiland-Jørgensen
On 5 November 2018 18:23:01 CET, "Maria Jan Matějka" wrote: >Hey, thank you a lot for pointing this out. This is really something I >would like to see and maybe also comment on before it gets to kernel. You're welcome! And please to weigh in on netdev. Don't think the patches have been

Re: change routing while exporting to kernel

2018-11-05 Thread Toke Høiland-Jørgensen
Maria Jan Matějka writes: > Just a side note, it would be better to consider next hop as an object > which would be always set as a whole. It would also allow to change > ecmp route gws. Anyway, it is still in plan with no concrete date when > we will implement it. There is also work underway

Re: Bird debian repo now over https only?

2018-10-17 Thread Toke Høiland-Jørgensen
Florian Lohoff writes: > On Mon, Oct 15, 2018 at 12:22:34PM +0200, Toke Høiland-Jørgensen wrote: >> > The integrity of debian packages is guranteed by their hash >> > in the Packages file which is signed by a gpg signature. >> > So https is not needed f

Re: Bird debian repo now over https only?

2018-10-15 Thread Toke Høiland-Jørgensen
Florian Lohoff writes: > Hola, > > On Fri, Oct 12, 2018 at 01:44:55PM -0500, Jonathan Stewart wrote: >> I had to install apt-transport-https on debian 9 to reach the >> repositories. >> >> Personally, i was more surprised debian didn't support HTTPS by >> default rather than surprised that BIRD

Re: Help with multiple routing tables.

2018-08-21 Thread Toke Høiland-Jørgensen
Grant Taylor writes: > Hi, > > I need a second set of eyes on the following config. I feel like I've > made a mistake and I'm too tired to see it. > > - main_rib is Linux kernel table #254 and has all locally attached > interfaces. There is no default gateway in kernel table #254. > -

Re: [PATCH RFC 2/2] babel: Add HMAC support

2018-08-14 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > Hi > > Finally got to finish the review. The code looks OK, comments below. Thank you for the review! The draft was just accepted by the babel working group, so I expect there will be a new version along soon. I'll fix the issues you point out and submit a proper patch

Re: seemless configuration change

2018-08-03 Thread Toke Høiland-Jørgensen
Kurt Wauters writes: > Hello, > > I've got BIRD running for v4 and v6 but i was wondering if there is a way > to switch between configurations without shutting down bird in order to > avoid BGP flaps. > > I basically add regularly neighbors to the RS and i don't want my allready > active bgp

Re: [PATCH RFC 1/2] babel: Define helper macro for looping through TLVs

2018-07-18 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > On Fri, Jul 13, 2018 at 10:16:16PM +0200, Toke Høiland-Jørgensen wrote: >> Since we have several places where we loop over a TLV stream, define a >> helper macro to deal with framing checks and looping. > > OK, but it also makes framing e

Re: [PATCH RFC 2/2] babel: Add HMAC support

2018-07-18 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > On Fri, Jul 13, 2018 at 10:16:16PM +0200, Toke Høiland-Jørgensen wrote: >> This implements support for HMAC verification in Babel, as specified by >> draft-do-babel-hmac-00. > > Hi > > Thanks, will check that. One minor issue i just noti

Re: [PATCH RFC 2/2] babel: Add HMAC support

2018-07-18 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > On Sun, Jul 15, 2018 at 01:21:40AM +0200, Toke Høiland-Jørgensen wrote: >> Martin Mares writes: >> >> > Hi Toke, >> > >> > just a random thought: >> > >> >> + getrandom(n->hmac_nonce, BABEL_HMAC_NO

Fwd: [Babel-users] Babel@IETF meeting Tuesday 17th -- please participate remotely

2018-07-16 Thread Toke Høiland-Jørgensen
In case anyone is interested in the development of the Babel protocol. -Toke --- Begin Message --- Dear all, The Babel working group of the IETF will be meeting on Tuesday 17 July at 9:30 Montréal time (EDT, UTC-4) 1:30 UTC 3:30 Paris time (UTC+2) Highlights include a presentation by

Re: [PATCH RFC 2/2] babel: Add HMAC support

2018-07-14 Thread Toke Høiland-Jørgensen
Martin Mares writes: > Hi Toke, > > just a random thought: > >> + getrandom(n->hmac_nonce, BABEL_HMAC_NONCE_LEN, 0); > > I think we cannot rely on getrandom() being available on all systems. > It probably needs wrapping in sysdep code. Yeah, figured I would probably have to look into something

[PATCH RFC 1/2] babel: Define helper macro for looping through TLVs

2018-07-13 Thread Toke Høiland-Jørgensen
Since we have several places where we loop over a TLV stream, define a helper macro to deal with framing checks and looping. Signed-off-by: Toke Høiland-Jørgensen --- proto/babel/packets.c | 64 ++--- 1 file changed, 34 insertions(+), 30 deletions

[PATCH RFC 2/2] babel: Add HMAC support

2018-07-13 Thread Toke Høiland-Jørgensen
This implements support for HMAC verification in Babel, as specified by draft-do-babel-hmac-00. Signed-off-by: Toke Høiland-Jørgensen --- proto/babel/babel.c | 80 ++ proto/babel/babel.h | 58 +++- proto/babel/config.Y | 34 proto/babel/packets.c | 375

[PATCH RFC 0/2] Adding HMAC support to the Babel protocol

2018-07-13 Thread Toke Høiland-Jørgensen
-challenge branch of this repository: https://github.com/wkolod/babeld With this patch, Bird can successfully exchange HMAC-authenticated messages with babeld in the above repo. -Toke --- Toke Høiland-Jørgensen (2): babel: Define helper macro for looping through TLVs babel: Add HMAC

Re: [PATCH] babel: Check TLV framing before dereferencing tlv->type

2018-07-11 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > On Tue, Jul 10, 2018 at 11:56:40PM +0200, Toke Høiland-Jørgensen wrote: >> Signed-off-by: Toke Høiland-Jørgensen > > Hi > > I think that the current position is correct and the patch is not - the > follow-up code ('The end of the common TLV head

[PATCH] babel: Check TLV framing before dereferencing tlv->type

2018-07-10 Thread Toke Høiland-Jørgensen
Signed-off-by: Toke Høiland-Jørgensen --- proto/babel/packets.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/proto/babel/packets.c b/proto/babel/packets.c index d4ecf649..991c1520 100644 --- a/proto/babel/packets.c +++ b/proto/babel/packets.c @@ -1373,10 +1373,6

Re: [PATCH] babel: Don't send routes with empty next hops

2018-07-10 Thread Toke Høiland-Jørgensen
Toke Høiland-Jørgensen writes: > Toke Høiland-Jørgensen writes: > >> If an interface has no configured v4 address, no valid next hop will be >> found for v4 routes. Rather than send them with an invalid next hop (which >> will just cause parse errors at the receiver), s

Re: [PATCH] babel: Don't send routes with empty next hops

2018-07-10 Thread Toke Høiland-Jørgensen
Toke Høiland-Jørgensen writes: > If an interface has no configured v4 address, no valid next hop will be > found for v4 routes. Rather than send them with an invalid next hop (which > will just cause parse errors at the receiver), skip such routes entirely > when sending updates.

Re: Automating BIRD configuration

2018-06-19 Thread Toke Høiland-Jørgensen
Matthias Merkel writes: > We're trying to integrate BIRD with our automated DDoS detection and > mitigation system. For this we need a way to have our software create > static routes (to be more exact blackholes) and add BGP communities to > announcements. > > Is there any way to do using CLI or

Re: Babel + IPv4 = parse error

2018-06-12 Thread Toke Høiland-Jørgensen
Julian Schuh writes: > Hi, > > thanks you all for your reply. > > You were right, it was indeed the missing IPv4 addresses. I think I’m > quite spoiled by the IPv6 link-local addresses, so I forgot about > having to manually configure IPv4 addresses ;-) > > Does anybody still want to get any

[PATCH] babel: Don't send routes with empty next hops

2018-06-10 Thread Toke Høiland-Jørgensen
that v4 routes will not work if there is no v4 address on the interface. Signed-off-by: Toke Høiland-Jørgensen --- proto/babel/babel.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/proto/babel/babel.c b/proto/babel/babel.c index 44c6adb8..d3b5b841 100644

Re: Babel + IPv4 = parse error

2018-06-10 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > On Sun, Jun 10, 2018 at 02:48:45PM +0200, Toke Høiland-Jørgensen wrote: >> Ondrej Zajicek writes: >> >> > On Sun, Jun 10, 2018 at 11:22:17AM +0200, Julian Schuh wrote: >> >> Hi all, >> >> >> >> for a

Re: Babel + IPv4 = parse error

2018-06-10 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > On Sun, Jun 10, 2018 at 11:22:17AM +0200, Julian Schuh wrote: >> Hi all, >> >> for a current project I’m planning on using Babel as a lightweight, >> dual-stack routing protocol for a couple of simple tasks. For a proof of >> concept I’ve been using BIRD, and a plan

Re: Babel + IPv4 = parse error

2018-06-10 Thread Toke Høiland-Jørgensen
Julian Schuh writes: > Hi all, > > for a current project I’m planning on using Babel as a lightweight, > dual-stack routing protocol for a couple of simple tasks. For a proof of > concept I’ve been using BIRD, and a plan to continue using BIRD at least in > the backend. > > Sadly, I quickly

Re: Package repositories

2018-05-23 Thread Toke Høiland-Jørgensen
Jan Maria Matejka writes: > Hello! > >> On Wed, May 23, 2018 at 3:05 PM Ondrej Zajicek > > wrote: >> We plan to have some transition in packages to keep both 1.6 and 2.0 as >> independent packages in repository

Re: [PATCH] filter: Add .srclen attribute to filter on source prefix length

2018-05-16 Thread Toke Høiland-Jørgensen
Ondrej Zajicek <santi...@crfreenet.org> writes: > On Sun, May 13, 2018 at 10:59:51PM +0200, Toke Høiland-Jørgensen wrote: >> This adds a new attribute to expose the source prefix length in the same >> way as the destination prefix length, via a new .srclen attribute. >

[PATCH] filter: Add .srclen attribute to filter on source prefix length

2018-05-13 Thread Toke Høiland-Jørgensen
This adds a new attribute to expose the source prefix length in the same way as the destination prefix length, via a new .srclen attribute. Signed-off-by: Toke Høiland-Jørgensen <t...@toke.dk> --- filter/config.Y | 3 ++- filter/filter.c | 8 filter/filter.h | 1 + lib/net.h

Re: [PATCH 2/3] babel: Short-circuit route selection for routes we originate ourselves

2018-05-09 Thread Toke Høiland-Jørgensen
Ondrej Zajicek <santi...@crfreenet.org> writes: > On Tue, May 01, 2018 at 01:22:47PM +0200, Toke Høiland-Jørgensen wrote: >> This behaviour relies on the fact that the route was initially learned >> from the kernel, so from the nest's perspective it has very low >&g

Re: [PATCH 3/3] babel: Add option to randomise router ID

2018-05-09 Thread Toke Høiland-Jørgensen
Ondrej Zajicek <santi...@crfreenet.org> writes: > On Thu, May 03, 2018 at 03:14:58PM +0200, Toke Høiland-Jørgensen wrote: >> Ondrej Zajicek <santi...@crfreenet.org> writes: >> > Ignoring global setting is OK, i just wonder whether some global >> > EUI-64

Re: [PATCH] babel: Set onlink flag for IPv4 routes with unreachable next hop

2018-05-09 Thread Toke Høiland-Jørgensen
Ondrej Zajicek <santi...@crfreenet.org> writes: > On Mon, May 07, 2018 at 08:57:43PM +0200, Toke Høiland-Jørgensen wrote: >> Toke Høiland-Jørgensen <t...@toke.dk> writes: >> >> > If the next hop of a route is not a reachable address, the route should be &g

Re: [PATCH] babel: Set onlink flag for IPv4 routes with unreachable next hop

2018-05-07 Thread Toke Høiland-Jørgensen
Toke Høiland-Jørgensen <t...@toke.dk> writes: > If the next hop of a route is not a reachable address, the route should be > installed as onlink. This enables a configuration common in mesh networks > where the mesh interface is assigned a /32 and babel handles the routing by >

Re: [PATCH 3/3] babel: Add option to randomise router ID

2018-05-03 Thread Toke Høiland-Jørgensen
Ondrej Zajicek <santi...@crfreenet.org> writes: > On Mon, Apr 30, 2018 at 05:15:19PM +0200, Toke Høiland-Jørgensen wrote: >> When a Babel node restarts, it loses its sequence number, which can cause >> its routes to be rejected by peers until the state is cleared

Re: OSPF wireguard fallback

2018-05-03 Thread Toke Høiland-Jørgensen
chrono writes: >> You need to set AllowedIPs to 0.0.0.0/0 on both sides. That way >> wireguard will pass all traffic through (that only works for p2p links >> with only two peers, obviously). In your current setup, wireguard won't >> pass the OSPF multicast traffic, so

Re: OSPF wireguard fallback

2018-05-03 Thread Toke Høiland-Jørgensen
chrono writes: >> [ ... ] >> >> just to be sure that not wireguard is the problem here, how looks your >> AllowedIPs within the wireguard config? >> >> Maybe it does not allow traffic of the routers? > > That may be so, currently I only have each opposite site in

Re: [PATCH 3/3] babel: Add option to randomise router ID

2018-05-03 Thread Toke Høiland-Jørgensen
Ondrej Zajicek <santi...@crfreenet.org> writes: > On Tue, May 01, 2018 at 12:41:01PM +0200, Toke Høiland-Jørgensen wrote: >> Toke Høiland-Jørgensen <t...@toke.dk> writes: >> >> > When a Babel node restarts, it loses its sequence number, which can cause >

Re: OSPF wireguard fallback

2018-05-03 Thread Toke Høiland-Jørgensen
chrono writes: > Hi Ondrej, > > thanks for the quick reply. > >>> What makes me wonder is why wg0 is coming up as stubnet here, >>> while the MPLS links come up as network (stubnet 172.23.3.0/29 metric >>> 10) >>> and 172.23.3.0/29 (wg0 net) not being listed. > >> You

Re: [PATCH] Makefile.in: Only set git version if .git directory exists

2018-05-03 Thread Toke Høiland-Jørgensen
Jan Maria Matejka <jan.mate...@nic.cz> writes: > Hi! > > On 05/02/2018 06:43 PM, Toke Høiland-Jørgensen wrote: >> If Bird is compiled from a release tarball, but there is a git repository >> somewhere in a parent directory, the Makefile git version logic will pick

Re: [PATCH 2/3] babel: Short-circuit route selection for routes we originate ourselves

2018-05-01 Thread Toke Høiland-Jørgensen
Toke Høiland-Jørgensen <t...@toke.dk> writes: > On 30 April 2018 22:32:18 CEST, Ondrej Zajicek <santi...@crfreenet.org> wrote: >>On Mon, Apr 30, 2018 at 05:15:18PM +0200, Toke Høiland-Jørgensen wrote: >>> Routes that are originated by this Babel instance doesn't have

Re: [PATCH 2/3] babel: Short-circuit route selection for routes we originate ourselves

2018-04-30 Thread Toke Høiland-Jørgensen
On 30 April 2018 22:32:18 CEST, Ondrej Zajicek <santi...@crfreenet.org> wrote: >On Mon, Apr 30, 2018 at 05:15:18PM +0200, Toke Høiland-Jørgensen wrote: >> Routes that are originated by this Babel instance doesn't have an >entry in >> e->selected, which means that the

[PATCH 3/3] babel: Add option to randomise router ID

2018-04-30 Thread Toke Høiland-Jørgensen
across restarts, or picking a different router ID each time. This implements the latter, by introducing a new option that will cause Bird to pick a random router ID every time it starts up. This avoids the problem at the cost of not having stable router IDs in the network. Signed-off-by: Toke Høiland

[PATCH 1/3] babel: Fix type of route entry router ID

2018-04-30 Thread Toke Høiland-Jørgensen
The router ID being assigned to routes was a uint, which discards the upper 32 bits. This also has the nice side effect of echoing the wrong router ID back to other routers. Signed-off-by: Toke Høiland-Jørgensen <t...@toke.dk> --- proto/babel/babel.c | 2 +- 1 file changed, 1 insertion

[PATCH 2/3] babel: Short-circuit route selection for routes we originate ourselves

2018-04-30 Thread Toke Høiland-Jørgensen
ure (depending on filters, of course). To avoid this problem, simply short-circuit the route selection procedure if the entry has our own router ID set. Signed-off-by: Toke Høiland-Jørgensen <t...@toke.dk> --- proto/babel/babel.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pr

Re: Setting ONLINK flag for arbitrary routes

2018-04-29 Thread Toke Høiland-Jørgensen
On 30 April 2018 00:27:43 CEST, Ondrej Zajicek <santi...@crfreenet.org> wrote: >On Sun, Apr 29, 2018 at 10:54:06PM +0200, Toke Høiland-Jørgensen wrote: >> Hi >> >> Is it possible to set the ONLINK flag for arbitrary routes? >> >> The use case is a com

Setting ONLINK flag for arbitrary routes

2018-04-29 Thread Toke Høiland-Jørgensen
Hi Is it possible to set the ONLINK flag for arbitrary routes? The use case is a common setup in mesh networks: All devices have a /32 assigned to the interface and advertise this as the nexthop for v4 routes. The routing protocol then installs all kernel routes as onlink, allowing routes to be

Re: Bird BGP in VRF

2018-04-20 Thread Toke Høiland-Jørgensen
Ticlea Alexandru writes: > Hello > > BGP is able to run in a vrf using a specific table? > > I have this config (snippet) > > protocol bgp bgp_private { >     vrf "vrf-private"; >     ipv4 { >     igp table vrf_private; >         #export

Re: [PATCH] babel: Use acknowledged retractions when losing a prefix

2018-04-04 Thread Toke Høiland-Jørgensen
Ondrej Zajicek <santi...@crfreenet.org> writes: > On Thu, Mar 08, 2018 at 10:25:56PM +0100, Toke Høiland-Jørgensen wrote: >> Toke Høiland-Jørgensen <t...@toke.dk> writes: >> >> > In order to prevent routing loops, Babel installs temporary blackhole

Re: BIRD 2.0.2 and 1.6.4

2018-03-22 Thread Toke Høiland-Jørgensen
Piotr Marciniak writes: > Hello Ondrej, > > Thx for info. When is it expected 1.6.4 to be added to Debian (and others) > repo? Of course we can build from source but it helps keeping everything > together. Adding to this, do you have plans to add 2.0 releases to the Debian repo

Re: [PATCH] babel: Use acknowledged retractions when losing a prefix

2018-03-10 Thread Toke Høiland-Jørgensen
Ondrej Zajicek <santi...@crfreenet.org> writes: > On Thu, Mar 08, 2018 at 10:25:56PM +0100, Toke Høiland-Jørgensen wrote: >> > This patch implements the above behaviour. It adds a generic facility to >> > the Babel protocol which allows for sending sequences of ac

Re: [PATCH] babel: Use acknowledged retractions when losing a prefix

2018-03-08 Thread Toke Høiland-Jørgensen
Toke Høiland-Jørgensen <t...@toke.dk> writes: > In order to prevent routing loops, Babel installs temporary blackhole > routes to prefixes that expire or are otherwise lost. These blackhole > routes are maintained for a while to ensure the route has been flushed > from

Re: bird systemd startup init debian

2018-03-07 Thread Toke Høiland-Jørgensen
Ondrej Zajicek <santi...@crfreenet.org> writes: > On Tue, Mar 06, 2018 at 12:26:02PM +0100, Toke Høiland-Jørgensen wrote: >> Rob Lister <r...@lonap.net> writes: >> >> > root@rs1f:/etc/bird# service bird start >> > Job for bird.service failed becaus

Re: [bird2]: babel compile bug?

2018-03-05 Thread Toke Høiland-Jørgensen
Leo Vandewoestijne writes: > Was I trieng something impossible, or is this an error? > Is RIP a dependency for Babel? It shouldn't be, but it seems I may have missed a keyword in the Babel code. Could you try the patch below and see if that fixes it? -Toke diff --git

[PATCH] netlink.c: Fix running with LOCAL_DEBUG enabled

2018-02-22 Thread Toke Høiland-Jørgensen
Signed-off-by: Toke Høiland-Jørgensen <t...@toke.dk> --- sysdep/linux/netlink.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sysdep/linux/netlink.c b/sysdep/linux/netlink.c index c6f2e1fc..9c74d743 100644 --- a/sysdep/linux/netlink.c +++ b/sysdep/linux/net

Re: [PATCH v3] babel: Add source-specific routing support

2018-02-13 Thread Toke Høiland-Jørgensen
Ondrej Zajicek <santi...@crfreenet.org> writes: > On Tue, Feb 06, 2018 at 08:46:22PM +0100, Toke Høiland-Jørgensen wrote: >> This adds support for source-specific routing to the babel protocol. It >> changes the protocol to support both NET_IP6 and NET_IP6_SADR channels

[PATCH] babel: Use acknowledged retractions when losing a prefix

2018-02-11 Thread Toke Høiland-Jørgensen
of acknowledgement requests to a number of neighbours, and executing a callback function once all the requests have been ACKed. This facility is then used to implement the acknowledgement scheme when a route is lost. Signed-off-by: Toke Høiland-Jørgensen <t...@toke.dk> --- proto/babel/babel.c

[PATCH v2] Fix a bunch of implicit switch fallthrough warnings

2018-02-11 Thread Toke Høiland-Jørgensen
-by: Toke Høiland-Jørgensen <t...@toke.dk> --- v2: - Missed one warning. Sorry for the noise. lib/printf.c| 1 + proto/bfd/packets.c | 2 ++ proto/ospf/dbdes.c | 1 + proto/ospf/ospf.c | 1 + proto/ospf/packet.c | 1 + proto/radv/radv.c | 1 + sysdep/unix/io.c| 5 + sysde

[PATCH] Fix a bunch of implicit switch fallthrough warnings

2018-02-11 Thread Toke Høiland-Jørgensen
-by: Toke Høiland-Jørgensen <t...@toke.dk> --- lib/printf.c| 1 + proto/bfd/packets.c | 2 ++ proto/ospf/dbdes.c | 1 + proto/ospf/ospf.c | 1 + proto/ospf/packet.c | 1 + proto/radv/radv.c | 1 + sysdep/unix/io.c| 5 + 7 files changed, 12 insertions(+) diff --git a/lib/pr

[PATCH] babel: Fix accidental bitwise or assignment

2018-02-11 Thread Toke Høiland-Jørgensen
Fix an accidental bitwise or assignment that was supposed to be a comparison. Signed-off-by: Toke Høiland-Jørgensen <t...@toke.dk> --- proto/babel/babel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proto/babel/babel.c b/proto/babel/babel.c index aa7e8b68..3cf8aaf0

Re: Crash on reconfigure with kernel table

2018-02-07 Thread Toke Høiland-Jørgensen
Ondrej Zajicek <santi...@crfreenet.org> writes: > On Wed, Feb 07, 2018 at 09:22:49AM +0100, Toke Høiland-Jørgensen wrote: >> Ondrej Zajicek <santi...@crfreenet.org> writes: >> >> > On Tue, Feb 06, 2018 at 08:50:52PM +0100, Toke Høiland-Jørgensen wrote: >>

Re: Crash on reconfigure with kernel table

2018-02-07 Thread Toke Høiland-Jørgensen
Ondrej Zajicek <santi...@crfreenet.org> writes: > On Tue, Feb 06, 2018 at 08:50:52PM +0100, Toke Høiland-Jørgensen wrote: >> While testing the babel sadr patch, I ran into this crash on reconfigure >> of the kernel protocol: > > Hi > > Likely it is reconfiguration

[PATCH] Add cscope Makefile target

2018-02-06 Thread Toke Høiland-Jørgensen
For those who prefer cscope to etags Signed-off-by: Toke Høiland-Jørgensen <t...@toke.dk> --- .gitignore | 1 + Makefile.in | 5 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 0dcebfd1..3b734f49 100644 --- a/.gitignore +++ b/.gitignore @@

Crash on reconfigure with kernel table

2018-02-06 Thread Toke Høiland-Jørgensen
While testing the babel sadr patch, I ran into this crash on reconfigure of the kernel protocol: Basically, start with this config: router id 62.168.0.1; debug protocols all; protocol device {} ipv6 sadr table tab1; protocol kernel { ipv6 sadr { table tab1; export all; import

[PATCH v3] babel: Add source-specific routing support

2018-02-06 Thread Toke Høiland-Jørgensen
-source-specific routes are simply treated as source-specific routes with sadr prefix 0. Signed-off-by: Toke Høiland-Jørgensen <t...@toke.dk> --- This version also works with plain ipv6 channels. proto/babel/babel.c | 34 +++--- proto/babel/babel.h | 20 -- proto/babel/packets.c

Re: [PATCH 1/2] Add IP6_SADR support to Bird Core

2018-02-06 Thread Toke Høiland-Jørgensen
Ondrej Zajicek <santi...@crfreenet.org> writes: > On Tue, Feb 06, 2018 at 05:20:25PM +0100, Toke Høiland-Jørgensen wrote: >> It's mandatory, otherwise you can get routing loops. See >> https://tools.ietf.org/html/draft-ietf-babel-source-specific-03#section-6 >> &g

Re: [PATCH 1/2] Add IP6_SADR support to Bird Core

2018-02-06 Thread Toke Høiland-Jørgensen
Ondrej Zajicek <santi...@crfreenet.org> writes: > On Tue, Feb 06, 2018 at 04:57:43PM +0100, Toke Høiland-Jørgensen wrote: >> What, we have to be nice to the users now? ;) >> >> Fair enough, I'll add support for both types of channels. Should it be >> possible to

Re: [PATCH 1/2] Add IP6_SADR support to Bird Core

2018-02-06 Thread Toke Høiland-Jørgensen
Ondrej Zajicek <santi...@crfreenet.org> writes: > On Tue, Feb 06, 2018 at 04:38:59PM +0100, Toke Høiland-Jørgensen wrote: >> > I did not check 2/2 yet, but i think it should support both regular >> > ipv6 and ipv6 SADR channels/tables, not just the SADR ones. >

Re: [PATCH 1/2] Add IP6_SADR support to Bird Core

2018-02-06 Thread Toke Høiland-Jørgensen
Ondrej Zajicek <santi...@crfreenet.org> writes: > On Mon, Feb 05, 2018 at 03:33:25PM +0100, Toke Høiland-Jørgensen wrote: >> Will fix and resubmit. What about the issue with 'learn'? :) > > Fixed in 28b3b551222ab58456a067a9be4790824cdbb60e Great, thanks! Do you want me to

[PATCH v2 2/2] babel: Add source-specific routing support

2018-02-05 Thread Toke Høiland-Jørgensen
is to the packet parsing and serialising code. Signed-off-by: Toke Høiland-Jørgensen <t...@toke.dk> --- proto/babel/babel.c | 20 +++ proto/babel/babel.h | 14 - proto/babel/packets.c | 161 +++--- 3 files changed, 175 insertions(+), 20 del

Re: [PATCH 1/2] Add IP6_SADR support to Bird Core

2018-02-05 Thread Toke Høiland-Jørgensen
Ondrej Zajicek <santi...@crfreenet.org> writes: > On Sat, Feb 03, 2018 at 09:40:56PM +0100, Toke Høiland-Jørgensen wrote: >> This adds support for source-specific IPv6 routes to Bird core. This is >> based on Dean Luga's original patch, with the review comments addressed. >

Re: [PATCH] babel: Ignore Hello TLVs with unicast flag set

2017-10-30 Thread Toke Høiland-Jørgensen
Toke Høiland-Jørgensen <t...@toke.dk> writes: > RFC6126bis introduces a flags field for the Hello TLV, and adds a unicast flag > that is used to signify that a hello was sent as unicast. This adds parsing of > the flags field and ignores such unicast hellos, which preserves compat

[PATCH] babel: Ignore Hello TLVs with unicast flag set

2017-10-30 Thread Toke Høiland-Jørgensen
mechanism. Signed-off-by: Toke Høiland-Jørgensen <t...@toke.dk> --- proto/babel/packets.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/proto/babel/packets.c b/proto/babel/packets.c index efe05678..597ed60d 100644 --- a/proto/babel/packets.c +++ b/proto

<    1   2   3   >