Re: [PATCH] babel: Drop check for IF_MULTICAST interface flag

2021-04-19 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > On Mon, Apr 19, 2021 at 03:55:18PM +0200, Toke Høiland-Jørgensen wrote: >> Ondrej Zajicek writes: >> >> > Is there a reason why to disregard the IF_MULTICAST flag? This seems to me >> > more like a bug in FreeBSD Wireguard implementation that should be fixed >> > there.

Re: [PATCH] babel: Drop check for IF_MULTICAST interface flag

2021-04-19 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > On Thu, Apr 15, 2021 at 03:44:50PM +0200, Toke Høiland-Jørgensen wrote: >> The babel protocol code was checking interfaces for the IF_MULTICAST flag >> and refusing to run if this isn't present. However, there are cases where >> this flag doesn't correspond to the actual

Re: [PATCH] babel: Drop check for IF_MULTICAST interface flag

2021-04-19 Thread Ondrej Zajicek
On Mon, Apr 19, 2021 at 03:55:18PM +0200, Toke Høiland-Jørgensen wrote: > Ondrej Zajicek writes: > > > Is there a reason why to disregard the IF_MULTICAST flag? This seems to me > > more like a bug in FreeBSD Wireguard implementation that should be fixed > > there. Is this flag properly checked o

Re: [PATCH] babel: Drop check for IF_MULTICAST interface flag

2021-04-19 Thread Ondrej Zajicek
On Thu, Apr 15, 2021 at 03:44:50PM +0200, Toke Høiland-Jørgensen wrote: > The babel protocol code was checking interfaces for the IF_MULTICAST flag > and refusing to run if this isn't present. However, there are cases where > this flag doesn't correspond to the actual capability of sending multicas

[PATCH] babel: Drop check for IF_MULTICAST interface flag

2021-04-15 Thread Toke Høiland-Jørgensen
The babel protocol code was checking interfaces for the IF_MULTICAST flag and refusing to run if this isn't present. However, there are cases where this flag doesn't correspond to the actual capability of sending multicast packets. For instance, Wireguard interfaces on FreeBSD doesn't set the requi