[PATCH] Graceful shutdown request signal

2023-07-17 Thread Erin Shepherd
I ended up picking this up and implementing it, and in my experiments it seems to be working fine Patch attached - Erin On Tue, 20 Jun 2023, at 21:07, Maria Matejka via Bird-users wrote: > Hello! > > Well, it's a pity that systemd doesn't allow for custom operations – in such > case you

Re: Graceful shutdown request signal

2023-06-21 Thread Maria Matejka via Bird-users
Hello Alexander, you're right, catching up with all the running session and restoring the full internal state would be a nightmare. I think it is doable but too difficult (and labour-costly) to get it right. Regarding the need for graceful restart support anyway, I don't see much of a good

Re: Graceful shutdown request signal

2023-06-21 Thread Alexander Zubkov via Bird-users
Hello Maria, Regarding restarts, I think the killer feature might be some sort of restart, when bird execs a new binary, keeping all the file descriptors open and its state somehow. So the new instance could transparently catch up with all the running sessions, etc. It can serialize the internal

Re: Graceful shutdown request signal

2023-06-21 Thread Maria Matejka via Bird-users
Hello Daniel, On 21 June 2023 01:03:50 CEST, "Daniel Gröber" wrote: >Hi Erin, > >On Tue, Jun 20, 2023 at 08:20:50PM +0200, Erin Shepherd wrote: >> I run bird on a system which uses systemd as a service supervisor, and >> would like to implement graceful restart in a way which works well with >>

Re: Graceful shutdown request signal

2023-06-20 Thread Daniel Gröber
Hi Erin, On Tue, Jun 20, 2023 at 08:20:50PM +0200, Erin Shepherd wrote: > I run bird on a system which uses systemd as a service supervisor, and > would like to implement graceful restart in a way which works well with > it. I'm also interested in getting this working. I'm wondering how graceful

Re: Graceful shutdown request signal

2023-06-20 Thread Vincent Bernat
On 2023-06-20 21:07, Maria Matejka via Bird-users wrote: Well, it's a pity that systemd doesn't allow for custom operations – in such case you could call "systemd graceful bird2" or "systemd restart bird2"… It's still possible to use systemctl kill --signal=USR2 bird2

Re: Graceful shutdown request signal

2023-06-20 Thread Maria Matejka via Bird-users
Hello! Well, it's a pity that systemd doesn't allow for custom operations – in such case you could call "systemd graceful bird2" or "systemd restart bird2"… Anyway, feel free to implement it, it should be like 10 lines of code. Sigusr2 is probably ok. Then it'll be on anybody to choose whether

Graceful shutdown request signal

2023-06-20 Thread Erin Shepherd
Hello, I run bird on a system which uses systemd as a service supervisor, and would like to implement graceful restart in a way which works well with it. In particular, what I'd like to do is: • If I restart the bird service (e.g. for an upgrade), Bird performs a graceful restart • If I