Re: RFC 9234 (BGP roles) possible bug

2023-05-18 Thread Ondrej Zajicek
On Thu, May 11, 2023 at 05:27:01PM +0200, Ondrej Zajicek wrote: > Hi > > Yes, it is a bug in BIRD. When BGP capability option is parsed, the > capability structure is initialized with the proper default value, but > when there is no BGP capability option altogether (like in these case), > the

Re: RFC 9234 (BGP roles) possible bug

2023-05-12 Thread Maria Matejka via Bird-users
Hello! Yes, it's hardcoded, typically as a macro / constant definition. I don't see any good reason to have it outside BIRD. Maria On 12 May 2023 14:23:37 CEST, Douglas Fischer wrote: >This conversation piqued my curiosity... > >P.S.: It's almost a fork on the topic, but maybe it could be a

Re: RFC 9234 (BGP roles) possible bug

2023-05-12 Thread Douglas Fischer
This conversation piqued my curiosity... P.S.: It's almost a fork on the topic, but maybe it could be a productive conversation. I apologize in advance if I mess up. Just for context: I'm not a programmer! I have some references of the concepts, but almost no practice in it. How does Bird load

Re: RFC 9234 (BGP roles) possible bug

2023-05-12 Thread Mikhail Grishin
Hi, Thanks. I'll also remind you the idea to show in Bird CLI not Last error: BGP Error: Role mismatch but Last error: BGP Error: Role mismatch (provider) In some of previous conversations you accepted it. Ondrej Zajicek пишет 11.05.2023 18:27: In the logs printed Error: Role

Re: RFC 9234 (BGP roles) possible bug

2023-05-11 Thread Ondrej Zajicek
On Thu, May 11, 2023 at 03:06:48PM +0300, Mikhail Grishin wrote: > Hi, > > We ran BGP roles at 1000+ BGP sessions. > About 0.5 - 1% of them affected by some issue. Probably all of them - > Juniper with the old junos. > > At the same time, question to the stage 3) - why Bird gererate such message?

RFC 9234 (BGP roles) possible bug

2023-05-11 Thread Mikhail Grishin
Hi, We ran BGP roles at 1000+ BGP sessions. About 0.5 - 1% of them affected by some issue. Probably all of them - Juniper with the old junos. Here is description: 1) Our device (Bird) sent BGP Open to the peers, with Capability: BGP Role Type: BGP Role (9)