Re: kernel protocol ignores default preference during scan

2022-09-27 Thread Maria Matejka via Bird-users
Hello! I've used your original patch, for now I don't like doing much refactoring like this to keep merging with v3 as simple as possible. Anyway, thank you for sending the patch, I've implemented a kernel-route-learn test, found out that indeed there is the bug you found and applied it.

Re: kernel protocol ignores default preference during scan

2022-09-22 Thread Alexander Zubkov via Bird-users
And just an idea. I've attached the patch as an example, although it should be functional too. I mentioned that functions krt_learn_async() and krt_learn_scan() are very similar and I thought that it may be useful to join them into a single function. If I did not make a mistake, all code pathes

Re: kernel protocol ignores default preference during scan

2022-09-21 Thread Maria Matejka via Bird-users
Hello! Thank you for finding and fixing. Will check and include. Maria On 9/21/22 17:15, Alexander Zubkov via Bird-users wrote: I made a trivial patch for the case. On Tue, Sep 20, 2022 at 6:23 PM Alexander Zubkov wrote: Hi, Bird from master branch ignores the default preference set in

Re: kernel protocol ignores default preference during scan

2022-09-21 Thread Alexander Zubkov via Bird-users
I made a trivial patch for the case. On Tue, Sep 20, 2022 at 6:23 PM Alexander Zubkov wrote: > > Hi, > > Bird from master branch ignores the default preference set in channel > for a kernel protocol, like that: > > protocol kernel { > learn yes; > ipv4 { >

kernel protocol ignores default preference during scan

2022-09-20 Thread Alexander Zubkov via Bird-users
Hi, Bird from master branch ignores the default preference set in channel for a kernel protocol, like that: protocol kernel { learn yes; ipv4 { preference 200; import all; export none; }; } Version 2.0.10 seems ok. I