Re: logging via udp

2023-12-13 Thread Ondrej Zajicek
On Wed, Dec 13, 2023 at 02:59:47PM +0100, Alexander Zubkov wrote: > > > And could you, please, also explain another moment: > > > https://gitlab.nic.cz/labs/bird/-/commit/2c7555cf2ac8439713dd9148b348128c57222a38#bc490dc797778621d2345fabe1fb0b59fce18264_141_179 > > > Here your free the sk resource.

Re: logging via udp

2023-12-13 Thread Alexander Zubkov via Bird-users
Hi, Thank you! On Wed, Dec 13, 2023 at 2:35 PM Ondrej Zajicek wrote: > > On Wed, Dec 13, 2023 at 11:50:42AM +0100, Alexander Zubkov wrote: > > Hi, > > > > Thanks! I looked throught your version and it is unclear to me if the > > sk is still added to the io loop list (sock_list) or not. It seems

Re: logging via udp

2023-12-13 Thread Ondrej Zajicek
On Wed, Dec 13, 2023 at 11:50:42AM +0100, Alexander Zubkov wrote: > Hi, > > Thanks! I looked throught your version and it is unclear to me if the > sk is still added to the io loop list (sock_list) or not. It seems > that sk_insert() still should be called on log udp socket, because I > see no

Re: logging via udp

2023-12-13 Thread Alexander Zubkov via Bird-users
Hi, Thanks! I looked throught your version and it is unclear to me if the sk is still added to the io loop list (sock_list) or not. It seems that sk_insert() still should be called on log udp socket, because I see no exception for it. Didn't you have the same problem with reloads as I had? I

Re: logging via udp

2023-12-12 Thread Ondrej Zajicek
On Sun, Jan 02, 2022 at 04:58:33PM +0100, Alexander Zubkov wrote: > Updated my last patch. I found a problem with that version, it hang on > reconfigure sometimes. It turned out that birdsocks are added to the > loop poll and it caused problems. Fixed that with SKF_THREAD flag, but > that may be a

Re: logging via udp

2022-01-02 Thread Alexander Zubkov
Updated my last patch. I found a problem with that version, it hang on reconfigure sometimes. It turned out that birdsocks are added to the loop poll and it caused problems. Fixed that with SKF_THREAD flag, but that may be a bit tricky. Also found myself that there is already a structure for log

Re: logging via udp

2022-01-02 Thread Alexander Zubkov
Hi, Is there reason agains adding udp log destination in bird? I have in attachmealsont a reworked version of the patch. This version does not use direct socket interface, but extends birdsock API for its needs. It also should not call (and possibly block) getaddrinfo() in case when plain IP is

Re: logging via udp

2019-12-18 Thread Alexander Zubkov
Hi, On Wed, Dec 18, 2019 at 1:01 PM Ondrej Zajicek wrote: > > On Wed, Dec 18, 2019 at 09:14:43AM +0100, Alexander Zubkov wrote: > > Hello, > > > > Made some dirty patch for myself to allow bird to send logs via udp. > > But it may be useful not only for me, so posting it here. It could be > >

Re: logging via udp

2019-12-18 Thread Ondrej Zajicek
On Wed, Dec 18, 2019 at 09:14:43AM +0100, Alexander Zubkov wrote: > Hello, > > Made some dirty patch for myself to allow bird to send logs via udp. > But it may be useful not only for me, so posting it here. It could be > useful when server experiencing high IO-load. As syslog and file >

logging via udp

2019-12-18 Thread Alexander Zubkov
Hello, Made some dirty patch for myself to allow bird to send logs via udp. But it may be useful not only for me, so posting it here. It could be useful when server experiencing high IO-load. As syslog and file operations in bird are blocking, it can be blocked on writing to it for indefinite