On Fri, Oct 09, 2015 at 11:57:37AM +0200, Toke Høiland-Jørgensen wrote:
> > Default metric probably should be more than zero (zero makes sense
> > for /128 local address, while more than zero for locally reachable
> > network prefix).
>
> Hmm, but if it's a prefix locally reachable prefix, no more
Ondrej Zajicek writes:
> Also one thing i forgot to notice. For generated external routes, you
> initialize metric to 0 (r->metric = 0 in babel_rt_notify()). You
> should use ea_get_int(attrs, EA_BABEL_METRIC, 0) to allow user set it
> in export filters.
Ah, so that's what that is for. Noted.
>
On Thu, Oct 08, 2015 at 05:12:36PM +0200, Toke Høiland-Jørgensen wrote:
> Ondrej Zajicek writes:
>
> > I am sorry i didn't got around to review it sooner, but doing a proper
> > review for a whole new (and unfamiliar) protocol takes nontrivial
> > amount of time.
> >
> > Generally, the code looks
Ondrej Zajicek writes:
> I am sorry i didn't got around to review it sooner, but doing a proper
> review for a whole new (and unfamiliar) protocol takes nontrivial
> amount of time.
>
> Generally, the code looks good and i am determined to finally merge
> it, but it definitely needs more refineme
On Mon, Sep 07, 2015 at 11:10:34PM +0200, Toke Høiland-Jørgensen wrote:
> This adds the Babel routing protocol (RFC6126) to Bird. It is a complete
> implementation of the IPv6 subset of RFC6126, but does not implement any
> of the extensions.
Hello
I am sorry i didn't got around to review it soo
On Mon, Sep 07, 2015 at 11:10:34PM +0200, Toke Høiland-Jørgensen wrote:
> This adds the Babel routing protocol (RFC6126) to Bird. It is a complete
> implementation of the IPv6 subset of RFC6126, but does not implement any
> of the extensions.
Thanks, i will review the patch ASAP.
> Compared to th
This adds the Babel routing protocol (RFC6126) to Bird. It is a complete
implementation of the IPv6 subset of RFC6126, but does not implement any
of the extensions.
Compared to the RFC patch posted earlier, this patch implements several
more SHOULD parts of the protocol, has updated interactions w
