Re: [bird2]: babel compile bug?

[Ondrej Zajicek]

On Mon, Mar 05, 2018 at 11:58:49AM +0100, Toke Høiland-Jørgensen wrote:
> Leo Vandewoestijne  writes:
> 
> > Was I trieng something impossible, or is this an error?
> > Is RIP a dependency for Babel?
> 
> It shouldn't be, but it seems I may have missed a keyword in the Babel
> code. Could you try the patch below and see if that fixes it?

Thanks, fixed. There were also some more keywords that were needed to
add when Babel was configured as the only protocol.

-- 
Elen sila lumenn' omentielvo

Ondrej 'Santiago' Zajicek (email: santi...@crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."

Re: [bird2]: babel compile bug?

[Toke Høiland-Jørgensen]

Leo Vandewoestijne  writes:

> Was I trieng something impossible, or is this an error?
> Is RIP a dependency for Babel?

It shouldn't be, but it seems I may have missed a keyword in the Babel
code. Could you try the patch below and see if that fixes it?

-Toke

diff --git a/proto/babel/config.Y b/proto/babel/config.Y
index 25ce5ba0..6d548997 100644
--- a/proto/babel/config.Y
+++ b/proto/babel/config.Y
@@ -23,8 +23,8 @@ CF_DEFINES
 CF_DECLS
 
 CF_KEYWORDS(BABEL, METRIC, RXCOST, HELLO, UPDATE, INTERVAL, PORT, WIRED,
-   WIRELESS, RX, TX, BUFFER, LENGTH, CHECK, LINK, BABEL_METRIC, NEXT, HOP,
-   IPV4, IPV6)
+   WIRELESS, RX, TX, BUFFER, LENGTH, PRIORITY, CHECK, LINK, BABEL_METRIC,
+   NEXT, HOP, IPV4, IPV6)
 
 CF_GRAMMAR
 

[bird2]: babel compile bug?

[Leo Vandewoestijne]

Hello list,

If I compile using the following:


BIRD was configured with the following options:
Source directory:   .
Object directory:   obj
Iproute2 directory:
System configuration:   ./sysdep/cf/bsd.h
Debugging:  no
POSIX threads:  yes
Routing protocols:  bfd babel bgp static
Kernel MPLS support:no
Client: yes

Then I end up with this:

===>  Building for bird-2.0.1
gmake[2]: Entering directory '/usr/ports/net/bird2/work/bird-2.0.1'
MKDIR -p obj/client obj/conf obj/doc obj/filter obj/lib obj/nest obj/test 
obj/proto/bfd obj/proto/babel obj/proto/bgp obj/proto/static obj/sysdep/unix 
obj/sysdep/bsd obj/doc
gm4 -P conf/gen_parser.m4 conf/confbase.Y conf/flowspec.Y obj/.dir-stamp 
filter/config.Y nest/config.Y proto/bfd/config.Y proto/babel/config.Y 
proto/bgp/config.Y proto/static/config.Y sysdep/unix/config.Y sysdep/unix/krt.Y 
sysdep/bsd/krt-sock.Y >obj/conf/cf-parse.y
bison  -dv -pcf_ -b obj/conf/cf-parse obj/conf/cf-parse.y
obj/conf/cf-parse.y:2707.7-14: error: symbol PRIORITY is used, but is not 
defined as a token and has no rules
  | TX PRIORITY expr { BABEL_IFACE->tx_priority = $3; }
   
gmake[2]: *** [conf/Makefile:23: obj/conf/cf-parse.tab.c] Error 1


If I do
Routing protocols:  bfd bgp static
or
Routing protocols:  bfd babel bgp ospf pipe radv rip static
or
Routing protocols:  bfd babel bgp rip static
all goes well.

Was I trieng something impossible, or is this an error?
Is RIP a dependency for Babel?

-- 

Met vriendelijke groet,
With kind regards,


Leo Vandewoestijne
<***@dns.company>