Re: [bitcoin-dev] Detailed protocol design for routed multi-transaction CoinSwap

2020-08-20 Thread ZmnSCPxj via bitcoin-dev
Good morning, > Right, so if the taker uses only a single maker then they must have more > than one UTXO. Spending one UTXO is fine, it is generating a transaction that has one output that is problematic. What needs to happen is that this single UTXO is spent to two outputs: the CoinSwap

Re: [bitcoin-dev] Generalizing feature negotiation when new p2p connections are setup

2020-08-20 Thread David A. Harding via bitcoin-dev
On Sun, Aug 16, 2020 at 12:06:55PM -0700, Eric Voskuil via bitcoin-dev wrote: > A requirement to ignore unknown (invalid) messages is [...] a protocol > breaking change I don't think it is. The proposed BIP, as currently written, only tells nodes to ignore unknown messages during peer

Re: [bitcoin-dev] Detailed protocol design for routed multi-transaction CoinSwap

2020-08-20 Thread Nadav Kohen via bitcoin-dev
Hey Chris and all, Looking good :) I have one major concern though >q = EC privkey generated by maker >Q = q.G = EC pubkey published by maker > >p = nonce generated by taker >P = p.G = nonce point calculated by taker > >R = Q + P = pubkey used in bitcoin transaction > =

Re: [bitcoin-dev] Detailed protocol design for routed multi-transaction CoinSwap

2020-08-20 Thread Chris Belcher via bitcoin-dev
Hello ZmnSCPxj, Thanks for the review. My comments are inline. On 20/08/2020 12:17, ZmnSCPxj wrote: > Good morning Chris, > > Great to see this! > > Mostly minor comments. > > > >> >> == Direct connections to Alice === >> >> Only Alice, the taker, knows the entire route, Bob and Charlie

Re: [bitcoin-dev] Detailed protocol design for routed multi-transaction CoinSwap

2020-08-20 Thread Chris Belcher via bitcoin-dev
Hello Nadav and ZmnSCPxj, On 20/08/2020 22:38, ZmnSCPxj wrote: > Good morning Nadav, > >> Hey Chris and all, >> >> Looking good :) I have one major concern though >> >>>     q = EC privkey generated by maker >>>     Q = q.G = EC pubkey published by maker >>> >>>     p = nonce generated by taker

Re: [bitcoin-dev] Generalizing feature negotiation when new p2p connections are setup

2020-08-20 Thread Anthony Towns via bitcoin-dev
On Fri, Aug 14, 2020 at 03:28:41PM -0400, Suhas Daftuar via bitcoin-dev wrote: > In thinking about the mechanism used there, I thought it would be helpful to > codify in a BIP the idea that Bitcoin network clients should ignore unknown > messages received before a VERACK.  A draft of my proposal

Re: [bitcoin-dev] Detailed protocol design for routed multi-transaction CoinSwap

2020-08-20 Thread ZmnSCPxj via bitcoin-dev
Good morning Nadav, > Hey Chris and all, > > Looking good :) I have one major concern though > > >    q = EC privkey generated by maker > >    Q = q.G = EC pubkey published by maker > > > >    p = nonce generated by taker > >    P = p.G = nonce point calculated by taker > > > >    R = Q + P =

Re: [bitcoin-dev] Detailed protocol design for routed multi-transaction CoinSwap

2020-08-20 Thread ZmnSCPxj via bitcoin-dev
Good morning Chris, Great to see this! Mostly minor comments. > > == Direct connections to Alice === > > Only Alice, the taker, knows the entire route, Bob and Charlie just know > their previous and next transactions. Bob and Charlie do not have direct > connections with each other, only with