Re: [Bitcoin-development] Request review: drop misbehaving peers

2011-09-16 Thread Joel Joonatan Kaartinen
Darn good question. If the protection fails, would it be better for it to 'fail hard', leaving people complaining bitcoin won't stay connected! Or fail soft, so you at least have a couple of connections. I think fail hard is better-- we'll immediately know about the problem, and can fix

Re: [Bitcoin-development] Request review: drop misbehaving peers

2011-09-15 Thread Stefan Thomas
A few thoughts: Should the DoS protection auto-disable if the node has less than a minimum number of connections? The idea being that if our node seems to be kicking /everybody /off the roster maybe there is something wrong with the protections. It would be nice if the node sent a message

Re: [Bitcoin-development] Request review: drop misbehaving peers

2011-09-15 Thread Gavin Andresen
I hate to get specific about potential attacks on a public mailing list, but I think the debate over what to do with non-standard transactions means we need to. I agree with Gregory; if there are NO rules about what transactions peers can send at you, then an attacker can trivially get around

Re: [Bitcoin-development] Request review: drop misbehaving peers

2011-09-15 Thread Mike Hearn
If I think you're trying to DoS me, why would I be nice to you? The issue is, what if I'm not trying to DoS you, but something went wrong? think response messages would just give an attacker another potential attack vector, and it is clear from the debug.log what triggers a ban. Only clear