[Bitcoin-development] Missing fRelayTxes in version message

2013-06-18 Thread Turkey Breast
See this BIP. I'm not sure if this is a bug or what, but it would be good if messages always had a fixed number of fields per protocol version. https://en.bitcoin.it/wiki/BIP_0060#Code_Updates This BIP details everything that needs to be done and proposes a protocol upgrade. ---

Re: [Bitcoin-development] Missing fRelayTxes in version message

2013-06-18 Thread Mike Hearn
It's not a bug (although there was recently a change to make bitcoind/qt always send this field anyway). I don't know where Amir is going with BIP 60. Version messages have always been variable length. There's nothing inherent in the Bitcoin protocol that says all messages are fixed length, indeed

Re: [Bitcoin-development] Missing fRelayTxes in version message

2013-06-18 Thread Turkey Breast
That's me. I never said to make all messages fixed length. I said to make a fixed number of fields per protocol. So given a protocol version number, you know the number of fields in a message. This is not only easier for parsing messages, but just good practice. I don't see why a 1 byte flag nee