Re: [Bitcoin-development] var_int ambiguous serialization consequences

2015-02-01 Thread Wladimir
On Sun, 1 Feb 2015, Tamas Blummer wrote: I wonder of consequences if var_int is used in its longer than necessary forms (e.g encoding 1 as 0xfd0100 instead of 0x01) In serialize.h lingo you are talking about CompactSize, not VarInt. CompactSizes indeed have redundancy in their

[Bitcoin-development] var_int ambiguous serialization consequences

2015-02-01 Thread Tamas Blummer
I wonder of consequences if var_int is used in its longer than necessary forms (e.g encoding 1 as 0xfd0100 instead of 0x01) This is already of interest if applying size limit to a block, since transaction count is var_int but is not part of the hashed header or the merkle tree. It could also

Re: [Bitcoin-development] var_int ambiguous serialization consequences

2015-02-01 Thread Pieter Wuille
Hashes are always computed by reserializing data structures, never by hashing wire data directly. This has been the case in every version of the reference client's code that I know of. This even meant that for example a block of 99 bytes with non-shortest length for the transaction count