[Bitcoin-development] Missing fRelayTxes in version message

2013-06-18 Thread Turkey Breast
See this BIP. I'm not sure if this is a bug or what, but it would be good if messages always had a fixed number of fields per protocol version. https://en.bitcoin.it/wiki/BIP_0060#Code_Updates This BIP details everything that needs to be done and proposes a protocol upgrade.

Re: [Bitcoin-development] Missing fRelayTxes in version message

2013-06-18 Thread Turkey Breast
needs to be optional anyway. From: Mike Hearn m...@plan99.net To: Turkey Breast turkeybre...@yahoo.com Cc: Bitcoin Dev bitcoin-development@lists.sourceforge.net Sent: Tuesday, June 18, 2013 9:48 PM Subject: Re: [Bitcoin-development] Missing fRelayTxes in version

Re: [Bitcoin-development] Missing fRelayTxes in version message

2013-06-19 Thread Turkey Breast
saying it should and the code in bitcoind indicating it should. Nowhere was this written. It doesn't help other implementations to have an unclear behaviour that depends on some magic from one implementation. From: Mike Hearn m...@plan99.net To: Turkey Breast

Re: [Bitcoin-development] Missing fRelayTxes in version message

2013-06-20 Thread Turkey Breast
be upgraded. Now that fRelayTxes is part of the protocol, the version number should be upgraded to reflect this fact. From: Mike Hearn m...@plan99.net To: Paul Lyon pml...@hotmail.ca Cc: Turkey Breast turkeybre...@yahoo.com; bitcoin-development@lists.sourceforge.net

Re: [Bitcoin-development] Missing fRelayTxes in version

2013-06-20 Thread Turkey Breast
I don't get why this is such a contentious change? Before I was able to use asserts to check the expected length of length of messages per protocol version, I could pass in dumb iterators that just parse the byte stream and I could serialize and deserialize a message to check the parser is