Re: [blink-dev] Intent to Ship: Resource Timing: Expose interim response times

2023-05-09 Thread Yoav Weiss
LGTM3 On Tue, May 9, 2023 at 10:20 PM Daniel Bratell wrote: > LGTM2 > > /Daniel > On 2023-05-09 19:44, Mike Taylor wrote: > > LGTM1 > On 5/8/23 5:45 AM, 'Noam Rosenthal' via blink-dev wrote: > > > > On Wednesday, April 26, 2023 at 6:54:40 PM UTC+3 Noam Rosenthal wrote: > > On Wed, Apr 26, 2023

Re: [blink-dev] Scroll to Text Fragment - Gmail doesn't preview the link

2023-05-09 Thread Michael Bradley
I agree that it would be good for Google to handle this the same way a copy does. Previewing/testing the link from GMail draft always opens another tab/window - at least in my experience - never a popup. This was just a curiosity due to the inconvenience of NOT relying on the draft Preview/Test,

Re: [blink-dev] Re: Intent to Ship: WGSLLanguageFeatures for WebGPU

2023-05-09 Thread 'Loko Kung' via blink-dev
Thanks Yoav for taking a look! Bumping this again since M115 branch point is coming soon (May 23) and we still need 2 more LGTMs before I can land the changes! On Tuesday, May 9, 2023 at 7:31:33 AM UTC-7 Yoav Weiss wrote: > LGTM1 > > On Wed, May 3, 2023 at 9:52 PM Loko Kung wrote: > >> Thanks

Re: [blink-dev] Intent to Ship: Keyboard-focusable scroll containers

2023-05-09 Thread Di Zhang
Yes, this change is flagged behind the feature KeyboardFocusableScrollers (disabled by passing `--disable-blink-features=KeyboardFocusableScrollers`). We have looped in aleventhal@ for similar accessibility concern. Aaron is the one who implemented the Keyboard Focusable Scrollers feature on

Re: [blink-dev] Intent to Ship: Deprecate module size limit for WebAssembly.Module()

2023-05-09 Thread 'Andreas Haas' via blink-dev
Thank you very much! On Tue, May 9, 2023 at 11:00 PM Chris Harrelson wrote: > LGTM3 to change the limit to 8MB, for the reasons Andreas outlined > (maximum function size, reasonable runtime on a low-end phone). > > Also, I can totally see increasing the limit in the future, as the >

Re: [blink-dev] Intent to Ship: Deprecate module size limit for WebAssembly.Module()

2023-05-09 Thread Chris Harrelson
LGTM3 to change the limit to 8MB, for the reasons Andreas outlined (maximum function size, reasonable runtime on a low-end phone). Also, I can totally see increasing the limit in the future, as the implementation is optimized further, typical hardware speeds increase, or there are compelling

Re: [blink-dev] Intent to Ship: Resource Timing: Expose interim response times

2023-05-09 Thread Daniel Bratell
LGTM2 /Daniel On 2023-05-09 19:44, Mike Taylor wrote: LGTM1 On 5/8/23 5:45 AM, 'Noam Rosenthal' via blink-dev wrote: On Wednesday, April 26, 2023 at 6:54:40 PM UTC+3 Noam Rosenthal wrote: On Wed, Apr 26, 2023 at 1:32 PM Yoav Weiss wrote: On Tue, Apr 25, 2023 at 10:47 

Re: [blink-dev] Scroll to Text Fragment - Gmail doesn't preview the link

2023-05-09 Thread David Bokan
Ah, I see it now...it's because GMail doesn't use an tag...it fakes it and adds a click handler. Unfortunately there's not much you can do as a user in this case (aside from copy/pasting the URL manually) - ideally Gmail would fix their window.open to include noopener. On Tue, May 9, 2023 at

Re: [blink-dev] Scroll to Text Fragment - Gmail doesn't preview the link

2023-05-09 Thread PhistucK
That also does not work (in draft mode), but this is probably because it does not have an href (and it probably uses the same code path as a normal click), so a broken GMail implementation that breaks it. ☆*PhistucK* On Tue, May 9, 2023 at 3:24 PM David Bokan wrote: > Text fragments work just

Re: [blink-dev] Intent to Ship: Boolean Context Style Container Queries

2023-05-09 Thread Mike Taylor
LGTM3 On 5/9/23 4:38 AM, Philip Jägenstedt wrote: LGTM2 On Wed, May 3, 2023 at 11:35 PM Manuel Rego Casasnovas wrote: LGTM1 On 03/05/2023 14:22, Rune Lillesveen wrote: > >         Contact emails > > futh...@chromium.org > >

Re: [blink-dev] Intent to Ship: Resource Timing: Expose interim response times

2023-05-09 Thread Mike Taylor
LGTM1 On 5/8/23 5:45 AM, 'Noam Rosenthal' via blink-dev wrote: On Wednesday, April 26, 2023 at 6:54:40 PM UTC+3 Noam Rosenthal wrote: On Wed, Apr 26, 2023 at 1:32 PM Yoav Weiss wrote: On Tue, Apr 25, 2023 at 10:47 AM Noam Rosenthal wrote: Contact

[blink-dev] Re: Intent to Prototype: Web environment integrity API

2023-05-09 Thread 'Ben Wiser' via blink-dev
The contact email b...@chromium.org was added in error. That should be bew...@chromium.org. On Monday, May 8, 2023 at 4:30:30 PM UTC+1 Ben Wiser wrote: > Contact emails > > serge...@chromium.org, pb...@chromium.org, ryanka...@google.com, > b...@chromium.org, erictrou...@chromium.org >

Re: [blink-dev] Re: Intent to Ship: WGSLLanguageFeatures for WebGPU

2023-05-09 Thread Yoav Weiss
LGTM1 On Wed, May 3, 2023 at 9:52 PM Loko Kung wrote: > Thanks Kai for replying! To add on top of that: > > For the signals: Positive > https://github.com/WebKit/standards-positions/issues/107 > https://mozilla.github.io/standards-positions/#webgpu > \o/ > > > For the web-platform-tests, on

Re: [blink-dev] Scroll to Text Fragment - Gmail doesn't preview the link

2023-05-09 Thread 'David Bokan' via blink-dev
Text fragments work just fine from `window.open` but have restrictions about being isolated from other pages. I suspect gmail isn't adding `noopener` in window.open so that the opened page remains reachable from gmail. If that's the case, your link should work if you ctrl/cmd-click the link or

Re: [blink-dev] Intent to Ship: Private State Tokens API

2023-05-09 Thread 'Steven Valdez' via blink-dev
We've merged the permissions policy integration into the spec document. On Fri, May 5, 2023 at 1:14 PM Steven Valdez wrote: > Rick: For the spec work, we've merged the type parameter removal into the > spec and have a PR to > add the permission

[blink-dev] Re: Intent to Ship: timestamp field on RTCEncodedVideoFrameMetadata

2023-05-09 Thread 'Tony Herre' via blink-dev
Thanks for the reply - hard to judge how much context to include for small launches like this. The motivation is in helping WebRTC web applications which are using both Mediacapture Transforms to modify raw audio/video (adding video effects,

Re: [blink-dev] Intent to Ship: Boolean Context Style Container Queries

2023-05-09 Thread Philip Jägenstedt
LGTM2 On Wed, May 3, 2023 at 11:35 PM Manuel Rego Casasnovas wrote: > LGTM1 > > On 03/05/2023 14:22, Rune Lillesveen wrote: > > > > Contact emails > > > > futh...@chromium.org > > > > > > Explainer > > > > None > > > > > > Specification > >

Re: [blink-dev] Intent to Deprecate: Deprecate unload event

2023-05-09 Thread 'Fergal Daly' via blink-dev
On Mon, 8 May 2023 at 17:51, Rick Byers wrote: > Hi Fergal, > It's exciting to see this moving forward! Just to clarify, this is > effectively an I2S for the unload permissions-policy, is that right? Or are > you also requesting permission to stop firing unload events now too? The > latter is

[blink-dev] Re: Intent to extend origin trial: Pending Beacon API

2023-05-09 Thread Yoav Weiss
LGTM to extend experimentation M113-115 I appreciate your engagement with WebKit & Fetch folks and your willingness to modify the API shape based on feedback. I think that can easily count as progress towards shipping, which is required for extending the OT. The fact that the current shape is

[blink-dev] Intent to extend origin trial: Pending Beacon API

2023-05-09 Thread Ming-Ying Chung
API owners, We would like to extend the origin trial for 3 additional milestones, with the extension starting in 113 continuing through 115. The OT was previously approved