Re: [blink-dev] Intent to Ship: 'pageswap' event

2024-03-06 Thread Manuel Rego Casasnovas
What's going on with the tests? https://wpt.fyi/results/html/browsers/browsing-the-web/history-traversal/pageswap?label=master=experimental=chrome=firefox=safari Thanks, Rego On 06/03/2024 11:57, Yoav Weiss (@Shopify) wrote: LGTM1 On Wed, Mar 6, 2024 at 11:54 AM Noam Rosenthal

Re: [blink-dev] Intent to Ship: Compute Pressure

2024-03-06 Thread Manuel Rego Casasnovas
The TAG asked to be updated after the experimental phase, but the issue hasn't been updated yet: https://github.com/w3ctag/design-reviews/issues/795#issuecomment-1691188175 Also for WebKit position, we might want to fill a new issue in the new place:

Re: [blink-dev] Intent to Ship: Form Controls Support Vertical Writing Mode Direction Support

2024-02-28 Thread Manuel Rego Casasnovas
On 23/02/2024 21:42, Di Zhang wrote: Specification https://github.com/whatwg/html/issues/8413 What's the status of this issue? Is there any spec text that needs to change? Interoperability and Compatibility Chrome:

Re: [blink-dev] Intent to Ship: Do not invert author selection background color when it matches text color

2024-02-28 Thread Manuel Rego Casasnovas
kind of agreement. So ignore this intent for now. Cheers, Rego > On Mon, Oct 4, 2021 at 1:34 PM Manuel Rego Casasnovas mailto:r...@igalia.com> > <mailto:r...@igalia.com <mailto:r...@igalia.com>>> wrote: > > > **Contact

Re: [blink-dev] Intent to Experiment: Document Subtitle (Fix PWA app titles)

2024-02-21 Thread Manuel Rego Casasnovas
On 20/02/2024 18:47, 'Diego Gonzalez' via blink-dev wrote: Specification https://github.com/whatwg/html/compare/main...diekus:html:main Should this be an actual HTML PR so discussion with third parties can happen

Re: [blink-dev] Re: Intent to Ship: setHTMLUnsafe and parseHTMLUnsafe

2024-02-21 Thread Manuel Rego Casasnovas
LGTM3 On 21/02/2024 07:48, Yoav Weiss (@Shopify) wrote: LGTM2 On Wednesday, February 21, 2024 at 6:19:50 AM UTC+1 Domenic Denicola wrote: LGTM1. I recall these methods getting lots of good design review and discussion in the PR, from multiple parties. I'm excited to see them ship.

Re: [blink-dev] Intent to Ship: Shadow root clonable attribute

2024-02-19 Thread Manuel Rego Casasnovas
LGTM2. On 17/02/2024 02:40, Mason Freed wrote: On Fri, Feb 16, 2024 at 6:30 AM Mike Taylor > wrote: __ LGTM1 to ship (see below). Thanks! It looks like Safari has only shipped to Beta... Yes, this was a recent consensus/spec, so it hasn't made it

Re: [blink-dev] Intent to Ship: CSS picture-in-picture display mode

2024-02-16 Thread Manuel Rego Casasnovas
Thanks for adding the test. LGTM2. Cheers, Rego On 14/02/2024 13:15, 'François Beaufort' via blink-dev wrote: On Wed, Feb 14, 2024 at 10:48 AM Manuel Rego Casasnovas <mailto:r...@igalia.com>> wrote: On 14/02/2024 10:46, François Beaufort wrote: > > &

Re: [blink-dev] Intent to Ship: CSS picture-in-picture display mode

2024-02-14 Thread Manuel Rego Casasnovas
On 14/02/2024 10:46, François Beaufort wrote: On Wed, Feb 14, 2024 at 10:43 AM Manuel Rego Casasnovas <mailto:r...@igalia.com>> wrote: Hi, On 13/02/2024 11:13, 'François Beaufort' via blink-dev wrote: > >         Is this feature fully tested by web

Re: [blink-dev] Intent to Ship: CSS picture-in-picture display mode

2024-02-14 Thread Manuel Rego Casasnovas
Hi, On 13/02/2024 11:13, 'François Beaufort' via blink-dev wrote: Is this feature fully tested by web-platform-tests ? Yes https://wpt.fyi/results/css/mediaqueries/display-mode.html

Re: [blink-dev] Intent to Ship: CSS paint-order for non-SVG text

2024-02-12 Thread Manuel Rego Casasnovas
! Rego On 12/02/2024 12:02, Manuel Rego Casasnovas wrote: LGTM1. Good to know it's a different issue in Firefox. Now that all browsers will be supporting this, please could you make the test non tentative? JFYI, I've filled an issue so the MDN documentation gets updated to also include

Re: [blink-dev] Intent to Ship: CSS paint-order for non-SVG text

2024-02-12 Thread Manuel Rego Casasnovas
Cheers, Rego On 09/02/2024 09:00, Stefan Zager wrote: On Thu, Feb 8, 2024 at 4:00 AM Manuel Rego Casasnovas <mailto:r...@igalia.com>> wrote: Why is the WPT test marked as tentative? https://wpt.fyi/results/css/css-fill-stroke/paint-order-001.tentative.html <https://wpt

Re: [blink-dev] Intent to Ship: CSS paint-order for non-SVG text

2024-02-08 Thread Manuel Rego Casasnovas
Why is the WPT test marked as tentative? https://wpt.fyi/results/css/css-fill-stroke/paint-order-001.tentative.html Not sure if there are more tests or is only that one, but it's failing in Firefox. What are the interop issues? Are those reported somewhere? Thanks, Rego On 08/02/2024

Re: [blink-dev] Intent to Ship: WebGPU: separate Read-only depth-stencil

2024-01-18 Thread Manuel Rego Casasnovas
LGTM3 On 18/01/2024 02:26, Mike Taylor wrote: LGTM2 On 1/17/24 7:45 PM, Chris Harrelson wrote: LGTM1 (as noted in the other intent, tests are needed but we aren't blocking approval on them in this case) On Wed, Jan 10, 2024 at 11:02 AM Corentin Wallez wrote: Hey Rick, The spec

Re: [blink-dev] Intent to Ship: New ALPS code point

2024-01-17 Thread Manuel Rego Casasnovas
On 13/01/2024 00:08, Victor Tan wrote: TAG review https://github.com/w3ctag/design-reviews/issues/549 TAG review is from 2021, has anything changed since then or is it still the same feature/spec that is shipping now? Firefox:

Re: [blink-dev] Intent to Ship: Long Animation Frame Timing

2024-01-17 Thread Manuel Rego Casasnovas
On 15/01/2024 11:31, Noam Rosenthal wrote: Link to entry on the Chrome Platform Status https://chromestatus.com/feature/6118675067699200 Can you tick the other review boxes on the entry? Not sure I

Re: [blink-dev] Intent to Ship: CSS Pseudo Element ::backdrop inheriting from Originating Element

2024-01-10 Thread Manuel Rego Casasnovas
LGTM3. BTW, one question about pseudo-elements, for some of them we have use counters buts not for all (like this one, or at least I didn't find it). Is that fine? Or should we usually add use counters for new pseudo-elements? Cheers, Rego On 10/01/2024 16:46, Daniel Bratell wrote: LGTM2

Re: [blink-dev] Web-Facing Change PSA: CSS Highlight Inheritance

2023-10-31 Thread Manuel Rego Casasnovas
Hi Stephen, Please send a new email in a separated thread for the intent to ship. Thanks, Rego On 31/10/2023 01:17, Stephen Chenney wrote: The new launch process workflow wouldn't let me do an Intent to Ship for this one, at least not without some as-yet-unknown gate based on this email.

Re: [blink-dev] Intent to Ship: Relaxed CSS Nesting

2023-10-04 Thread Manuel Rego Casasnovas
LGTM2 On 04/10/2023 11:49, Yoav Weiss wrote: Thanks for clarifying and verifying! :) My LGTM still stands. On Wed, Oct 4, 2023 at 11:48 AM Anders Hartvoll Ruud mailto:andr...@chromium.org>> wrote: On Tue, Oct 3, 2023 at 8:46 PM Anders Hartvoll Ruud mailto:andr...@chromium.org>>

Re: [blink-dev] Intent to Ship: CSS :dir() pseudo-class selector

2023-10-04 Thread Manuel Rego Casasnovas
LGTM1 Just for context, this was already approved 3 years ago: https://groups.google.com/a/chromium.org/g/blink-dev/c/p0Wc66rbVOc/m/khHJ0dSsAwAJ But then we realized the spec text was not ready, there were some misunderstandings and things got blocked on that. Big thanks to push this to the

Re: [blink-dev] Intent to Ship: Media Queries: scripting feature

2023-08-30 Thread Manuel Rego Casasnovas
LGTM1 Thanks for catching up on this feature. Cheers, Rego On 26/08/2023 17:56, Luke wrote: > > Contact emails > > lukewarlow...@gmail.com > , l...@warlow.dev > > > Explainer > > None > > > Specification >

Re: [blink-dev] Intent to Ship: CSS Relative Color Syntax (RCS)

2023-08-30 Thread Manuel Rego Casasnovas
On 29/08/2023 16:17, Aaron Krajeski wrote: > *Explainer: *go/rcs-chromium That's not a public link, please could you make it public? > Risks > > Interoperability and Compatibility > > None > > > /Gecko/: No signal Why no signals from Gecko? Have we filled a

Re: [blink-dev] Intent to Implement & Ship: AudioEncoderConfig.bitrateMode

2023-08-23 Thread Manuel Rego Casasnovas
LGTM3 On 22/08/2023 16:30, Mike Taylor wrote: > LGTM2 > > On 8/22/23 10:10 AM, Yoav Weiss wrote: >> LGTM1. Mirroring video codecs makes sense. Glad to see Mozilla being >> supportive. >> >> On Thu, Aug 17, 2023 at 8:51 PM 'Thomas Guilbert' via blink-dev >> wrote: >> >> Contact emails >> >>

Re: [blink-dev] Intent to Ship: CSS Subgrid

2023-06-16 Thread Manuel Rego Casasnovas
LGTM3 Really looking forward for having subgrid support everywhere! On 15/06/2023 23:22, Yoav Weiss wrote: > LGTM2 > > On Thu, Jun 15, 2023 at 6:10 PM Yoav Weiss > wrote: > > > > On Thu, Jun 15, 2023 at 6:04 PM Ian Kilpatrick >

Re: [blink-dev] Intent to Ship: Boolean Context Style Container Queries

2023-05-03 Thread Manuel Rego Casasnovas
LGTM1 On 03/05/2023 14:22, Rune Lillesveen wrote: > > Contact emails > > futh...@chromium.org > > > Explainer > > None > > > Specification > > https://drafts.csswg.org/css-contain-3/#style-container >

Re: [blink-dev] Intent to Ship: overflow:overlay aliases overflow:auto

2023-04-11 Thread Manuel Rego Casasnovas
LGTM3 On 07/04/2023 17:38, Mike Taylor wrote: > LGTM2 > > On 4/7/23 11:34 AM, Yoav Weiss wrote: >> LGTM1 >> >> On Thu, Apr 6, 2023 at 2:01 AM Chris Harrelson >> wrote: >> >> >> Contact emails >> >> >> chris...@chromium.org >> >> >> Specification >> >> >>

Re: [blink-dev] Intent to Ship: CSS "overflow" media features

2023-03-15 Thread Manuel Rego Casasnovas
LGTM2 On 14/03/2023 16:13, Daniil Sakhapov wrote: > Done: > https://github.com/WebKit/standards-positions/issues/146 > > On Wednesday, March 8, 2023 at 6:09:22 PM UTC+1 Yoav Weiss wrote: > > LGTM1 % filing a WebKit position > > We discussed this intent at the API owner meeting (Rick,

Re: [blink-dev] Intent to Ship: WebAssembly extended-const Proposal

2023-03-08 Thread Manuel Rego Casasnovas
LGTM2. On 08/03/2023 14:00, Yoav Weiss wrote: > LGTM1 > > On Mon, Mar 6, 2023 at 12:39 PM Lutz Vahl > wrote: > > > Contact emails > > manosk...@google.com > > > Explainer > > >

Re: [blink-dev] Re: Intent to Ship: CSS "update" media feature

2023-03-08 Thread Manuel Rego Casasnovas
On 02/03/2023 05:59, Mike Taylor wrote: > > On 3/1/23 3:41 PM, Domenic Denicola wrote: >> >> >> On Wed, Mar 1, 2023 at 10:14 PM Yoav Weiss wrote: >> >> >> >> On Tue, Feb 28, 2023 at 4:07 PM Daniil Sakhapov >> wrote: >> >> agree, my mistake, I thought about explaining 3 types

Re: [blink-dev] Intent to Ship: Linear easing function

2023-03-08 Thread Manuel Rego Casasnovas
This has been already approved. Anyway one minor question, why are the WPT tests marked as "tentative"? https://wpt.fyi/results/css/css-easing Maybe now that is shipping in 2 browsers we could rename them. Cheers, Rego On 07/03/2023 16:57, Mike Taylor wrote: > LGTM2 > > On 3/7/23 6:10 AM,

Re: [blink-dev] Re: Intent to Ship: Unprefix -webkit-image-set

2023-03-08 Thread Manuel Rego Casasnovas
LGTM2 Thank you very much for fixing the issues before shipping. On 08/03/2023 10:53, Yoav Weiss wrote: > Even though wpt.fyi > > is reddish, I'm seeing all the tests pass on ToT. Thank

Re: [blink-dev] Intent to Ship: CSS font-variant-position property

2023-02-24 Thread Manuel Rego Casasnovas
Hi David, Thanks for the amazing email! On 23/02/2023 23:52, David Baron wrote: > I don't think the specification was designed around the idea that some > implementations would follow the spec's rules on synthesis and some > implementations would ignore the spec... and thus it does appear to be

Re: [blink-dev] Intent to Ship: Change beforeunload handler dialog condition

2023-02-21 Thread Manuel Rego Casasnovas
LGTM1 This aligns us with the rest of browsers, thanks for fixing it. Cheers, Rego On 21/02/2023 19:24, Di Zhang wrote: > > Contact emails > > dizha...@chromium.org > > > Specification > >

Re: [blink-dev] Intent to Deprecate: non-standard `shadowroot` attribute for declarative shadow DOM

2023-02-21 Thread Manuel Rego Casasnovas
Hi Mason, Are we planning to use deprecation reports (reporting API) for this deprecation? As a side note, I've realized we don't mention that at https://www.chromium.org/blink/launching-features/#feature-deprecations We only mention: "At this point, you should also notify developers by adding a

Re: [blink-dev] Intent to Ship: CSS font-variant-position property

2023-02-21 Thread Manuel Rego Casasnovas
gt; > x2 > > will render as "x²", somehow finding the "super" variant of 2 in the > font? > > The old way of doing this would be with > > x2 > > which will use the normal glyph for 2, but smaller and differently > positio

Re: [blink-dev] Intent to Ship: WebAssembly Tail Call

2023-02-15 Thread Manuel Rego Casasnovas
LGTM3 On 15/02/2023 18:16, Yoav Weiss wrote: > LGTM2 > > On Wed, Feb 15, 2023 at 6:10 PM Chris Harrelson > wrote: > > LGTM1 > > On Wed, Feb 15, 2023 at 8:09 AM 'Thibaud Michaud' via blink-dev > mailto:blink-dev@chromium.org>> wrote: > > > >

Re: [blink-dev] Intent to Ship: CSS font-variant-position property

2023-02-14 Thread Manuel Rego Casasnovas
Is there a way to feature detect the synthesis functionality or not? How a web author will be able to differentiate between Gecko vs Chromium/WebKit behaviors? Would the lack of this feature confuse authors? Maybe having some console message information when font-variant-position doesn't have any

Re: [blink-dev] Intent to Ship: WebGPU

2023-02-07 Thread Manuel Rego Casasnovas
script). +Kai Ninomiya <mailto:kain...@chromium.org>, feel > free to correct me if I missed something. > > Cheers, > > Corentin > > On Mon, Feb 6, 2023 at 5:55 PM Manuel Rego Casasnovas > mailto:r...@igalia.com>> wrote: > > >

Re: [blink-dev] Intent to Ship: WebGPU

2023-02-06 Thread Manuel Rego Casasnovas
On 14/12/2022 18:02, Corentin Wallez wrote: > The WebGPU Conformance Test Suite is being built > at https://github.com/gpuweb/cts  and can > be integrated as a subdirectory of WPT. Coverage is still incomplete due > to the complexity of the API but progressing

Re: [blink-dev] Intent to Ship: RegExp v flag with set notation + properties of strings

2023-01-26 Thread Manuel Rego Casasnovas
LGTM3 On 26/01/2023 10:12, Yoav Weiss wrote: > LGTM2 > > On Wed, Jan 25, 2023 at 5:55 PM Chris Harrelson > wrote: > > LGTM1 > > On Wed, Jan 25, 2023 at 7:52 AM 'Patrick Thier' via blink-dev > mailto:blink-dev@chromium.org>> wrote: > > >

Re: [blink-dev] Intent to Ship: CSS Nesting

2023-01-25 Thread Manuel Rego Casasnovas
Adding to Philip questions, there seems to be quite a lot of ongoing discussions around this topic on the CSSWG, for example today there's a special meeting only for CSS Nesting topics: https://lists.w3.org/Archives/Public/www-style/2023Jan/0011.html What's their impact on the current

Re: [blink-dev] Intent to Ship: Style Container Queries for CSS Custom Properties

2022-12-21 Thread Manuel Rego Casasnovas
LGTM3 On 19/12/2022 14:57, Rune Lillesveen wrote: > On Fri, Dec 16, 2022 at 9:11 PM Rick Byers > wrote: > > LGTM1 > > For other reviewers, I verified these tests are all passing 100% > (thank you Rune!): > >

Re: [blink-dev] Re: Intent to Ship: Unprefix -webkit-image-set

2022-12-14 Thread Manuel Rego Casasnovas
If we have plans to fix issues on this feature later, why not fixing them before and then shipping when things look good? If we unprefix it, it'll kind of appear as a new Chromium feature that people can use, and they will expect it follows the spec. But we'll have to document it just works for

Re: [blink-dev] Re: Intent to Ship: Unprefix -webkit-image-set

2022-12-07 Thread Manuel Rego Casasnovas
On 07/12/2022 12:37, Yoav Weiss wrote: > LGTM1 > > Thanks for working on this!! Looking at wpt.fyi, other implementations > are passing the test suite for this to varying degrees. Does this intent > cover full compliance with the test suite? (e.g. `type()`, `url()`, non > `x` descriptors, and

Re: [blink-dev] Intent to Implement and Ship: Unprefixed -webkit-image-set

2022-12-05 Thread Manuel Rego Casasnovas
/w3c/csswg-drafts/issues/6285> > > I guess we should also update things at: > https://chromestatus.com/feature/5432024223449088 > <https://chromestatus.com/feature/5432024223449088> > > I'll send a brand new one. >   > > And probably notify MDN so i

Re: [blink-dev] Intent to Implement and Ship: Unprefixed -webkit-image-set

2022-11-30 Thread Manuel Rego Casasnovas
Hi, On 01/12/2022 00:59, Traian Captan wrote: > This issue has been bugging devs since 2016. > > I'm landing a patch >  to > unprefix -webkit-image-set which will expose the current image-set > functionality without needing the

Re: [blink-dev] Intent to Ship: Expose Reporting API interfaces to JavaScript

2022-11-25 Thread Manuel Rego Casasnovas
WebKit has been doing some work implementing the Reporting API: https://bugs.webkit.org/show_bug.cgi?id=189365 Do we know their plans regarding this topic? Should we ask for signals? Cheers, Rego On 25/11/2022 15:39, Rick Byers wrote: > On Fri, Nov 25, 2022 at 9:27 AM Ian Clelland

Re: [blink-dev] Intent to Ship: Anonymous iframes

2022-11-03 Thread Manuel Rego Casasnovas
Hi, A few questions, is there any plan to move the spec code into HTML or other relevant specs? Do we have PRs for that? There's another feature called "Fenced frames" (https://chromestatus.com/feature/5699388062040064) that is currently being worked on. Wouldn't be nice to explain how anonymous

Re: [blink-dev] Intent to Remove: -webkit-perspective-origin-[x,y]

2022-10-28 Thread Manuel Rego Casasnovas
uud wrote: On Thu, Oct 27, 2022 at 11:27 AM Manuel Rego Casasnovas mailto:r...@igalia.com>> wrote: What's the status in other browsers? * WebKit does not support it (anymore). Could you point to a commit or a bug? I've only been able to find https://bugs.webkit.org/

Re: [blink-dev] Intent to Remove: -webkit-perspective-origin-[x,y]

2022-10-27 Thread Manuel Rego Casasnovas
On 27/10/2022 11:11, Anders Hartvoll Ruud wrote: Gecko: No signal WebKit: No signal What's the status in other browsers? Cheers, Rego -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop

Re: [blink-dev] Intent to Ship: CSS 'lh' Length Unit

2022-10-19 Thread Manuel Rego Casasnovas
LGTM1 On 17/10/2022 15:52, Rune Lillesveen wrote: > Asking for both lh and rlh: > > https://github.com/WebKit/standards-positions/issues/75 > > https://github.com/mozilla/standards-positions/issues/699 >

Re: [blink-dev] Intent to Prototype: CSS Initial Letters

2022-10-17 Thread Manuel Rego Casasnovas
On 14/10/2022 18:03, Ian Kilpatrick wrote: > > There are also a few CSSWG issues open, are them important? Should we > try to resolve them before shipping? > > > We haven't done an extensive review of the issues yet - but we didn't > see too many that are concerning. A lot of the

Re: [blink-dev] Intent to Prototype: CSS Initial Letters

2022-10-14 Thread Manuel Rego Casasnovas
On 13/10/2022 06:39, Yoshifumi Inoue wrote: > /Gecko/: Working  https://bugs.webkit.org/show_bug.cgi?id=136484 > Wrong link, this is a WebKit bug. If the link is https://bugzilla.mozilla.org/show_bug.cgi?id=1223880 it doesn't seem they are

Re: [blink-dev] Intent to Ship: CSS 'lh' Length Unit

2022-10-14 Thread Manuel Rego Casasnovas
On 13/10/2022 16:10, Rune Lillesveen wrote: > Summary > > Support for expressing CSS lengths relative to the line-height Is this only about "lh"? What about "rlh"? > /Gecko/: No signal (https://bugzilla.mozilla.org/show_bug.cgi?id=1310170 >

Re: [blink-dev] Intent to Ship: MathML

2022-10-14 Thread Manuel Rego Casasnovas
On 14/10/2022 07:53, Frédéric Wang wrote: > If I understand correctly [3], it is integrated in M108 (branched > yesterday) and the feature freeze for M109 will be October 27. So we > have two weeks to decide to enable MathML or not (if an issue with > LayoutNGPrinting is detected) [4]. I

Re: [blink-dev] Re: Intent to Ship: CSS Values and Units Module Level 4: Small/Large/Dynamic/Logical viewport units

2022-09-27 Thread Manuel Rego Casasnovas
LGTM3 On 27/09/2022 08:34, Yoav Weiss wrote: > LGTM2 > > Yay for interop!! > > On Tue, Sep 27, 2022 at 8:09 AM Mike West > wrote: > > LGTM1. > > It's great to see us following along with WebKit and Gecko's > implementations of these viewport units. The

Re: [blink-dev] Re: Intent to Ship: Variable COLRv1

2022-09-14 Thread Manuel Rego Casasnovas
LGTM3 On 09/09/2022 07:02, Mike Taylor wrote: LGTM2 On Thursday, September 8, 2022 at 9:42:54 AM UTC-4 dr...@google.com wrote: Hi Yoav, On Thursday, September 8, 2022 at 4:35:58 PM UTC+3 yoav...@chromium.org wrote: OK, so sounds like there's

Re: [blink-dev] Intent to Prototype & Ship: Client Hints persistency in Android WebView

2022-08-10 Thread Manuel Rego Casasnovas
LGTM3 On 09/08/2022 19:51, Daniel Bratell wrote: > LGTM2 > > /Daniel > > On 2022-08-09 19:43, Torne (Richard Coles) wrote: >> On Tue, 9 Aug 2022 at 04:24, Mike West wrote: >> >> LGTM1 to extend this already-approved feature to WebView. >> >> Presumably you'll be chatting with WebView

Re: [blink-dev] Intent to Ship: ContentVisibilityAutoStateChanged event

2022-08-10 Thread Manuel Rego Casasnovas
On 08/08/2022 20:48, Vladimir Levin wrote: > Explainer > > https://github.com/vmpstr/web-proposals/blob/main/explainers/cv-auto-event.md > Should we update the explainer to update on the a11y concerns

Re: [blink-dev] Intent to Ship: Unprefix -webkit-hyphenate-character CSS property

2022-08-10 Thread Manuel Rego Casasnovas
ifference between unprefixed and prefixed one, because > as you commented, > the prefixed one is just an alias of the unprefixed one. > > 2022년 8월 10일 (수) 오전 12:14, Manuel Rego Casasnovas <mailto:r...@igalia.com>>님이 작성: > > Just an extra clarification, would the

Re: [blink-dev] Intent to Ship: Unprefix -webkit-hyphenate-character CSS property

2022-08-09 Thread Manuel Rego Casasnovas
Just an extra clarification, would the prefixed version be just an alias of the unprefixed one, or are there any difference in behavior? I've added some comments on the interop section inline. On 09/08/2022 16:00, Joonghun Park wrote: > Yes, this will ship the unprefixed version, not dropping

Re: [blink-dev] Intent to Remove: window.webkitStorageInfo

2022-08-03 Thread Manuel Rego Casasnovas
LGTM3 On 03/08/2022 10:12, Yoav Weiss wrote: > LGTM2 to remove! > > On Wed, Aug 3, 2022 at 3:41 AM Mike Taylor > wrote: > > Hi Ayu, > > Thanks for digging into usage! I'm encouraged by the fact that > browserfs (even if not actively maintained) does

Re: [chromium-dev] Re: [blink-dev] Inactive OWNERS cleanup

2022-07-29 Thread Manuel Rego Casasnovas
On 28/07/2022 16:33, 'Matt Menke' via Chromium-dev wrote: > The assumption is not that they're no longer good owners, but that > people shouldn't have to spend a week waiting on them to reply to a > review before giving up and trying someone else.  Note that owners do > not need to be nominated

Re: [blink-dev] Intent to Ship: Custom Highlight API

2022-07-14 Thread Manuel Rego Casasnovas
One comment about this feature and legacy layout. It seems ::highlight customization is only supported in LayoutNG for most properties (only background-color works in legacy). I'm wondering if we should add some kind of console warning message, like for Container Queries [*], so if people see

Re: [blink-dev] Intent to Deprecate and Remove: CSS default keyword is disallowed in custom identifiers

2022-07-11 Thread Manuel Rego Casasnovas
LGTM2 On 11/07/2022 16:43, Yoav Weiss wrote: > LGTM1 given the thorough analysis and my understanding based on it that > the use counter is likely to be over-counting actual breakage. Thanks > for running it! :) > > On Thu, Jul 7, 2022 at 8:50 PM David Baron > wrote:

Re: [blink-dev] Intent to Ship: CSS :modal Pseudo Class

2022-06-29 Thread Manuel Rego Casasnovas
LGTM2 too with Philip's requests. On 29/06/2022 17:48, Philip Jägenstedt wrote: > LGTM1 to ship this with the latest spec changes applied, and WPT > written and passing for that. > > On Wed, Jun 29, 2022 at 5:27 PM Manuel Rego Casasnovas > wrote: >> >> Does Ch

Re: [blink-dev] Intent to Ship: CSS :modal Pseudo Class

2022-06-29 Thread Manuel Rego Casasnovas
Does Chromium implementation match the spec resolution, so :modal applies to fullscreen too? Are there tests checking that? Cheers, Rego On 27/06/2022 15:20, Jihwan Kim wrote: > I have updated the I2S contents including explainer, vendor signals > those are commented. > We may now progress

Re: [blink-dev] Intent to Ship: Custom Highlight API

2022-06-08 Thread Manuel Rego Casasnovas
I'm biased here as I've been working on this feature myself, so I cannot give an official LGTM. Thanks for all the work since the previous intent thread, I believe this is now in a way better status to ship. I'd be fine giving a LGTM with the following caveats: * As mentioned at the end of the

Re: [blink-dev] Intent to Ship: CSS :modal Pseudo Class

2022-05-25 Thread Manuel Rego Casasnovas
On 25/05/2022 08:52, Yoav Weiss wrote: > > Is this feature fully tested by web-platform-tests > > ? > > Yes > > > Link to the WPTs? There are these tests for ":modal": *

Re: [blink-dev] Re: Intent to Prototype and Ship: Support visual-box on overflow-clip-margin

2022-05-18 Thread Manuel Rego Casasnovas
LGTM3 On 18/05/2022 15:27, Mike Taylor wrote: > LGTM2 > > On 5/18/22 9:16 AM, Daniel Bratell wrote: >> >> LGTM1 >> >> It is a bit confusing with the TAG review mostly being negative, but I >> think they didn't object to this particular part. Furthermore, it >> seems useful, it's been reviewed

Re: [blink-dev] Intent to prototype and ship: CSS grid-template properties interpolation

2022-05-18 Thread Manuel Rego Casasnovas
Thanks for catching up on this. LGTM1 On 17/05/2022 18:44, 'Ana Sollano Kim' via blink-dev wrote: > > Contact emails > > ansol...@microsoft.com > , dli...@microsoft.com > > > > Explainer > > None > > >

[blink-dev] Intent to Ship: ARIA Attribute Reflection for role attribute

2022-04-17 Thread Manuel Rego Casasnovas
**Contact emails** r...@igalia.com **Specification** https://w3c.github.io/aria/#idl-interface **Summary** This is a kind of oversight from https://chromestatus.com/feature/6643371200217088, at that time all other ARIA attributes from the IDL (https://w3c.github.io/aria/#idl-interface) were

Re: [blink-dev] Intent to Implement and Ship: CSS Values Level 4 Calc Simplification and Serialization

2022-03-10 Thread Manuel Rego Casasnovas
LGTM3. On 10/03/2022 05:47, Yoav Weiss wrote: > LGTM2 > > On Thu, Mar 10, 2022 at 5:43 AM 박중헌 > wrote: > > Yes, they are the right wpts. Besides, many other wpts' > serialization results are affected to be in spec-compliant form > so they are changed to be

Re: [blink-dev] Re: Intent to Ship: Autofill in ShadowDOM

2022-02-16 Thread Manuel Rego Casasnovas
LGTM3. Some comments inline. On 16/02/2022 00:39, Mike Taylor wrote: >> Interoperability and Compatibility >> >> I believe there is low compat risk. As far as I know, much >> autofill behavior already diverges between browsers. >> >> Gecko: No signal >> >>

Re: [EXTERNAL] Re: [blink-dev] Intent to implement: Fluent Scrollbars.

2022-02-04 Thread Manuel Rego Casasnovas
Overlay scrollbars have caused issues testing things in the past: https://github.com/web-platform-tests/wpt/issues/10972 It'd be good to think about what we're going to do with these kind of tests, and as Steve says maybe it'd be good to keep tests running with overlay and non-overlay scrollbars

Re: [blink-dev] Intent to Ship: Digital Goods API v2.0

2022-02-03 Thread Manuel Rego Casasnovas
On 02/02/2022 16:51, Rouslan Solomakhin wrote: >> Rouslan, it looks to me like the API is designed to support multiple > stores, right? >> For example if Samsung decided that they wanted to support connecting > it up to >> both the Android Play Billing API (so SBrowser could provide >

Re: [blink-dev] Intent to Ship: Digital Goods API v2.0

2022-02-02 Thread Manuel Rego Casasnovas
TAG suggested back in July that this API something specific to Chrome or Google Play Store. It looks like this hasn't been done, any good reason to not doing that? Also there's been an update on the TAG about the plan of shipping this API without changing the name. But that was just 1 week ago,

Re: [blink-dev] Re: Intent to Ship: mix-blend-mode: plus-lighter

2022-01-26 Thread Manuel Rego Casasnovas
LGTM3. On 26/01/2022 15:50, Mike Taylor wrote: > LGTM2, thanks for the very well written explainer-slash-blog-post. > > On 1/26/22 9:42 AM, Yoav Weiss wrote: >> LGTM1 >> >> This seems like a useful small addition! Following WebKit here makes >> sense. >> On Wednesday, January 19, 2022 at 5:40:45

Re: [blink-dev] Intent to Prototype: mix-blend-mode: plus-lighter

2022-01-04 Thread Manuel Rego Casasnovas
On 16/12/2021 21:44, Vladimir Levin wrote: > Gecko: No signal Have we asked for signals? https://bit.ly/blink-signals > WebKit: Shipped/Shipping > (https://github.com/w3c/fxtf-drafts/issues/445#issuecomment-995022125 > )

Re: [blink-dev] Intent to Ship: Unprefixed text-emphasis properties

2021-12-16 Thread Manuel Rego Casasnovas
On 16/12/2021 15:49, TAMURA, Kent wrote: > I think so.  If the current implementation has interoperability issues, > we should fix them before shipping the unprefixed properties. LGTM3, if we fix the potential interop issues before shipping. Cheers, Rego -- You received this message

Re: [blink-dev] Intent to Ship: Unprefixed text-emphasis properties

2021-12-16 Thread Manuel Rego Casasnovas
Some questions regarding interoperability. On 16/12/2021 08:43, Yoav Weiss wrote: > On Wed, Dec 15, 2021 at 4:59 PM TAMURA, Kent > wrote: > Gecko: Shipped/Shipping > > WebKit: Shipped/Shipping When has WebKit shipped this? WPT tests seem to be

Re: [blink-dev] Re: Intent to Ship: CSS cascade layers

2021-12-09 Thread Manuel Rego Casasnovas
On 08/12/2021 18:48, Xiaocheng Hu wrote: > They are failing on wpt.fyi because the feature is not enabled there. > The feature is not behind the "experimental web platform features" flag. Isn't a bit strange to move a runtime feature from "test" to "stable", without having been in

Re: [blink-dev] Intent to Ship: Pickling for Async Clipboard API

2021-11-22 Thread Manuel Rego Casasnovas
On 18/11/2021 22:30, 'Anupam Snigdha' via blink-dev wrote: > /WebKit/: Neutral > (https://github.com/w3c/editing/issues/334#issuecomment-933939592 > ) > Webkit has a custom format implementation which isn't well documented. I'd

Re: [blink-dev] BlinkOn 15 is Today and Tomorrow

2021-11-17 Thread Manuel Rego Casasnovas
On 17/11/2021 11:38, 'Thomas Steiner' via blink-dev wrote: > Does the event platform publish to YouTube in the background? If so, > does anyone have the unlisted livestream links so I could follow up? Thanks! It looks like the talks from yesterday are already in the usual YouTube channel:

Re: [EXTERNAL] Re: [blink-dev] Intent to Ship: forced-color-adjust: preserve-parent-color

2021-11-05 Thread Manuel Rego Casasnovas
On a similar note of what I mentioned in the new "only" keyword for color-scheme property, I'm having a hard time getting the whole picture of that spec: https://drafts.csswg.org/css-color-adjust/ Do we have a full explainer of the whole spec? The spec is about 2 different things color schemes

Re: [blink-dev] Intent to Ship: auto keyword for contain-intrinsic-size

2021-11-04 Thread Manuel Rego Casasnovas
LGTM1 but please add WPT tests. On 29/10/2021 21:19, 'Christian Biesinger' via blink-dev wrote: > Is this feature fully tested by web-platform-tests? > > No I guess this is a mistake and you're actually adding WPT tests as part of this. Cheers, Rego -- You received this message because you

Re: [blink-dev] Intent to Ship: CSS Color Adjust: 'only' keyword for color-scheme

2021-11-04 Thread Manuel Rego Casasnovas
wrote: > LGTM1 > > /Daniel > > On 2021-10-29 21:09, Emilio Cobos Álvarez wrote: >> >> >> On 10/28/21 13:14, Rune Lillesveen wrote: >>> On Thu, Oct 28, 2021 at 12:11 PM Manuel Rego Casasnovas >>> mailto:r...@igalia.com>> wrote: >>>

Re: [blink-dev] Intent to Ship: New Canvas 2D API

2021-11-04 Thread Manuel Rego Casasnovas
LGTM3 On 04/11/2021 20:04, Daniel Bratell wrote: > LGTM2 > > /Daniel > > On 2021-11-04 20:02, Chris Harrelson wrote: >> LGTM1 to ship in parallel with landing the PR. >> >> On Thu, Nov 4, 2021 at 12:01 PM 'Aaron Krajeski' via blink-dev >> wrote: >> >> During a WHATWG spec meeting this

Re: [blink-dev] Intent to Prototype and Ship: self.structuredClone

2021-10-29 Thread Manuel Rego Casasnovas
LGTM2 On 29/10/2021 06:56, Yoav Weiss wrote: > LGTM1 > > On Thu, Oct 28, 2021 at 10:56 PM Andreu Botella > mailto:and...@andreubotella.com>> wrote: > > I don't think the differences are listed anywhere. I know there are > some because of the failures in > >

Re: [blink-dev] Intent to Ship: CSS Color Adjust: 'only' keyword for color-scheme

2021-10-28 Thread Manuel Rego Casasnovas
Hi, Some comments inline. On 27/10/2021 16:09, Rune Lillesveen wrote: > Summary > > The 'only' keyword has been re-added to the specification for > color-scheme as a way of per-element opt-out of color-scheme override > like forced darkening. I guess this is the CSSWG discussion about

Re: [blink-dev] Intent to Implement and Ship : onsecuritypolicyviolation event handler IDL attribute

2021-10-28 Thread Manuel Rego Casasnovas
This will ship in M97. Cheers, Rego On 27/10/2021 19:24, 'Joe Medley' via blink-dev wrote: > Hi, > > In which version of Chrome do you hope to ship? > Joe Medley | Technical Writer, Chrome DevRel | jmed...@google.com >  | 816-678-7195 > /If an API's not documented

Re: [blink-dev] Intent to Ship: Late newline normalization in form submission

2021-10-22 Thread Manuel Rego Casasnovas
LGTM2 On 22/10/2021 12:58, Daniel Bratell wrote: > Thanks for the clarification! My LGTM1 stands. > > /Daniel > > On 2021-10-22 12:51, Andreu Botella wrote: >> Just to clarify: inspecting a FormData object isn't the only way to >> observe this change. If you call fetch() with a FormData body,

Re: [blink-dev] Intent to Ship: Standardize existing client hint naming

2021-10-21 Thread Manuel Rego Casasnovas
LGTM2 On 21/10/2021 21:16, Daniel Bratell wrote: > LGTM1 > > /Daniel > > On Friday, 15 October 2021 at 14:41:44 UTC+2 ari...@chromium.org wrote: > > Correct, they’ll behave the same as the other non-legacy hints. > > On Fri, Oct 15, 2021 at 05:34 Yoav Weiss wrote: > > Thanks

Re: [blink-dev] Intent to Ship: Independent/Individual Properties for CSS Transforms

2021-10-21 Thread Manuel Rego Casasnovas
LGTM3. On 21/10/2021 19:53, Daniel Bratell wrote: > LGTM2. > > /Daniel > > On 2021-10-21 08:19, Yoav Weiss wrote: >> LGTM1 >> Seems important to catch up here, so thanks for working on this!! >> >> On Mon, Oct 18, 2021 at 11:05 PM David Baron wrote: >> >> >> Contact emails >> >> >>

Re: [blink-dev] Intent to Ship: COLRv1 Color Gradient Vector Fonts

2021-10-20 Thread Manuel Rego Casasnovas
LGTM2 On 20/10/2021 11:30, Dominik Röttsches wrote: > Hi Rego, > > Thanks for the feedback.  > > On Tue, Oct 19, 2021 at 9:01 PM Manuel Rego Casasnovas <mailto:r...@igalia.com>> wrote: > > Did we manage to get any further feedback from Appl

Re: [blink-dev] Intent to Ship: COLRv1 Color Gradient Vector Fonts

2021-10-19 Thread Manuel Rego Casasnovas
Hi Dominik, On 19/10/2021 09:31, Yoav Weiss wrote: > *WebKit:* Negative > (https://lists.webkit.org/pipermail/webkit-dev/2021-March/031765.html > ) > > From the WebKit team, we received this negative response

Re: [blink-dev] Intent to Ship: New Canvas 2D API

2021-10-14 Thread Manuel Rego Casasnovas
On 14/10/2021 23:06, Aaron Krajeski wrote: > *Specification* > Context Lost Event > > Context Restored Event > > Will Read Frequently >

Re: [blink-dev] Intent to Implement and Ship: transform: perspective(none)

2021-10-07 Thread Manuel Rego Casasnovas
LGTM2 On 07/10/2021 08:07, Yoav Weiss wrote: > LGTM1 > > On Mon, Oct 4, 2021 at 10:42 PM David Baron > wrote: > > > Contact emails > > dba...@chromium.org > > > Explainer > > None > > >

Re: [blink-dev] Intent to Ship: Do not invert selection background color when it matches text color

2021-10-05 Thread Manuel Rego Casasnovas
has transparency. Like this only happens if the text color also has such transparency. Anyway, we'll add this information on the CSSWG issue and see if there's any kind of agreement. So ignore this intent for now. Cheers, Rego > On Mon, Oct 4, 2021 at 1:34 PM Manuel Rego Casasnovas <mailto:r...@i

[blink-dev] Intent to Ship: Do not invert selection background color when it matches text color

2021-10-04 Thread Manuel Rego Casasnovas
**Contact emails** r...@igalia.com, dazab...@igalia.com **Specification** https://www.w3.org/TR/css-pseudo-4/#selectordef-selection **Summary** Right now selection background color is inverted when it matches the text color in Chromium. So if you have a rule like this "::selection { color:

  1   2   >