Re: [blink-dev] Debugging compressed pointers in Blink

> > Perhaps we should add a prettyprinter for cppgc::internal::MemberBase > which automatically calls that function? I just added a pretty-printer for (cppgc|blink)::(Weak|Untraced)Member. Any feedback is appreciated! Anton, can you add

Re: [blink-dev] Debugging compressed pointers in Blink

Perhaps we should add a prettyprinter for cppgc::internal::MemberBase which automatically calls that function? Christian On Tue, Oct 11, 2022 at 11:00 AM Dave Tapuska wrote: > Anton, can you add this to > https://source.chromium.org/chromium/chromium/src/+/main:docs/linux/debugging.md > ? > > O

Re: [blink-dev] Debugging compressed pointers in Blink

Anton, can you add this to https://source.chromium.org/chromium/chromium/src/+/main:docs/linux/debugging.md ? On Tue, Oct 11, 2022 at 10:19 AM Anton Bikineev wrote: > I'm now submitting a CL > that adds > some quick gdb helpers: > >

Re: [blink-dev] Debugging compressed pointers in Blink

I'm now submitting a CL that adds some quick gdb helpers: (gdb) source v8/tools/gdbinit # Print Member: (gdb) cpm ** # Print Compressed Pointer: (gdb) cpcp ** It currently erases the pointee type, but this can be improved in t

Re: [blink-dev] Debugging compressed pointers in Blink

> > Which should hopefully be callable from the debugger and not eliminated by > the linker? We can apply __attribute__((used,retain)) to make sure that the linker doesn't strip the functions with --gc-sections, same as did for V8 helper

Re: [blink-dev] Debugging compressed pointers in Blink

Maybe add NOINLINE for good measure, but yeah, I think that should work. On Mon, Oct 10, 2022 at 11:45 AM Daniel Cheng wrote: > For now, I guess it should be sufficient to add something > to v8/include/cppgc/internal/member-storage.h like > > #ifndef NDEBUG // DCHECK_IS_ON() would be nicer, but

Re: [blink-dev] Debugging compressed pointers in Blink

For now, I guess it should be sufficient to add something to v8/include/cppgc/internal/member-storage.h like #ifndef NDEBUG // DCHECK_IS_ON() would be nicer, but not sure what v8 uses extern "C" void* DecompressPointerForDebugger(uint32_t value) { return cppgc::internal::CompressedPointer::Deco

Re: [blink-dev] Debugging compressed pointers in Blink

I ran into this today, and it's pretty frustrating: (rr) p inner_node_ $11 = { = { raw_ = { static kCompressedSentinel = 1, value_ = 2148082696 } }, = {}, } (rr) p inner_node_.Load() Couldn't find method blink::Member::Load (rr) p inner_node_.raw_.Load() Cann

Re: [blink-dev] Debugging compressed pointers in Blink

Is there a bug to follow regarding the debuggability of the pointers? Ian On Thu, Sep 22, 2022 at 11:10 AM Anton Bikineev wrote: > There is "cppgc::internal::CompressedPointer::Decompress(void*)". I would, > however, hide it behind a simpler name in .gdbinit. > > On Thu, Sep 22, 2022 at 5:51 PM

Re: [blink-dev] Debugging compressed pointers in Blink

There is "cppgc::internal::CompressedPointer::Decompress(void*)". I would, however, hide it behind a simpler name in .gdbinit. On Thu, Sep 22, 2022 at 5:51 PM Daniel Cheng wrote: > Is there a callable C++ function that can turn a compressed pointer into > the actual pointer value? > > Daniel > >

Re: [blink-dev] Debugging compressed pointers in Blink

Is there a callable C++ function that can turn a compressed pointer into the actual pointer value? Daniel On Thu, 22 Sept 2022 at 08:43, Anton Bikineev wrote: > We have plans to provide more debugging tooling for Oilpan. I haven't had > a need to examine compressed pointers myself, however I se

Re: [blink-dev] Debugging compressed pointers in Blink

We have plans to provide more debugging tooling for Oilpan. I haven't had a need to examine compressed pointers myself, however I see that some simple gdb/windbg function that'd follow pointers would be useful. On Thu, Sep 22, 2022 at 1:14 AM Kentaro Hara wrote: > +Michael Lippautz > > 2022年9月2

Re: [blink-dev] Debugging compressed pointers in Blink

+Michael Lippautz 2022年9月22日(木) 4:01 'Daniel Libby' via blink-dev : > https://crrev.com/c/3835682 enabled pointer compression for Blink > Member<> pointers. How are folks handling these while debugging (either > live or crash dumps)? Is there some tooling available that will look up and > apply

[blink-dev] Debugging compressed pointers in Blink

https://crrev.com/c/3835682 enabled pointer compression for Blink Member<> pointers. How are folks handling these while debugging (either live or crash dumps)? Is there some tooling available that will look up and apply the cage base? I didn't see anything mentioned in https://docs.google.co