Re: [blink-dev] Intent to Deprecate and Remove: Support for filesystem URLs on Android media

2022-02-09 Thread Yoav Weiss
That sounds generally reasonable to me, with the main caveat being that deprecations require a clear timeline, and having one requires understanding of usage and having a plan for driving it down. It might be worthwhile to dig into usage and see who the main culprits are, and then try some targeted

Re: [blink-dev] Intent to Deprecate and Remove: Support for filesystem URLs on Android media

2022-02-08 Thread Brianna Goldstein
Hey all, following up with a proposed plan for moving forward here - The Chrome Storage team considers the old Filesystem API to be an undesirable API , one that should eventually be depre

Re: [blink-dev] Intent to Deprecate and Remove: Support for filesystem URLs on Android media

2022-02-04 Thread PhistucK
> I'm not sure if that's a legit URL if it doesn't have a double-slash after the first colon. Double-slash is not a requirement for all URL/URIs, for example, data:text/html,bla. file: uses triple-slash and so on... (Not entirely sure regarding URL versus URI, if you meant specifically the former a

Re: [blink-dev] Intent to Deprecate and Remove: Support for filesystem URLs on Android media

2022-02-03 Thread Mike Taylor
On 2/3/22 8:37 PM, Nigel Tao wrote: On Thu, Jan 27, 2022 at 3:23 AM Brianna Goldstein wrote: On Thu, Jan 27, 2022 at 2:49 AM Yoav Weiss wrote: At the risk of piling on with another question: are these URLs different from `file://` scheme URLs? @Yoav Weiss yes these are from the `filesystem:

Re: [blink-dev] Intent to Deprecate and Remove: Support for filesystem URLs on Android media

2022-02-03 Thread Nigel Tao
On Thu, Jan 27, 2022 at 3:23 AM Brianna Goldstein wrote: >On Thu, Jan 27, 2022 at 2:49 AM Yoav Weiss wrote: >> At the risk of piling on with another question: are these URLs different >> from `file://` scheme URLs? > > @Yoav Weiss yes these are from the `filesystem://` scheme which is different

Re: [blink-dev] Intent to Deprecate and Remove: Support for filesystem URLs on Android media

2022-02-03 Thread Frédéric Wang
Hello, filesystem: URLs were one of the remaining proprietary behavior when I was trying to unify the notions of "secure context" in Chromium [1]. I support a plan for unshipping it. To elaborate a bit, a URL is potentially trustworthy if its origin is potentially trustworthy [2]. But Chromi

Re: [blink-dev] Intent to Deprecate and Remove: Support for filesystem URLs on Android media

2022-02-02 Thread Chris Harrelson
Here are two more questions and one suggestion: 1. It looks like the usage on ChromeOS is an outlier. Is this due to Chrome Apps? Do we have UKM on it? 2. Is a migration to ServiceWorkers a simple drop-in replacement or would it require significant work for a site to adopt? 3. Do you think the lar

Re: [blink-dev] Intent to Deprecate and Remove: Support for filesystem URLs on Android media

2022-02-02 Thread Brianna Goldstein
Mike, these numbers are for media elements specifically. Since Chrome OS is > 1% I'd suggest removing `filesystem://` from Android as a first step in deprecating across platforms rather than leaving the Android path unpartitioned and then following up with a depreciation path to deprecate across pl

Re: [blink-dev] Intent to Deprecate and Remove: Support for filesystem URLs on Android media

2022-02-02 Thread Rick Byers
+1 to removing on all platforms if the numbers are low enough. But if the compat risk is materially greater on at least one other platform than on Android, I personally could accept removal just on Android as an acceptable first step on the deprecation path. Rick On Wed, Feb 2, 2022 at 11:58 AM

Re: [blink-dev] Intent to Deprecate and Remove: Support for filesystem URLs on Android media

2022-02-02 Thread Mike West
Thanks for the background, Victor! To your question: I don't think dropping `filesystem:` is more important than dropping WebSQL, but I share your excitement about deprecating the filesystem API. Brianna, I'm still interested in understanding whether the numbers you posted for other platforms r

Re: [blink-dev] Intent to Deprecate and Remove: Support for filesystem URLs on Android media

2022-02-02 Thread Alex Russell
While others weight in on the specific intent, I'd like to see the addition of handling Response objects (potentially directly from the Cache Storage) API added to Media elements as a replacement for this. Folks shouldn't have to need to install a Service Worker to do this directly, and it would

Re: [blink-dev] Intent to Deprecate and Remove: Support for filesystem URLs on Android media

2022-02-01 Thread Rick Byers
Given the plan to deprecate this blink-only technology, it does seem silly to do extra work to keep this one obscure case working. I agree though that developer confusion is a potential concern. Perhaps an exception / window.onerror explaining the reason for the failure to play media is enough? +1

Re: [blink-dev] Intent to Deprecate and Remove: Support for filesystem URLs on Android media

2022-02-01 Thread Victor Costan
Some background: - The *filesystem:* URL scheme was introduced to the *File API: Directories and System* specification , which I generally refer to as *the old FileSystem API*. This API is only implemented in Blink (maybe it

Re: [blink-dev] Intent to Deprecate and Remove: Support for filesystem URLs on Android media

2022-02-01 Thread Mike West
I worry that removing `filesystem:` for media elements on Android, while maintaining support for other platforms, will end up causing some developer confusion without much value for the codebase as a whole (since we need to maintain all the exciting bits and pieces of infrastructure). Are the n

Re: [blink-dev] Intent to Deprecate and Remove: Support for filesystem URLs on Android media

2022-01-26 Thread Brianna Goldstein
Additionally to follow up on @Chris Harrelson 's question on usage - Chrome OS usage is 1.38%, Mac OSX is at 0.12% and Windows is 0.05%. We propose to only remove support for Android here. On Tue, Jan 25, 2022 at 7:13 PM Chris Harrelson wrote: > Hi, could you outline the use counter values for o

Re: [blink-dev] Intent to Deprecate and Remove: Support for filesystem URLs on Android media

2022-01-26 Thread Rick Byers
Yoav, yeah this is a bit of rarely used legacy, see FileSystemEntry.toURL . IIRC we used filesystem URLs in Offline GMail to enable opening email attachments while offline. I think this provided a better UX than blob: URLs beca

Re: [blink-dev] Intent to Deprecate and Remove: Support for filesystem URLs on Android media

2022-01-26 Thread Brianna Goldstein
Hey all, To answer your questions - @Chris Harrelson The reason we want to remove support from Android specifically is that the media playback codepath is completely different on Android. Other platforms use the normal URL loading but on Android there is a custom code path which is difficult to

Re: [blink-dev] Intent to Deprecate and Remove: Support for filesystem URLs on Android media

2022-01-26 Thread Yoav Weiss
At the risk of piling on with another question: are these URLs different from `file://` scheme URLs? On Wednesday, January 26, 2022 at 11:41:17 AM UTC+1 Daniel Bratell wrote: > How confident can we be in the WebView counter? I'd expect this to be used > more in WebView than on other platforms.

Re: [blink-dev] Intent to Deprecate and Remove: Support for filesystem URLs on Android media

2022-01-26 Thread Daniel Bratell
How confident can we be in the WebView counter? I'd expect this to be used more in WebView than on other platforms. /Daniel On 2022-01-26 01:13, Chris Harrelson wrote: Hi, could you outline the use counter values for other platforms? Also, is there something special about Android that leads yo

Re: [blink-dev] Intent to Deprecate and Remove: Support for filesystem URLs on Android media

2022-01-25 Thread Chris Harrelson
Hi, could you outline the use counter values for other platforms? Also, is there something special about Android that leads you to want to disable only there? On Tue, Jan 25, 2022 at 1:58 PM Brianna Goldstein wrote: > Primary eng (and PM) emails > > brgoldst...@google.com, m...@chromium.com , >

[blink-dev] Intent to Deprecate and Remove: Support for filesystem URLs on Android media

2022-01-25 Thread Brianna Goldstein
Primary eng (and PM) emails brgoldst...@google.com, m...@chromium.com , jadekess...@chromium.com Explainer Storage partitioning explainer Summary We propose to remove support for loading media via fi