Re: [blink-dev] Intent to Ship: CSS font-size-adjust with the two-value syntax

2024-05-29 Thread 'Jason Robbins' via blink-dev
Pro-tip for API Owners who want to get their L-G-T-M's detected via email: start your reply with the magic word. ChromeStatus only looks for LGTMs in the first non-blank line of your message, which could be a whole paragraph since people usually don't break lines themselves in emails. The

Re: [blink-dev] Intent to Ship: CSS font-size-adjust with the two-value syntax

2024-05-29 Thread ChangSeok Oh
> On May 23, 2024, at 10:19 AM, Vladimir Levin wrote: > > > > On Wed, May 22, 2024 at 4:00 PM ChangSeok Oh wrote: > Hi Philip, > > I noticed that font-size-adjust-012.html, font-size-adjust-013.html, and > parts of font-size-adjust-computed.html (e.g., ch-width and ic-width) show > minor

Re: [blink-dev] Intent to Ship: CSS font-size-adjust with the two-value syntax

2024-05-23 Thread Vladimir Levin
On Wed, May 22, 2024 at 4:00 PM ChangSeok Oh wrote: > Hi Philip, > > I noticed that font-size-adjust-012.html, font-size-adjust-013.html, and > parts of font-size-adjust-computed.html (e.g., ch-width and ic-width) show > minor deviations from expected results. The exact issue with the WPT Linux

Re: [blink-dev] Intent to Ship: CSS font-size-adjust with the two-value syntax

2024-05-23 Thread Mike Taylor
LGTM2 On 5/23/24 12:06 PM, Philip Jägenstedt wrote: Thank you for looking into the test failures, ChangSeok! LGTM1 to align with Firefox and Safari on the remaining failures (except the reftests with minor pixel differences) and shipping! On Wed, May 22, 2024 at 10:05 PM ChangSeok Oh

Re: [blink-dev] Intent to Ship: CSS font-size-adjust with the two-value syntax

2024-05-23 Thread Philip Jägenstedt
Thank you for looking into the test failures, ChangSeok! LGTM1 to align with Firefox and Safari on the remaining failures (except the reftests with minor pixel differences) and shipping! On Wed, May 22, 2024 at 10:05 PM ChangSeok Oh wrote: > Hi Dominik, > > Thanks for your add-up! And Yes, we

Re: [blink-dev] Intent to Ship: CSS font-size-adjust with the two-value syntax

2024-05-23 Thread Philip Jägenstedt
On Wed, May 22, 2024 at 10:00 PM ChangSeok Oh wrote: > Hi Philip, > > I noticed that font-size-adjust-012.html, font-size-adjust-013.html, and > parts of font-size-adjust-computed.html (e.g., ch-width and ic-width) show > minor deviations from expected results. The exact issue with the WPT Linux

Re: [blink-dev] Intent to Ship: CSS font-size-adjust with the two-value syntax

2024-05-22 Thread ChangSeok Oh
Hi Dominik, Thanks for your add-up! And Yes, we can align with other browsers for the time being. -- ChangSeok > On May 21, 2024, at 6:13 AM, Dominik Röttsches wrote: > > Big thanks ChangSeok for implementing this and pushing for this feature. > > I can say a few things about the open

Re: [blink-dev] Intent to Ship: CSS font-size-adjust with the two-value syntax

2024-05-22 Thread ChangSeok Oh
Hi Philip, I noticed that font-size-adjust-012.html, font-size-adjust-013.html, and parts of font-size-adjust-computed.html (e.g., ch-width and ic-width) show minor deviations from expected results. The exact issue with the WPT Linux machine is unclear since these tests can be affected by

Re: [blink-dev] Intent to Ship: CSS font-size-adjust with the two-value syntax

2024-05-22 Thread ChangSeok Oh
Hi Vladimir, I requested the reviews in the chromestatus. Thanks. -- ChangSeok > On May 16, 2024, at 8:01 AM, Vladimir Levin wrote: > > > > On Thu, May 16, 2024 at 10:02 AM ChangSeok Oh wrote: > Contact emails > changseok...@bytedance.com, changs...@chromium.org > > Explainer > None > >

Re: [blink-dev] Intent to Ship: CSS font-size-adjust with the two-value syntax

2024-05-21 Thread 'Dominik Röttsches' via blink-dev
Big thanks ChangSeok for implementing this and pushing for this feature. I can say a few things about the open issues > - https://github.com/w3c/csswg-drafts/issues/6384 > font-size-adjust relies on a font metric reference point, for example, the x-height, cap-height, etc. in order to scale

Re: [blink-dev] Intent to Ship: CSS font-size-adjust with the two-value syntax

2024-05-21 Thread Philip Jägenstedt
Hi ChangSeok, Thank you for working on this, it's great to see both more powerful typography control, and progress on Interop 2024. Can you say something about the remaining failures in WPT? font-size-adjust-012.html font-size-adjust-013.html both look like minor differences, but it seems like

Re: [blink-dev] Intent to Ship: CSS font-size-adjust with the two-value syntax

2024-05-16 Thread Vladimir Levin
On Thu, May 16, 2024 at 10:02 AM ChangSeok Oh wrote: > Contact emails > changseok...@bytedance.com, changs...@chromium.org > > Explainer > None > > Specification > https://www.w3.org/TR/css-fonts-5/#font-size-adjust-prop > > Summary > > The font-size-adjust CSS property enhances readability

[blink-dev] Intent to Ship: CSS font-size-adjust with the two-value syntax

2024-05-16 Thread ChangSeok Oh
Contact emails changseok...@bytedance.com, changs...@chromium.org Explainer None Specification https://www.w3.org/TR/css-fonts-5/#font-size-adjust-prop Summary The font-size-adjust CSS property enhances readability consistency by adjusting font size based on lowercase letter height rather