Re: [blink-dev] Intent to Ship: Keyboard-focusable scroll containers

Make that LGTM3 from me. Good luck shipping! /Daniel On 2023-05-10 17:52, Philip Jägenstedt wrote: LGTM2 On Wed, May 10, 2023 at 5:50 PM Mike Taylor wrote: LGTM1 On 5/9/23 6:15 PM, Di Zhang wrote: Yes, this change is flagged behind the feature KeyboardFocusableScrollers (

Re: [blink-dev] Intent to Ship: Keyboard-focusable scroll containers

LGTM2 On Wed, May 10, 2023 at 5:50 PM Mike Taylor wrote: > LGTM1 > On 5/9/23 6:15 PM, Di Zhang wrote: > > Yes, this change is flagged behind the feature KeyboardFocusableScrollers > (disabled by passing > `--disable-blink-features=KeyboardFocusableScrollers`). > > We have looped in aleventhal@ f

Re: [blink-dev] Intent to Ship: Keyboard-focusable scroll containers

LGTM2 /Daniel On 2023-05-10 17:50, Mike Taylor wrote: LGTM1 On 5/9/23 6:15 PM, Di Zhang wrote: Yes, this change is flagged behind the feature KeyboardFocusableScrollers (disabled by passing `--disable-blink-features=KeyboardFocusableScrollers`). We have looped in aleventhal@ for similar a

Re: [blink-dev] Intent to Ship: Keyboard-focusable scroll containers

LGTM1 On 5/9/23 6:15 PM, Di Zhang wrote: Yes, this change is flagged behind the feature KeyboardFocusableScrollers (disabled by passing `--disable-blink-features=KeyboardFocusableScrollers`). We have looped in aleventhal@ for similar accessibility concern. Aaron is the one who implemented th

Re: [blink-dev] Intent to Ship: Keyboard-focusable scroll containers

Yes, this change is flagged behind the feature KeyboardFocusableScrollers (disabled by passing `--disable-blink-features=KeyboardFocusableScrollers`). We have looped in aleventhal@ for similar accessibility concern. Aaron is the one who implemented the Keyboard Focusable Scrollers feature on Gec

Re: [blink-dev] Intent to Ship: Keyboard-focusable scroll containers

Thanks Domenic, that's helpful and makes sense to me. It's perhaps whether this is a "web exposed" change or not. This sounds pretty safe to experiment with to me. Di please make sure behavior change is done behind a flag

Re: [blink-dev] Intent to Ship: Keyboard-focusable scroll containers

Speaking with my HTML Standard spec editor hat on, I think it's appropriate for Chromium to ship this without spec changes, as Di explains. Indeed, I'd be skeptical of changing the spec here. It might be worth opening an issue to discuss whether any changes are appropriate, but in general the spec

Re: [blink-dev] Intent to Ship: Keyboard-focusable scroll containers

Right - the spec leaves it up to the UA to determine what is a focusable area. All browsers treat this a bit differently, and have typically considered that behavior to be up to the browser. For example, Safari has a user setting that can change what types of elements become keyboard focusab

Re: [blink-dev] Intent to Ship: Keyboard-focusable scroll containers

On 4/27/23 5:28 PM, Di Zhang wrote: Contact emails h...@chromium.org, xiaoche...@chromium.org, dizha...@chromium.org Explainer None Specification None What's the reason for not having a spec? Is the idea that this is covered by this definition of a "focusable a

[blink-dev] Intent to Ship: Keyboard-focusable scroll containers

Contact emailsh...@chromium.org, xiaoche...@chromium.org, dizha...@chromium.org ExplainerNone Specification None Design docsNone Summary Improves accessibility by making scroll containers focusable using sequential focus navigation. Today, the tab key doesn't focus scrollers unless tabIndex is